[powerpc changes] Re: x86/non-x86: percpu, node ids, apic ids x86.git fixup
* Olof Johansson [EMAIL PROTECTED] wrote: could you try the full patchset that Travis has just sent and which i've put into x86.git, you can pull it from: Looks ok for powerpc so far, I haven't gotten through all defconfigs yet but the first ones that failed before build now. pasemi_defconfig boots as well. could the PowerPC maintainers please Ack the following patch (attached below): Subject: POWERPC: use generic per cpu From: [EMAIL PROTECTED] so that we can push this fix upstream ASAP? Ingo --- Subject: POWERPC: use generic per cpu From: [EMAIL PROTECTED] Powerpc has a way to determine the address of the per cpu area of the currently executing processor via the paca and the array of per cpu offsets is avoided by looking up the per cpu area from the remote paca's (copying x86_64). Cc: Paul Mackerras [EMAIL PROTECTED] Cc: Geert Uytterhoeven [EMAIL PROTECTED] Signed-off-by: Mike Travis [EMAIL PROTECTED] Signed-off-by: Ingo Molnar [EMAIL PROTECTED] --- include/asm-powerpc/percpu.h | 22 +++--- 1 file changed, 3 insertions(+), 19 deletions(-) Index: linux-x86.q/include/asm-powerpc/percpu.h === --- linux-x86.q.orig/include/asm-powerpc/percpu.h +++ linux-x86.q/include/asm-powerpc/percpu.h @@ -13,28 +13,12 @@ #include asm/paca.h #define __per_cpu_offset(cpu) (paca[cpu].data_offset) -#define __my_cpu_offset() get_paca()-data_offset +#define __my_cpu_offset get_paca()-data_offset #define per_cpu_offset(x) (__per_cpu_offset(x)) -/* var is in discarded region: offset to particular copy we want */ -#define per_cpu(var, cpu) (*RELOC_HIDE(per_cpu__##var, __per_cpu_offset(cpu))) -#define __get_cpu_var(var) (*RELOC_HIDE(per_cpu__##var, __my_cpu_offset())) -#define __raw_get_cpu_var(var) (*RELOC_HIDE(per_cpu__##var, local_paca-data_offset)) +#endif /* CONFIG_SMP */ +#endif /* __powerpc64__ */ -extern void setup_per_cpu_areas(void); - -#else /* ! SMP */ - -#define per_cpu(var, cpu) (*((void)(cpu), per_cpu__##var)) -#define __get_cpu_var(var) per_cpu__##var -#define __raw_get_cpu_var(var) per_cpu__##var - -#endif /* SMP */ - -#define DECLARE_PER_CPU(type, name) extern __typeof__(type) per_cpu__##name - -#else #include asm-generic/percpu.h -#endif #endif /* _ASM_POWERPC_PERCPU_H_ */ ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [powerpc changes] Re: x86/non-x86: percpu, node ids, apic ids x86.git fixup
On Wed, Jan 30, 2008 at 10:25:58PM +0100, Ingo Molnar wrote: * Olof Johansson [EMAIL PROTECTED] wrote: could you try the full patchset that Travis has just sent and which i've put into x86.git, you can pull it from: Looks ok for powerpc so far, I haven't gotten through all defconfigs yet but the first ones that failed before build now. pasemi_defconfig boots as well. could the PowerPC maintainers please Ack the following patch (attached below): Subject: POWERPC: use generic per cpu From: [EMAIL PROTECTED] so that we can push this fix upstream ASAP? Subject: POWERPC: use generic per cpu From: [EMAIL PROTECTED] Powerpc has a way to determine the address of the per cpu area of the currently executing processor via the paca and the array of per cpu offsets is avoided by looking up the per cpu area from the remote paca's (copying x86_64). Cc: Paul Mackerras [EMAIL PROTECTED] Cc: Geert Uytterhoeven [EMAIL PROTECTED] Signed-off-by: Mike Travis [EMAIL PROTECTED] Signed-off-by: Ingo Molnar [EMAIL PROTECTED] Paul is at LCA, I'm not sure if he's reading email. Looks good to me so: Acked-by: Olof Johansson [EMAIL PROTECTED] -Olof ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [powerpc changes] Re: x86/non-x86: percpu, node ids, apic ids x86.git fixup
Ingo Molnar wrote: * Olof Johansson [EMAIL PROTECTED] wrote: could you try the full patchset that Travis has just sent and which i've put into x86.git, you can pull it from: Looks ok for powerpc so far, I haven't gotten through all defconfigs yet but the first ones that failed before build now. pasemi_defconfig boots as well. could the PowerPC maintainers please Ack the following patch (attached below): Subject: POWERPC: use generic per cpu From: [EMAIL PROTECTED] so that we can push this fix upstream ASAP? Ingo --- Subject: POWERPC: use generic per cpu From: [EMAIL PROTECTED] Powerpc has a way to determine the address of the per cpu area of the currently executing processor via the paca and the array of per cpu offsets is avoided by looking up the per cpu area from the remote paca's (copying x86_64). Cc: Paul Mackerras [EMAIL PROTECTED] Cc: Geert Uytterhoeven [EMAIL PROTECTED] Signed-off-by: Mike Travis [EMAIL PROTECTED] Signed-off-by: Ingo Molnar [EMAIL PROTECTED] --- include/asm-powerpc/percpu.h | 22 +++--- 1 file changed, 3 insertions(+), 19 deletions(-) Tested on PS3 with ps3_defconfig and works OK. Acked-by: Geoff Levand [EMAIL PROTECTED] ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev