RE: [v2,8/9] fsl/fman: Add FMan Port Support

2015-06-28 Thread Liberman Igal 
Hi Paul,
All those exported functions are used by DPAA ETH driver, which was submitted 
by Bucur Madalin (only fm_port_get_buffer_time_stamp() is not used currently, 
I'll remove it).

Regards,
Igal Liberman.

 -Original Message-
 From: Paul Bolle [mailto:pebo...@tiscali.nl]
 Sent: Friday, June 26, 2015 2:29 AM
 To: Liberman Igal-B31950; net...@vger.kernel.org
 Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; Bucur Madalin-
 Cristian-B32716
 Subject: Re: [v2,8/9] fsl/fman: Add FMan Port Support
 
 On Wed, 2015-06-24 at 22:37 +0300, igal.liber...@freescale.com wrote:
  --- a/drivers/net/ethernet/freescale/fman/fm_drv.c
  +++ b/drivers/net/ethernet/freescale/fman/fm_drv.c
 
  +struct fm_port_t *fm_port_drv_handle(const struct fm_port_drv_t
  +*port) {
  +   return port-fm_port;
  +}
  +EXPORT_SYMBOL(fm_port_drv_handle);
 
 I couldn't find any users of this function.
 
  +void fm_port_get_buff_layout_ext_params(struct fm_port_drv_t *port,
  +  struct fm_port_params *params)
 
 (Evolution 3.16 is a piece of ...).
 
  +{
  +   params-data_align = 0;
  +}
  +EXPORT_SYMBOL(fm_port_get_buff_layout_ext_params);
 
 Ditto.
 
  +int fm_get_tx_port_channel(struct fm_port_drv_t *port) {
  +   return port-tx_ch;
  +}
  +EXPORT_SYMBOL(fm_get_tx_port_channel);
 
 Ditto.
 
  --- /dev/null
  +++ b/drivers/net/ethernet/freescale/fman/fm_port_drv.c
 
  +void fm_set_rx_port_params(struct fm_port_drv_t *port,
  +  struct fm_port_params *params)
  +{
 + [...]
  +}
  +EXPORT_SYMBOL(fm_set_rx_port_params);
 
 Ditto.
 
 (If you hear about my arrest for randomly attacking innocent people:
 blame evolution 3.16!)
 
  +void fm_set_tx_port_params(struct fm_port_drv_t *port,
  +  struct fm_port_params *params)
  +{
  +   [...]
  +}
  +EXPORT_SYMBOL(fm_set_tx_port_params);
 
 Ditto.
 
  --- /dev/null
  +++ b/drivers/net/ethernet/freescale/fman/port/fm_port.c
 
  +u64 *fm_port_get_buffer_time_stamp(const struct fm_port_t
 *p_fm_port,
  +  char *p_data)
  +{
  +   [...]
  +}
  +EXPORT_SYMBOL(fm_port_get_buffer_time_stamp);
 
 Ditto.
 
  +int fm_port_disable(struct fm_port_t *p_fm_port) {
  +   [...]
  +}
  +EXPORT_SYMBOL(fm_port_disable);
 
 This exports a function that I think is only used inside this file.
 
  +int fm_port_enable(struct fm_port_t *p_fm_port) {
  +   [...]
  +}
  +EXPORT_SYMBOL(fm_port_enable);
 
 And here I could again find no users of this function.
 
 Thanks,
 
 
 Paul Bolle
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [v2,8/9] fsl/fman: Add FMan Port Support

2015-06-28 Thread Scott Wood 
Why are these two parts being submitted separately?  Worse, the CC list seems 
to be different for each part as I'm not seeing the DPAA ETH driver.

-Scott

On Sun, 2015-06-28 at 03:06 -0500, Liberman Igal-B31950 wrote:
 Hi Paul,
 All those exported functions are used by DPAA ETH driver, which was 
 submitted by Bucur Madalin (only fm_port_get_buffer_time_stamp() is not 
 used currently, I'll remove it).
 
 Regards,
 Igal Liberman.
 
  -Original Message-
  From: Paul Bolle [mailto:pebo...@tiscali.nl]
  Sent: Friday, June 26, 2015 2:29 AM
  To: Liberman Igal-B31950; net...@vger.kernel.org
  Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; Bucur Madalin-
  Cristian-B32716
  Subject: Re: [v2,8/9] fsl/fman: Add FMan Port Support
  
  On Wed, 2015-06-24 at 22:37 +0300,  igal.liberman@freescale.comwrote:
   --- a/drivers/net/ethernet/freescale/fman/fm_drv.c
   +++ b/drivers/net/ethernet/freescale/fman/fm_drv.c
  
   +struct fm_port_t *fm_port_drv_handle(const struct fm_port_drv_t
   +*port) {
   + return port-fm_port;
   +}
   +EXPORT_SYMBOL(fm_port_drv_handle);
  
  I couldn't find any users of this function.
  
   +void fm_port_get_buff_layout_ext_params(struct fm_port_drv_t *port,
   +struct fm_port_params *params)
  
  (Evolution 3.16 is a piece of ...).
  
   +{
   + params-data_align = 0;
   +}
   +EXPORT_SYMBOL(fm_port_get_buff_layout_ext_params);
  
  Ditto.
  
   +int fm_get_tx_port_channel(struct fm_port_drv_t *port) {
   + return port-tx_ch;
   +}
   +EXPORT_SYMBOL(fm_get_tx_port_channel);
  
  Ditto.
  
   --- /dev/null
   +++ b/drivers/net/ethernet/freescale/fman/fm_port_drv.c
  
   +void fm_set_rx_port_params(struct fm_port_drv_t *port,
   +struct fm_port_params *params)
   +{
  +   [...]
   +}
   +EXPORT_SYMBOL(fm_set_rx_port_params);
  
  Ditto.
  
  (If you hear about my arrest for randomly attacking innocent people:
  blame evolution 3.16!)
  
   +void fm_set_tx_port_params(struct fm_port_drv_t *port,
   +struct fm_port_params *params)
   +{
   + [...]
   +}
   +EXPORT_SYMBOL(fm_set_tx_port_params);
  
  Ditto.
  
   --- /dev/null
   +++ b/drivers/net/ethernet/freescale/fman/port/fm_port.c
  
   +u64 *fm_port_get_buffer_time_stamp(const struct fm_port_t
  *p_fm_port,
   +char *p_data)
   +{
   + [...]
   +}
   +EXPORT_SYMBOL(fm_port_get_buffer_time_stamp);
  
  Ditto.
  
   +int fm_port_disable(struct fm_port_t *p_fm_port) {
   + [...]
   +}
   +EXPORT_SYMBOL(fm_port_disable);
  
  This exports a function that I think is only used inside this file.
  
   +int fm_port_enable(struct fm_port_t *p_fm_port) {
   + [...]
   +}
   +EXPORT_SYMBOL(fm_port_enable);
  
  And here I could again find no users of this function.
  
  Thanks,
  
  
  Paul Bolle
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [v2,8/9] fsl/fman: Add FMan Port Support

2015-06-25 Thread Paul Bolle 
On Wed, 2015-06-24 at 22:37 +0300, igal.liber...@freescale.com wrote:
 --- a/drivers/net/ethernet/freescale/fman/fm_drv.c
 +++ b/drivers/net/ethernet/freescale/fman/fm_drv.c

 +struct fm_port_t *fm_port_drv_handle(const struct fm_port_drv_t *port)
 +{
 + return port-fm_port;
 +}
 +EXPORT_SYMBOL(fm_port_drv_handle);

I couldn't find any users of this function.

 +void fm_port_get_buff_layout_ext_params(struct fm_port_drv_t *port,
 +struct fm_port_params *params)

(Evolution 3.16 is a piece of ...).

 +{
 + params-data_align = 0;
 +}
 +EXPORT_SYMBOL(fm_port_get_buff_layout_ext_params);

Ditto.

 +int fm_get_tx_port_channel(struct fm_port_drv_t *port)
 +{
 + return port-tx_ch;
 +}
 +EXPORT_SYMBOL(fm_get_tx_port_channel);

Ditto.

 --- /dev/null
 +++ b/drivers/net/ethernet/freescale/fman/fm_port_drv.c

 +void fm_set_rx_port_params(struct fm_port_drv_t *port,
 +struct fm_port_params *params)
 +{
+   [...]
 +}
 +EXPORT_SYMBOL(fm_set_rx_port_params);

Ditto.

(If you hear about my arrest for randomly attacking innocent people:
blame evolution 3.16!)

 +void fm_set_tx_port_params(struct fm_port_drv_t *port,
 +struct fm_port_params *params)
 +{
 + [...]
 +}
 +EXPORT_SYMBOL(fm_set_tx_port_params);

Ditto.

 --- /dev/null
 +++ b/drivers/net/ethernet/freescale/fman/port/fm_port.c

 +u64 *fm_port_get_buffer_time_stamp(const struct fm_port_t *p_fm_port,
 +char *p_data)
 +{
 + [...]
 +}
 +EXPORT_SYMBOL(fm_port_get_buffer_time_stamp);

Ditto.

 +int fm_port_disable(struct fm_port_t *p_fm_port)
 +{
 + [...]
 +}
 +EXPORT_SYMBOL(fm_port_disable);

This exports a function that I think is only used inside this file.

 +int fm_port_enable(struct fm_port_t *p_fm_port)
 +{
 + [...]
 +}
 +EXPORT_SYMBOL(fm_port_enable);

And here I could again find no users of this function.

Thanks,


Paul Bolle
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev