Re: [PATCH] common: dma-mapping: add support for generic dma_mmap_* calls

2012-06-29 Thread Clemens Ladisch 
Marek Szyprowski wrote:
 +++ b/drivers/base/dma-mapping.c
 ...
 +int dma_common_mmap(struct device *dev, struct vm_area_struct *vma,
 + void *cpu_addr, dma_addr_t dma_addr, size_t size)
 +{
 + int ret = -ENXIO;
 + ...
 + if (dma_mmap_from_coherent(dev, vma, cpu_addr, size, ret))
 + return ret;

This will return -ENXIO if dma_mmap_from_coherent() succeeds.


Regards,
Clemens
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

RE: [PATCH] common: dma-mapping: add support for generic dma_mmap_* calls

2012-06-29 Thread Marek Szyprowski 
Hi,

On Friday, June 29, 2012 1:10 PM Clemens Ladisch wrote:

 Marek Szyprowski wrote:
  +++ b/drivers/base/dma-mapping.c
  ...
  +int dma_common_mmap(struct device *dev, struct vm_area_struct *vma,
  +   void *cpu_addr, dma_addr_t dma_addr, size_t size)
  +{
  +   int ret = -ENXIO;
  +   ...
  +   if (dma_mmap_from_coherent(dev, vma, cpu_addr, size, ret))
  +   return ret;
 
 This will return -ENXIO if dma_mmap_from_coherent() succeeds.
 
Thanks for spotting this! I will fix it in the next version of the patch.

Best regards
-- 
Marek Szyprowski
Samsung Poland RD Center


___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] common: dma-mapping: add support for generic dma_mmap_* calls

2012-06-29 Thread Clemens Ladisch 
Marek Szyprowski wrote:
 On Friday, June 29, 2012 1:10 PM Clemens Ladisch wrote:
 Marek Szyprowski wrote:
 +++ b/drivers/base/dma-mapping.c
 ...
 +int dma_common_mmap(struct device *dev, struct vm_area_struct *vma,
 +   void *cpu_addr, dma_addr_t dma_addr, size_t size)
 +{
 +   int ret = -ENXIO;
 +   ...
 +   if (dma_mmap_from_coherent(dev, vma, cpu_addr, size, ret))
 +   return ret;

 This will return -ENXIO if dma_mmap_from_coherent() succeeds.

 Thanks for spotting this!

Sorry, I was wrong; ret is actually set by dma_mmap_from_coherent's
output parameter.  (That function's documentation appears to be
incomplete.)


Regards,
Clemens
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev