Re: [PATCH 00/14] Modifications for DWC OTG since v13
Hi, В Wed, 31 Aug 2011 10:18:42 +0900 Kyungmin Park kmp...@infradead.org пишет: On Wed, Aug 31, 2011 at 12:46 AM, Pratyush Anand pratyush.an...@gmail.com wrote: On Tue, Aug 30, 2011 at 8:57 PM, Tirumala Marri tma...@apm.com wrote: -Original Message- From: Pratyush Anand [mailto:pratyush.an...@st.com] Sent: Tuesday, August 30, 2011 4:58 AM To: linux-...@vger.kernel.org Cc: tma...@apm.com; linuxppc-dev@lists.ozlabs.org; fc...@apm.com; mmiesf...@apm.com; shiraz.has...@st.com; deepak.si...@st.com; vipulkumar.sa...@st.com; rajeev-dlh.ku...@st.com; vipin.ku...@st.com; bhupesh.sha...@st.com; viresh.ku...@st.com; amit.vi...@st.com; Pratyush Anand Subject: [PATCH 00/14] Modifications for DWC OTG since v13 These patches are based on:http://patchwork.ozlabs.org/patch/89560/ After not getting any reply from developers, I started to do modifications for my platform (SPEAr1340). I have done modifications in such a way that all the code in driver/usb/dwc/ would be platform independent. I have tested this code for host/device/dma/slave mode. My fifo configuration is dedicated and dynamic. [Tirumala Marri] We are working on our next release of patches. They should be coming out soon. Oh, thats great !! Actually, I did not get any reply of my previous mail on your patch release. I thought no one is maintaining., and so I sent them with my modifications, after testing them in all dev/host/otg mode. Regards Pratyush Hi, Can you provide the git repo to test? and I wonder what's the difference between dwc (from you) and dwc3 (from Felipe Balbi). I think it's dwc targets for usb 2.0 and dwc3 for usb 3.0. It doesn't look the same. At least, register definitions are quite different. -- Alexander signature.asc Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 00/14] Modifications for DWC OTG since v13
On Wed, Aug 31, 2011 at 6:48 AM, Kyungmin Park kmp...@infradead.org wrote: On Wed, Aug 31, 2011 at 12:46 AM, Pratyush Anand pratyush.an...@gmail.com wrote: On Tue, Aug 30, 2011 at 8:57 PM, Tirumala Marri tma...@apm.com wrote: -Original Message- From: Pratyush Anand [mailto:pratyush.an...@st.com] Sent: Tuesday, August 30, 2011 4:58 AM To: linux-...@vger.kernel.org Cc: tma...@apm.com; linuxppc-dev@lists.ozlabs.org; fc...@apm.com; mmiesf...@apm.com; shiraz.has...@st.com; deepak.si...@st.com; vipulkumar.sa...@st.com; rajeev-dlh.ku...@st.com; vipin.ku...@st.com; bhupesh.sha...@st.com; viresh.ku...@st.com; amit.vi...@st.com; Pratyush Anand Subject: [PATCH 00/14] Modifications for DWC OTG since v13 These patches are based on:http://patchwork.ozlabs.org/patch/89560/ After not getting any reply from developers, I started to do modifications for my platform (SPEAr1340). I have done modifications in such a way that all the code in driver/usb/dwc/ would be platform independent. I have tested this code for host/device/dma/slave mode. My fifo configuration is dedicated and dynamic. [Tirumala Marri] We are working on our next release of patches. They should be coming out soon. Oh, thats great !! Actually, I did not get any reply of my previous mail on your patch release. I thought no one is maintaining., and so I sent them with my modifications, after testing them in all dev/host/otg mode. Regards Pratyush Hi, Can you provide the git repo to test? Currently, these patches are also in circulation for internal reviews. Once reviewed internally, will push them to git repo and will let you know. and I wonder what's the difference between dwc (from you) and dwc3 (from Felipe Balbi). I think it's dwc targets for usb 2.0 and dwc3 for usb 3.0. dwc3 is for DesignWare USB3 DRD Controller Core these patches are for DesignWare USB2.0 High Speed OTG Controller Regards Pratyush Thank you, Kyungmin Park -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 00/14] Modifications for DWC OTG since v13
Hi, (you did not add Greg in Cc, he's the USB maintainer. You also didn't Cc myself as maintainer of the gadget framework) On Tue, Aug 30, 2011 at 05:27:47PM +0530, Pratyush Anand wrote: These patches are based on:http://patchwork.ozlabs.org/patch/89560/ After not getting any reply from developers, I started to do modifications for my platform (SPEAr1340). I have done modifications in such a way that all the code in driver/usb/dwc/ would be platform independent. I have tested this code for host/device/dma/slave mode. My fifo configuration is dedicated and dynamic. Looking at that driver code, I believe this is pretty much Synopsys reference code with a few tweaks. If you want some tip, don't do that. The reference driver, while functional, has lots of unnecessary layering which should be avoided. See how we wrote the DWC3 driver. It's very small code which does the necessary. It's now functionally complete, from now on we only need to improve on performance (for example starting transfers on Transfer Complete event if we already have requests queued). Nevertheless, the driver is small and has been tested with all transfer types. If you really want to use this driver as is, that's your call. But I would suggest to Greg that he only takes this in if there is someone dedicated to maintain it. It's a really big codebase and whenever I change something on the gadget framework I will have to patch this beast too. If there's no maintainer assigned to it, who's willing to put effort in improving this driver in the long run, I think this will become yet another burden on the community. Still, it's your call. -- balbi signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
RE: [PATCH 00/14] Modifications for DWC OTG since v13
-Original Message- From: Pratyush Anand [mailto:pratyush.an...@st.com] Sent: Tuesday, August 30, 2011 4:58 AM To: linux-...@vger.kernel.org Cc: tma...@apm.com; linuxppc-dev@lists.ozlabs.org; fc...@apm.com; mmiesf...@apm.com; shiraz.has...@st.com; deepak.si...@st.com; vipulkumar.sa...@st.com; rajeev-dlh.ku...@st.com; vipin.ku...@st.com; bhupesh.sha...@st.com; viresh.ku...@st.com; amit.vi...@st.com; Pratyush Anand Subject: [PATCH 00/14] Modifications for DWC OTG since v13 These patches are based on:http://patchwork.ozlabs.org/patch/89560/ After not getting any reply from developers, I started to do modifications for my platform (SPEAr1340). I have done modifications in such a way that all the code in driver/usb/dwc/ would be platform independent. I have tested this code for host/device/dma/slave mode. My fifo configuration is dedicated and dynamic. [Tirumala Marri] We are working on our next release of patches. They should be coming out soon. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 00/14] Modifications for DWC OTG since v13
On Tue, Aug 30, 2011 at 8:57 PM, Tirumala Marri tma...@apm.com wrote: -Original Message- From: Pratyush Anand [mailto:pratyush.an...@st.com] Sent: Tuesday, August 30, 2011 4:58 AM To: linux-...@vger.kernel.org Cc: tma...@apm.com; linuxppc-dev@lists.ozlabs.org; fc...@apm.com; mmiesf...@apm.com; shiraz.has...@st.com; deepak.si...@st.com; vipulkumar.sa...@st.com; rajeev-dlh.ku...@st.com; vipin.ku...@st.com; bhupesh.sha...@st.com; viresh.ku...@st.com; amit.vi...@st.com; Pratyush Anand Subject: [PATCH 00/14] Modifications for DWC OTG since v13 These patches are based on:http://patchwork.ozlabs.org/patch/89560/ After not getting any reply from developers, I started to do modifications for my platform (SPEAr1340). I have done modifications in such a way that all the code in driver/usb/dwc/ would be platform independent. I have tested this code for host/device/dma/slave mode. My fifo configuration is dedicated and dynamic. [Tirumala Marri] We are working on our next release of patches. They should be coming out soon. Oh, thats great !! Actually, I did not get any reply of my previous mail on your patch release. I thought no one is maintaining., and so I sent them with my modifications, after testing them in all dev/host/otg mode. Regards Pratyush -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 00/14] Modifications for DWC OTG since v13
On Wed, Aug 31, 2011 at 12:46 AM, Pratyush Anand pratyush.an...@gmail.com wrote: On Tue, Aug 30, 2011 at 8:57 PM, Tirumala Marri tma...@apm.com wrote: -Original Message- From: Pratyush Anand [mailto:pratyush.an...@st.com] Sent: Tuesday, August 30, 2011 4:58 AM To: linux-...@vger.kernel.org Cc: tma...@apm.com; linuxppc-dev@lists.ozlabs.org; fc...@apm.com; mmiesf...@apm.com; shiraz.has...@st.com; deepak.si...@st.com; vipulkumar.sa...@st.com; rajeev-dlh.ku...@st.com; vipin.ku...@st.com; bhupesh.sha...@st.com; viresh.ku...@st.com; amit.vi...@st.com; Pratyush Anand Subject: [PATCH 00/14] Modifications for DWC OTG since v13 These patches are based on:http://patchwork.ozlabs.org/patch/89560/ After not getting any reply from developers, I started to do modifications for my platform (SPEAr1340). I have done modifications in such a way that all the code in driver/usb/dwc/ would be platform independent. I have tested this code for host/device/dma/slave mode. My fifo configuration is dedicated and dynamic. [Tirumala Marri] We are working on our next release of patches. They should be coming out soon. Oh, thats great !! Actually, I did not get any reply of my previous mail on your patch release. I thought no one is maintaining., and so I sent them with my modifications, after testing them in all dev/host/otg mode. Regards Pratyush Hi, Can you provide the git repo to test? and I wonder what's the difference between dwc (from you) and dwc3 (from Felipe Balbi). I think it's dwc targets for usb 2.0 and dwc3 for usb 3.0. Thank you, Kyungmin Park -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
