RE: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler

2013-07-04 Thread Caraman Mihai Claudiu-B02008
 -Original Message-
 From: Wood Scott-B07421
 Sent: Wednesday, July 03, 2013 11:17 PM
 To: Caraman Mihai Claudiu-B02008
 Cc: linuxppc-dev@lists.ozlabs.org; kvm-...@vger.kernel.org;
 k...@vger.kernel.org; Caraman Mihai Claudiu-B02008
 Subject: Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception
 handler
 
 On 07/03/2013 11:56:06 AM, Mihai Caraman wrote:
  With LRAT (Logical to Real Address Translation) error exception
  handler in kernel
  KVM needs to add the counterpart otherwise will break the build.
 
  Signed-off-by: Mihai Caraman mihai.cara...@freescale.com
  ---
   arch/powerpc/kvm/bookehv_interrupts.S |2 ++
   1 files changed, 2 insertions(+), 0 deletions(-)
 
 Please combine these two patches to avoid breaking bisectability.
 
 -Scott

This is a solid reason. Ben it's ok for you to apply the combined patch?
If so I will respin it.

-Mike


___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler

2013-07-04 Thread Benjamin Herrenschmidt
On Thu, 2013-07-04 at 06:47 +, Caraman Mihai Claudiu-B02008 wrote:
 This is a solid reason. Ben it's ok for you to apply the combined
 patch? If so I will respin it.

Sure, but nowadays, all that stuff goes via Scott and Alex.

Cheers,
Ben.


___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler

2013-07-03 Thread Scott Wood

On 07/03/2013 11:56:06 AM, Mihai Caraman wrote:
With LRAT (Logical to Real Address Translation) error exception  
handler in kernel

KVM needs to add the counterpart otherwise will break the build.

Signed-off-by: Mihai Caraman mihai.cara...@freescale.com
---
 arch/powerpc/kvm/bookehv_interrupts.S |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)


Please combine these two patches to avoid breaking bisectability.

-Scott
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler

2013-07-03 Thread Alexander Graf

On 03.07.2013, at 22:16, Scott Wood wrote:

 On 07/03/2013 11:56:06 AM, Mihai Caraman wrote:
 With LRAT (Logical to Real Address Translation) error exception handler in 
 kernel
 KVM needs to add the counterpart otherwise will break the build.
 Signed-off-by: Mihai Caraman mihai.cara...@freescale.com
 ---
 arch/powerpc/kvm/bookehv_interrupts.S |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
 
 Please combine these two patches to avoid breaking bisectability.

Why does the split break bisectability?


Alex

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler

2013-07-03 Thread Scott Wood

On 07/03/2013 04:42:40 PM, Alexander Graf wrote:


On 03.07.2013, at 22:16, Scott Wood wrote:

 On 07/03/2013 11:56:06 AM, Mihai Caraman wrote:
 With LRAT (Logical to Real Address Translation) error exception  
handler in kernel

 KVM needs to add the counterpart otherwise will break the build.
 Signed-off-by: Mihai Caraman mihai.cara...@freescale.com
 ---
 arch/powerpc/kvm/bookehv_interrupts.S |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

 Please combine these two patches to avoid breaking bisectability.

Why does the split break bisectability?


Same reason as the altivec build breakage from earlier.  If we add a  
new exception type but not a KVM handler for it, the kernel won't link.


-Scott
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev