RE: [PATCH v2 1/2] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3

[David Laight]

From: David T-G
> Sent: 09 February 2022 13:42
> 
> ...and then Wols Lists said...
> %
> % On 08/02/2022 15:21, Paul Menzel wrote:
> ...
> %
> % As commented elsewhere, for the sake of us ENGLISH speakers,
> % *PLEASE* make that $(hash). A pound sign is £.
> 
> Or, even better, $(octothorpe) since that's merely a symbol rather than a
> food product or a result of an algorithm on data.  You might even hope
> that we hash this out eventually ...

I was more worried that people might think we should smoke the hash.

The # symbol called 'hash' in the UK. Can't remember why - but it is used
to mean 'number'.

'octothorpe' is some brain-damaged name and should be shot^Werased on sight.

The whole UK v US confusion about what a 'pound' sign looks like almost
certainly led to UK ascii using the £ glyph for 0x23.
I can imaging a phone call where a US person said '0x23 is the pound sign'.

I remember problems with ascii peripherals on a ebcdic mainframe where
£ $ # and \ had to get squeezed into the three available codes.
Not only was in semi-random what a line printer might print,
we had 'page mode' terminals where the input and output translation
tables didn't always match.

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, 
UK
Registration No: 1397386 (Wales)

Re: [PATCH v2 1/2] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3

[David T-G]

Paul, et al --

...and then Wols Lists said...
% 
% On 08/02/2022 15:21, Paul Menzel wrote:
...
% 
% As commented elsewhere, for the sake of us ENGLISH speakers,
% *PLEASE* make that $(hash). A pound sign is £.

Or, even better, $(octothorpe) since that's merely a symbol rather than a
food product or a result of an algorithm on data.  You might even hope
that we hash this out eventually ...


Have a great day!

:-D
-- 
David T-G
See http://justpickone.org/davidtg/email/
See http://justpickone.org/davidtg/tofu.txt

Re: [PATCH v2 1/2] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3

[Wols Lists]

On 08/02/2022 15:21, Paul Menzel wrote:

So, do the same as commit 9564a8cf422d ("Kbuild: fix # escaping in .cmd
files for future Make") and commit 929bef467771 ("bpf: Use $(pound) instead
of \# in Makefiles") and define and use a `$(pound)` variable.


As commented elsewhere, for the sake of us ENGLISH speakers, *PLEASE* 
make that $(hash). A pound sign is £.


Cheers,
Wol

Re: [PATCH v2 1/2] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3

[Song Liu]

On Tue, Feb 8, 2022 at 7:22 AM Paul Menzel  wrote:
>
> Buidling `raid6test` on Ubuntu 21.10 (ppc64le) with GNU Make 4.3 shows the
> errors below:
>
> $ cd lib/raid6/test/
> $ make
> :1:1: error: stray ‘\’ in program
> :1:2: error: stray ‘#’ in program
> :1:11: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ 
> before ‘<’ token
> cp -f ../int.uc int.uc
> awk -f ../unroll.awk -vN=1 < int.uc > int1.c
> gcc -I.. -I ../../../include -g -O2  -c -o int1.o 
> int1.c
> awk -f ../unroll.awk -vN=2 < int.uc > int2.c
> gcc -I.. -I ../../../include -g -O2  -c -o int2.o 
> int2.c
> awk -f ../unroll.awk -vN=4 < int.uc > int4.c
> gcc -I.. -I ../../../include -g -O2  -c -o int4.o 
> int4.c
> awk -f ../unroll.awk -vN=8 < int.uc > int8.c
> gcc -I.. -I ../../../include -g -O2  -c -o int8.o 
> int8.c
> awk -f ../unroll.awk -vN=16 < int.uc > int16.c
> gcc -I.. -I ../../../include -g -O2  -c -o int16.o 
> int16.c
> awk -f ../unroll.awk -vN=32 < int.uc > int32.c
> gcc -I.. -I ../../../include -g -O2  -c -o int32.o 
> int32.c
> rm -f raid6.a
> ar cq raid6.a int1.o int2.o int4.o int8.o int16.o int32.o recov.o algos.o 
> tables.o
> ranlib raid6.a
> gcc -I.. -I ../../../include -g -O2  -o raid6test 
> test.c raid6.a
> /usr/bin/ld: raid6.a(algos.o):/dev/shm/linux/lib/raid6/test/algos.c:28: 
> multiple definition of `raid6_call'; 
> /scratch/local/ccIJjN8s.o:/dev/shm/linux/lib/raid6/test/test.c:22: first 
> defined here
> collect2: error: ld returned 1 exit status
> make: *** [Makefile:72: raid6test] Error 1
>
> The errors come from the `HAS_ALTIVEC` test, which fails, and the POWER
> optimized versions are not built. That’s also reason nobody noticed on the
> other architectures.
>
> GNU Make 4.3 does not remove the backslash anymore. From the 4.3 release
> announcment:
>
> > * WARNING: Backward-incompatibility!
> >   Number signs (#) appearing inside a macro reference or function invocation
> >   no longer introduce comments and should not be escaped with backslashes:
> >   thus a call such as:
> > foo := $(shell echo '#')
> >   is legal.  Previously the number sign needed to be escaped, for example:
> > foo := $(shell echo '\#')
> >   Now this latter will resolve to "\#".  If you want to write makefiles
> >   portable to both versions, assign the number sign to a variable:
> > H := \#
> > foo := $(shell echo '$H')
> >   This was claimed to be fixed in 3.81, but wasn't, for some reason.
> >   To detect this change search for 'nocomment' in the .FEATURES variable.
>
> So, do the same as commit 9564a8cf422d ("Kbuild: fix # escaping in .cmd
> files for future Make") and commit 929bef467771 ("bpf: Use $(pound) instead
> of \# in Makefiles") and define and use a `$(pound)` variable.
>
> Reference for the change in make:
> https://git.savannah.gnu.org/cgit/make.git/commit/?id=c6966b323811c37acedff05b57
>
> Cc: Matt Brown 
> Signed-off-by: Paul Menzel 

I removed all the "`", fixed some unwrapped commit log, shortened some lines
and applied the set to md-next. Please review that version and let me know if
anything need to change.

Thanks,
Song