Re: [PATCH][RESEND] drivers/base: export (un)register_memory_notifier
On Mon, Feb 11, 2008 at 11:47:50AM +0100, Jan-Bernd Themann wrote: On Monday 11 February 2008 11:12, Dave Hansen wrote: On Mon, 2008-02-11 at 10:49 +0100, Jan-Bernd Themann wrote: are you the right person to address this patch to? You might want to check the top of the file. ;) --- a/drivers/base/memory.c +++ b/drivers/base/memory.c @@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block *nb) { return blocking_notifier_chain_register(memory_chain, nb); } +EXPORT_SYMBOL(register_memory_notifier); void unregister_memory_notifier(struct notifier_block *nb) { blocking_notifier_chain_unregister(memory_chain, nb); } +EXPORT_SYMBOL(unregister_memory_notifier); Is there a particular reason these can't be GPL? I don't object to make them GPL. Greg, what do you think? They should be _GPL to match the rest of the driver core. Care to resend this? thanks, greg k-h ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH][RESEND] drivers/base: export (un)register_memory_notifier
On Monday 11 February 2008 11:12, Dave Hansen wrote: On Mon, 2008-02-11 at 10:49 +0100, Jan-Bernd Themann wrote: are you the right person to address this patch to? You might want to check the top of the file. ;) --- a/drivers/base/memory.c +++ b/drivers/base/memory.c @@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block *nb) { return blocking_notifier_chain_register(memory_chain, nb); } +EXPORT_SYMBOL(register_memory_notifier); void unregister_memory_notifier(struct notifier_block *nb) { blocking_notifier_chain_unregister(memory_chain, nb); } +EXPORT_SYMBOL(unregister_memory_notifier); Is there a particular reason these can't be GPL? I don't object to make them GPL. Greg, what do you think? Regards, Jan-Bernd ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH][RESEND] drivers/base: export (un)register_memory_notifier
On Mon, 2008-02-11 at 10:49 +0100, Jan-Bernd Themann wrote: are you the right person to address this patch to? You might want to check the top of the file. ;) --- a/drivers/base/memory.c +++ b/drivers/base/memory.c @@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block *nb) { return blocking_notifier_chain_register(memory_chain, nb); } +EXPORT_SYMBOL(register_memory_notifier); void unregister_memory_notifier(struct notifier_block *nb) { blocking_notifier_chain_unregister(memory_chain, nb); } +EXPORT_SYMBOL(unregister_memory_notifier); Is there a particular reason these can't be GPL? -- Dave ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev