Re: [PATCH] cpufreq: powernv: Define per_cpu chip pointer to optimize hot-path

[Rafael J. Wysocki]

On Monday, March 21, 2016 12:52:55 PM Viresh Kumar wrote:
> On 18-03-16, 20:28, Shilpasri G Bhat wrote:
> > From: Michael Neuling 
> > 
> > "cpufreq: powernv: Remove cpu_to_chip_id() from hot-path" introduced
> 
> If the patch is already committed, you should provide its commit id as well.
> 
> > 'core_to_chip_map' array to cache the chip-id of all cores. Replace
> > this with per_cpu variable that stores the pointer to the chip-array.
> > This removes the linear lookup and provides a neater and simpler
> > solution.
> > 
> > Signed-off-by: Michael Neuling 
> > Tested-by: Shilpasri G Bhat 
> 
> You are sending this patch and you have updated it as well.. So, you should 
> have
> had your signed-off here.

Right.  Plus if you send a patch from anyone else, you should add your
sigh-off to it anyway, even if it hasn't been modified.

So Shilpasri, please resend with your S-o-b and with the ACK from Viresh.

Thanks,
Rafael

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] cpufreq: powernv: Define per_cpu chip pointer to optimize hot-path

[Viresh Kumar]

On 18-03-16, 20:28, Shilpasri G Bhat wrote:
> From: Michael Neuling 
> 
> "cpufreq: powernv: Remove cpu_to_chip_id() from hot-path" introduced

If the patch is already committed, you should provide its commit id as well.

> 'core_to_chip_map' array to cache the chip-id of all cores. Replace
> this with per_cpu variable that stores the pointer to the chip-array.
> This removes the linear lookup and provides a neater and simpler
> solution.
> 
> Signed-off-by: Michael Neuling 
> Tested-by: Shilpasri G Bhat 

You are sending this patch and you have updated it as well.. So, you should have
had your signed-off here.

Acked-by: Viresh Kumar 

-- 
viresh
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev