Re: [PATCH] powerpc: Do not fail build if mkimage is not available
Michael Buesch [EMAIL PROTECTED] writes: +if ! [ -x mkimage ]; then What is this supposed to test? Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc: Do not fail build if mkimage is not available
On Wednesday 26 December 2007 15:47:05 Andreas Schwab wrote: Michael Buesch [EMAIL PROTECTED] writes: +if ! [ -x mkimage ]; then What is this supposed to test? from man test: -x FILE FILE exists and execute (or search) permission is granted -- Greetings Michael. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc: Do not fail build if mkimage is not available
On Wednesday 26 December 2007 16:33:57 Andreas Schwab wrote: Michael Buesch [EMAIL PROTECTED] writes: On Wednesday 26 December 2007 15:47:05 Andreas Schwab wrote: Michael Buesch [EMAIL PROTECTED] writes: +if ! [ -x mkimage ]; then What is this supposed to test? from man test: You didn't answer my question. I'm not sure how I can make the manual text any clearer -x FILE FILE exists and execute (or search) permission is granted It tests if the program exists and is executable. Could you please be more specific about what you don't understand? That would help a lot not wasting my time. -- Greetings Michael. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc: Do not fail build if mkimage is not available
Michael Buesch [EMAIL PROTECTED] writes: On Wednesday 26 December 2007 15:47:05 Andreas Schwab wrote: Michael Buesch [EMAIL PROTECTED] writes: +if ! [ -x mkimage ]; then What is this supposed to test? from man test: You didn't answer my question. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc: Do not fail build if mkimage is not available
Michael Buesch [EMAIL PROTECTED] writes: On Wednesday 26 December 2007 16:33:57 Andreas Schwab wrote: Michael Buesch [EMAIL PROTECTED] writes: On Wednesday 26 December 2007 15:47:05 Andreas Schwab wrote: Michael Buesch [EMAIL PROTECTED] writes: +if ! [ -x mkimage ]; then What is this supposed to test? from man test: You didn't answer my question. I'm not sure how I can make the manual text any clearer I know very well what it *does*, thank you. But that does mean that is does what it is *supposed* to do. -x FILE FILE exists and execute (or search) permission is granted It tests if the program exists and is executable. ^^^ Observe the fine difference in the choice of words. That would help a lot not wasting my time. How about testing your changes first? Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc: Do not fail build if mkimage is not available
On Wednesday 26 December 2007 16:56:57 Andreas Schwab wrote: That would help a lot not wasting my time. How about testing your changes first? Stop the bullshit, please. I tested this and it obviously works very well for me. I even posted it for review on this list and nobody complained, including you. But I see what you are complaining about, now. It would also error out, if mkimage was installed (which is not the case for me. That's the whole reason for me making this patch!). Are you OK with the new version I just sent? -- Greetings Michael. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc: Do not fail build if mkimage is not available
Michael Buesch [EMAIL PROTECTED] writes: I tested this and it obviously works very well for me. Obviously your tests were incomplete. I even posted it for review on this list and nobody complained, including you. ??? I did point out an error in your patch just now. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc: Do not fail build if mkimage is not available
On Wednesday 26 December 2007 17:08:55 Andreas Schwab wrote: I even posted it for review on this list and nobody complained, including you. ??? I did point out an error in your patch just now. I posted it for review a few days ago and the only response I got was This is probably OK for now... from Josh. -- Greetings Michael. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc: Do not fail build if mkimage is not available
Michael Buesch [EMAIL PROTECTED] writes: On Wednesday 26 December 2007 17:08:55 Andreas Schwab wrote: I even posted it for review on this list and nobody complained, including you. ??? I did point out an error in your patch just now. I posted it for review a few days ago and the only response I got was This is probably OK for now... from Josh. And what does this have to do with me? I didn't see your mail at all. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
