Re: [PATCH] powerpc: fix memory leaks in QE library
On Aug 18, 2008, at 4:12 PM, Timur Tabi wrote: Fix two memory leaks in the Freescale QE library: add a missing kfree() in ucc_fast_init() if the ioremap() fails, and update ucc_fast_free() to call iounmap() on uf_regs. Based on a patch from Tony Breeds <[EMAIL PROTECTED]>. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/qe_lib/ucc_fast.c |4 1 files changed, 4 insertions(+), 0 deletions(-) applied. - k ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc: fix memory leaks in QE library
On Wed, Aug 20, 2008 at 1:38 AM, Tony Breeds <[EMAIL PROTECTED]> wrote: > It's been pointed out in > http://bugzilla.kernel.org/show_bug.cgi?id=11371 > that ucc_slow suffers from the same (welll clsoe enough) 2 problems. > Care to fix them aswell? Sure. I'll do a sweep o the QE code just to make sure there aren't even more. Of course, it would have been nice if someone had looked up the maintainer of the QE library in the MAINTAINERS file and notified me about these bugs. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc: fix memory leaks in QE library
On Mon, Aug 18, 2008 at 04:12:08PM -0500, Timur Tabi wrote: > Fix two memory leaks in the Freescale QE library: add a missing kfree() in > ucc_fast_init() if the ioremap() fails, and update ucc_fast_free() to call > iounmap() on uf_regs. It's been pointed out in http://bugzilla.kernel.org/show_bug.cgi?id=11371 that ucc_slow suffers from the same (welll clsoe enough) 2 problems. Care to fix them aswell? Yours Tony linux.conf.auhttp://www.marchsouth.org/ Jan 19 - 24 2009 The Australian Linux Technical Conference! ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
