Re: [PATCH] treewide: drop CONFIG_EMBEDDED
Hi, Le 19/08/2023 à 05:33, Jesse T a écrit : >>> Should there be a warning here to update change it instead of removal? >>> >>> kconfig doesn't have a warning mechanism AFAIK. >>> Do you have an idea of how this would work? > > No, unfortunately. As you said without a warning it would be overlooked so > a change would not be necessary. > > A possible solution is to check in a header file with: > > #ifdef CONFIG_EMBEDDED > #warning "CONFIG_EMBEDDED has changed to CONFIG_EXPERT" > #endif > > Does anyone else have an opinion on this? My opinion is that has happen several times in the past and will happen again. It is not a big deal, whoever updates to a new kernel will make a savedefconfig and compare with previous defconfig and see what has changed. Once you see that CONFIG_EMBEDDED is disappearing you look at kernel history to find out why CONFIG_EMBEDDED disappears, and you understand from the commit message that you have to select CONFIG_EXPERT instead. A couple examples I have in mind from the past: - CONFIG_FORCE_MAX_ZONEORDER became CONFIG_ARCH_FORCE_MAX_ORDER - CONFIG_MTD_NAND became CONFIG_MTD_RAW_NAND > Since kconfig doesn't have a warning mechanism the patch seems fine as is. So yes the patch is fine as is IMHO. Christophe
Re: [PATCH] treewide: drop CONFIG_EMBEDDED
On Fri, Aug 18, 2023 at 7:44 PM Randy Dunlap wrote: > > Hi Jesse, > > I replied to your comment a few days ago, but for some reason > your email to me contains: > Reply-To: 20230816055010.31534-1-rdun...@infradead.org > so it wasn't sent directly to you. Sorry about that I messed up the email headers... > > My former reply is below. > > On 8/16/23 20:15, Randy Dunlap wrote: > > Hi Jesse, > > > > On 8/16/23 15:45, Jesse Taube wrote: > >> Hi, Randy > >> > >>> diff -- a/init/Kconfig b/init/Kconfig > >>> --- a/init/Kconfig > >>> +++ b/init/Kconfig > >>> @@ -1790,14 +1790,6 @@ config DEBUG_RSEQ > >>> > >>> If unsure, say N. > >>> > >>> -config EMBEDDED > >>> -bool "Embedded system" > >>> -select EXPERT > >>> -help > >>> - This option should be enabled if compiling the kernel for > >>> - an embedded system so certain expert options are available > >>> - for configuration. > >> > >> Wouldn't removing this break many out of tree configs? > > > > I'm not familiar with out-of-tree configs. > > Do you have some examples of some that use CONFIG_EMBEDDED? > > (not distros) Buildroot has a few. It won't immediately break Buildroot and Yocto as they have a set version, but it could be confusing for anyone updating the kernel. > > > >> Should there be a warning here to update change it instead of removal? > > > > kconfig doesn't have a warning mechanism AFAIK. > > Do you have an idea of how this would work? No, unfortunately. As you said without a warning it would be overlooked so a change would not be necessary. A possible solution is to check in a header file with: #ifdef CONFIG_EMBEDDED #warning "CONFIG_EMBEDDED has changed to CONFIG_EXPERT" #endif Does anyone else have an opinion on this? Since kconfig doesn't have a warning mechanism the patch seems fine as is. Thanks, Jesse Taube > > > > We could make a smaller change to init/Kconfig, like so: > > > > config EMBEDDED > > - bool "Embedded system" > > + bool "Embedded system (DEPRECATED)" > > select EXPERT > > help > > - This option should be enabled if compiling the kernel for > > - an embedded system so certain expert options are available > > - for configuration. > > + This option is being removed after Linux 6.6. > > + Use EXPERT instead of EMBEDDED. > > > > but there is no way to produce a warning message. I.e., even with this > > change, the message will probably be overlooked. > > > > --- > > ~Randy > > -- > ~Randy
Re: [PATCH] treewide: drop CONFIG_EMBEDDED
Hi Jesse, I replied to your comment a few days ago, but for some reason your email to me contains: Reply-To: 20230816055010.31534-1-rdun...@infradead.org so it wasn't sent directly to you. My former reply is below. On 8/16/23 20:15, Randy Dunlap wrote: > Hi Jesse, > > On 8/16/23 15:45, Jesse Taube wrote: >> Hi, Randy >> >>> diff -- a/init/Kconfig b/init/Kconfig >>> --- a/init/Kconfig >>> +++ b/init/Kconfig >>> @@ -1790,14 +1790,6 @@ config DEBUG_RSEQ >>> >>> If unsure, say N. >>> >>> -config EMBEDDED >>> - bool "Embedded system" >>> - select EXPERT >>> - help >>> - This option should be enabled if compiling the kernel for >>> - an embedded system so certain expert options are available >>> - for configuration. >> >> Wouldn't removing this break many out of tree configs? > > I'm not familiar with out-of-tree configs. > Do you have some examples of some that use CONFIG_EMBEDDED? > (not distros) > >> Should there be a warning here to update change it instead of removal? > > kconfig doesn't have a warning mechanism AFAIK. > Do you have an idea of how this would work? > > We could make a smaller change to init/Kconfig, like so: > > config EMBEDDED > - bool "Embedded system" > + bool "Embedded system (DEPRECATED)" > select EXPERT > help > - This option should be enabled if compiling the kernel for > - an embedded system so certain expert options are available > - for configuration. > + This option is being removed after Linux 6.6. > + Use EXPERT instead of EMBEDDED. > > but there is no way to produce a warning message. I.e., even with this > change, the message will probably be overlooked. > > --- > ~Randy -- ~Randy
Re: [PATCH] treewide: drop CONFIG_EMBEDDED
Randy Dunlap writes: > There is only one Kconfig user of CONFIG_EMBEDDED and it can be > switched to EXPERT or "if !ARCH_MULTIPLATFORM" (suggested by Arnd). > > Signed-off-by: Randy Dunlap ... > arch/powerpc/configs/40x/klondike_defconfig |2 +- > arch/powerpc/configs/44x/fsp2_defconfig |2 +- > arch/powerpc/configs/52xx/tqm5200_defconfig |2 +- > arch/powerpc/configs/mgcoge_defconfig|2 +- > arch/powerpc/configs/microwatt_defconfig |2 +- > arch/powerpc/configs/ps3_defconfig |2 +- Acked-by: Michael Ellerman (powerpc) ... > diff -- a/init/Kconfig b/init/Kconfig > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -1790,14 +1790,6 @@ config DEBUG_RSEQ > > If unsure, say N. > > -config EMBEDDED > - bool "Embedded system" > - select EXPERT This is a crucial detail that could be mentioned in the change log. ie. that all defconfigs that currently have EMBEDDED=y are currently selecting EXPERT already. cheers
Re: [PATCH] treewide: drop CONFIG_EMBEDDED
Hi Jesse, On 8/16/23 15:45, Jesse Taube wrote: > Hi, Randy > >> diff -- a/init/Kconfig b/init/Kconfig >> --- a/init/Kconfig >> +++ b/init/Kconfig >> @@ -1790,14 +1790,6 @@ config DEBUG_RSEQ >> >> If unsure, say N. >> >> -config EMBEDDED >> - bool "Embedded system" >> - select EXPERT >> - help >> - This option should be enabled if compiling the kernel for >> - an embedded system so certain expert options are available >> - for configuration. > > Wouldn't removing this break many out of tree configs? I'm not familiar with out-of-tree configs. Do you have some examples of some that use CONFIG_EMBEDDED? (not distros) > Should there be a warning here to update change it instead of removal? kconfig doesn't have a warning mechanism AFAIK. Do you have an idea of how this would work? We could make a smaller change to init/Kconfig, like so: config EMBEDDED - bool "Embedded system" + bool "Embedded system (DEPRECATED)" select EXPERT help - This option should be enabled if compiling the kernel for - an embedded system so certain expert options are available - for configuration. + This option is being removed after Linux 6.6. + Use EXPERT instead of EMBEDDED. but there is no way to produce a warning message. I.e., even with this change, the message will probably be overlooked. --- ~Randy
Re: [PATCH] treewide: drop CONFIG_EMBEDDED
Hi, Randy > diff -- a/init/Kconfig b/init/Kconfig > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -1790,14 +1790,6 @@ config DEBUG_RSEQ > > If unsure, say N. > > -config EMBEDDED > - bool "Embedded system" > - select EXPERT > - help > -This option should be enabled if compiling the kernel for > -an embedded system so certain expert options are available > -for configuration. Wouldn't removing this break many out of tree configs? Should there be a warning here to update change it instead of removal? Thanks, Jesse Taube
Re: [PATCH] treewide: drop CONFIG_EMBEDDED
On Wed, Aug 16, 2023 at 7:50 AM Randy Dunlap wrote: > > There is only one Kconfig user of CONFIG_EMBEDDED and it can be > switched to EXPERT or "if !ARCH_MULTIPLATFORM" (suggested by Arnd). > > Signed-off-by: Randy Dunlap > Cc: Russell King > Cc: linux-arm-ker...@lists.infradead.org > Cc: Arnd Bergmann > Cc: Jason A. Donenfeld > Cc: wiregu...@lists.zx2c4.com > Cc: linux-a...@vger.kernel.org > Cc: linux-snps-...@lists.infradead.org > Cc: Vineet Gupta > Cc: Brian Cain > Cc: linux-hexa...@vger.kernel.org > Cc: Greg Ungerer > Cc: Geert Uytterhoeven > Cc: linux-m...@lists.linux-m68k.org > Cc: Michal Simek > Cc: Thomas Bogendoerfer > Cc: Dinh Nguyen > Cc: Jonas Bonn > Cc: Stefan Kristiansson > Cc: Stafford Horne > Cc: linux-openr...@vger.kernel.org > Cc: linux-m...@vger.kernel.org > Cc: Michael Ellerman > Cc: Nicholas Piggin > Cc: Christophe Leroy > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-ri...@lists.infradead.org > Cc: Paul Walmsley > Cc: Palmer Dabbelt > Cc: Albert Ou > Cc: Yoshinori Sato > Cc: Rich Felker > Cc: John Paul Adrian Glaubitz > Cc: linux...@vger.kernel.org > Cc: Max Filippov > Cc: Josh Triplett > Cc: Masahiro Yamada > Cc: linux-kbu...@vger.kernel.org > Cc: Andrew Morton > --- > diff -- a/tools/testing/selftests/wireguard/qemu/kernel.config > b/tools/testing/selftests/wireguard/qemu/kernel.config > --- a/tools/testing/selftests/wireguard/qemu/kernel.config > +++ b/tools/testing/selftests/wireguard/qemu/kernel.config > @@ -41,7 +41,6 @@ CONFIG_KALLSYMS=y > CONFIG_BUG=y > CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE=y > CONFIG_JUMP_LABEL=y > -CONFIG_EMBEDDED=n > CONFIG_BASE_FULL=y > CONFIG_FUTEX=y > CONFIG_SHMEM=y Acked-by: Jason A. Donenfeld
Re: [PATCH] treewide: drop CONFIG_EMBEDDED
On 16/8/23 15:50, Randy Dunlap wrote: There is only one Kconfig user of CONFIG_EMBEDDED and it can be switched to EXPERT or "if !ARCH_MULTIPLATFORM" (suggested by Arnd). Signed-off-by: Randy Dunlap Cc: Russell King Cc: linux-arm-ker...@lists.infradead.org Cc: Arnd Bergmann Cc: Jason A. Donenfeld Cc: wiregu...@lists.zx2c4.com Cc: linux-a...@vger.kernel.org Cc: linux-snps-...@lists.infradead.org Cc: Vineet Gupta Cc: Brian Cain Cc: linux-hexa...@vger.kernel.org Cc: Greg Ungerer Acked-by: Greg Ungerer Cc: Geert Uytterhoeven Cc: linux-m...@lists.linux-m68k.org Cc: Michal Simek Cc: Thomas Bogendoerfer Cc: Dinh Nguyen Cc: Jonas Bonn Cc: Stefan Kristiansson Cc: Stafford Horne Cc: linux-openr...@vger.kernel.org Cc: linux-m...@vger.kernel.org Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-ri...@lists.infradead.org Cc: Paul Walmsley Cc: Palmer Dabbelt Cc: Albert Ou Cc: Yoshinori Sato Cc: Rich Felker Cc: John Paul Adrian Glaubitz Cc: linux...@vger.kernel.org Cc: Max Filippov Cc: Josh Triplett Cc: Masahiro Yamada Cc: linux-kbu...@vger.kernel.org Cc: Andrew Morton --- arch/arc/configs/axs101_defconfig|2 +- arch/arc/configs/axs103_defconfig|2 +- arch/arc/configs/axs103_smp_defconfig|2 +- arch/arc/configs/haps_hs_smp_defconfig |2 +- arch/arc/configs/hsdk_defconfig |2 +- arch/arc/configs/nsim_700_defconfig |2 +- arch/arc/configs/nsimosci_defconfig |2 +- arch/arc/configs/nsimosci_hs_defconfig |2 +- arch/arc/configs/tb10x_defconfig |2 +- arch/arc/configs/vdk_hs38_defconfig |2 +- arch/arc/configs/vdk_hs38_smp_defconfig |2 +- arch/arm/Kconfig |2 +- arch/arm/configs/aspeed_g4_defconfig |2 +- arch/arm/configs/aspeed_g5_defconfig |2 +- arch/arm/configs/at91_dt_defconfig |2 +- arch/arm/configs/axm55xx_defconfig |2 +- arch/arm/configs/bcm2835_defconfig |2 +- arch/arm/configs/clps711x_defconfig |2 +- arch/arm/configs/keystone_defconfig |2 +- arch/arm/configs/lpc18xx_defconfig |2 +- arch/arm/configs/lpc32xx_defconfig |2 +- arch/arm/configs/milbeaut_m10v_defconfig |2 +- arch/arm/configs/moxart_defconfig|2 +- arch/arm/configs/multi_v4t_defconfig |2 +- arch/arm/configs/multi_v7_defconfig |2 +- arch/arm/configs/pxa_defconfig |2 +- arch/arm/configs/qcom_defconfig |2 +- arch/arm/configs/sama5_defconfig |2 +- arch/arm/configs/sama7_defconfig |2 +- arch/arm/configs/socfpga_defconfig |2 +- arch/arm/configs/stm32_defconfig |2 +- arch/arm/configs/tegra_defconfig |2 +- arch/arm/configs/vf610m4_defconfig |2 +- arch/hexagon/configs/comet_defconfig |2 +- arch/m68k/configs/amcore_defconfig |2 +- arch/m68k/configs/m5475evb_defconfig |2 +- arch/m68k/configs/stmark2_defconfig |2 +- arch/microblaze/configs/mmu_defconfig|2 +- arch/mips/configs/ath25_defconfig|2 +- arch/mips/configs/ath79_defconfig|2 +- arch/mips/configs/bcm47xx_defconfig |2 +- arch/mips/configs/ci20_defconfig |2 +- arch/mips/configs/cu1000-neo_defconfig |2 +- arch/mips/configs/cu1830-neo_defconfig |2 +- arch/mips/configs/db1xxx_defconfig |2 +- arch/mips/configs/gcw0_defconfig |2 +- arch/mips/configs/generic_defconfig |2 +- arch/mips/configs/loongson2k_defconfig |2 +- arch/mips/configs/loongson3_defconfig|2 +- arch/mips/configs/malta_qemu_32r6_defconfig |2 +- arch/mips/configs/maltaaprp_defconfig|2 +- arch/mips/configs/maltasmvp_defconfig|2 +- arch/mips/configs/maltasmvp_eva_defconfig|2 +- arch/mips/configs/maltaup_defconfig |2 +- arch/mips/configs/omega2p_defconfig |2 +- arch/mips/configs/pic32mzda_defconfig|2 +- arch/mips/configs/qi_lb60_defconfig |2 +- arch/mips/configs/rs90_defconfig |2 +- arch/mips/configs/rt305x_defconfig |
Re: [PATCH] treewide: drop CONFIG_EMBEDDED
On Tue, 15 Aug 2023 22:50:10 PDT (-0700), rdun...@infradead.org wrote: There is only one Kconfig user of CONFIG_EMBEDDED and it can be switched to EXPERT or "if !ARCH_MULTIPLATFORM" (suggested by Arnd). Signed-off-by: Randy Dunlap Cc: Russell King Cc: linux-arm-ker...@lists.infradead.org Cc: Arnd Bergmann Cc: Jason A. Donenfeld Cc: wiregu...@lists.zx2c4.com Cc: linux-a...@vger.kernel.org Cc: linux-snps-...@lists.infradead.org Cc: Vineet Gupta Cc: Brian Cain Cc: linux-hexa...@vger.kernel.org Cc: Greg Ungerer Cc: Geert Uytterhoeven Cc: linux-m...@lists.linux-m68k.org Cc: Michal Simek Cc: Thomas Bogendoerfer Cc: Dinh Nguyen Cc: Jonas Bonn Cc: Stefan Kristiansson Cc: Stafford Horne Cc: linux-openr...@vger.kernel.org Cc: linux-m...@vger.kernel.org Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-ri...@lists.infradead.org Cc: Paul Walmsley Cc: Palmer Dabbelt Cc: Albert Ou Cc: Yoshinori Sato Cc: Rich Felker Cc: John Paul Adrian Glaubitz Cc: linux...@vger.kernel.org Cc: Max Filippov Cc: Josh Triplett Cc: Masahiro Yamada Cc: linux-kbu...@vger.kernel.org Cc: Andrew Morton --- arch/arc/configs/axs101_defconfig|2 +- arch/arc/configs/axs103_defconfig|2 +- arch/arc/configs/axs103_smp_defconfig|2 +- arch/arc/configs/haps_hs_smp_defconfig |2 +- arch/arc/configs/hsdk_defconfig |2 +- arch/arc/configs/nsim_700_defconfig |2 +- arch/arc/configs/nsimosci_defconfig |2 +- arch/arc/configs/nsimosci_hs_defconfig |2 +- arch/arc/configs/tb10x_defconfig |2 +- arch/arc/configs/vdk_hs38_defconfig |2 +- arch/arc/configs/vdk_hs38_smp_defconfig |2 +- arch/arm/Kconfig |2 +- arch/arm/configs/aspeed_g4_defconfig |2 +- arch/arm/configs/aspeed_g5_defconfig |2 +- arch/arm/configs/at91_dt_defconfig |2 +- arch/arm/configs/axm55xx_defconfig |2 +- arch/arm/configs/bcm2835_defconfig |2 +- arch/arm/configs/clps711x_defconfig |2 +- arch/arm/configs/keystone_defconfig |2 +- arch/arm/configs/lpc18xx_defconfig |2 +- arch/arm/configs/lpc32xx_defconfig |2 +- arch/arm/configs/milbeaut_m10v_defconfig |2 +- arch/arm/configs/moxart_defconfig|2 +- arch/arm/configs/multi_v4t_defconfig |2 +- arch/arm/configs/multi_v7_defconfig |2 +- arch/arm/configs/pxa_defconfig |2 +- arch/arm/configs/qcom_defconfig |2 +- arch/arm/configs/sama5_defconfig |2 +- arch/arm/configs/sama7_defconfig |2 +- arch/arm/configs/socfpga_defconfig |2 +- arch/arm/configs/stm32_defconfig |2 +- arch/arm/configs/tegra_defconfig |2 +- arch/arm/configs/vf610m4_defconfig |2 +- arch/hexagon/configs/comet_defconfig |2 +- arch/m68k/configs/amcore_defconfig |2 +- arch/m68k/configs/m5475evb_defconfig |2 +- arch/m68k/configs/stmark2_defconfig |2 +- arch/microblaze/configs/mmu_defconfig|2 +- arch/mips/configs/ath25_defconfig|2 +- arch/mips/configs/ath79_defconfig|2 +- arch/mips/configs/bcm47xx_defconfig |2 +- arch/mips/configs/ci20_defconfig |2 +- arch/mips/configs/cu1000-neo_defconfig |2 +- arch/mips/configs/cu1830-neo_defconfig |2 +- arch/mips/configs/db1xxx_defconfig |2 +- arch/mips/configs/gcw0_defconfig |2 +- arch/mips/configs/generic_defconfig |2 +- arch/mips/configs/loongson2k_defconfig |2 +- arch/mips/configs/loongson3_defconfig|2 +- arch/mips/configs/malta_qemu_32r6_defconfig |2 +- arch/mips/configs/maltaaprp_defconfig|2 +- arch/mips/configs/maltasmvp_defconfig|2 +- arch/mips/configs/maltasmvp_eva_defconfig|2 +- arch/mips/configs/maltaup_defconfig |2 +- arch/mips/configs/omega2p_defconfig |2 +- arch/mips/configs/pic32mzda_defconfig|2 +- arch/mips/configs/qi_lb60_defconfig |2 +- arch/mips/configs/rs90_defconfig |2 +- arch/mips/configs/rt305x_defconfig |2 +- arch/mips/configs/vocore2_defconfig
Re: [PATCH] treewide: drop CONFIG_EMBEDDED
On Wed, Aug 16, 2023, at 07:50, Randy Dunlap wrote: > There is only one Kconfig user of CONFIG_EMBEDDED and it can be > switched to EXPERT or "if !ARCH_MULTIPLATFORM" (suggested by Arnd). > > Signed-off-by: Randy Dunlap > Cc: Russell King > Cc: linux-arm-ker...@lists.infradead.org > Cc: Arnd Bergmann > Cc: Jason A. Donenfeld Acked-by: Arnd Bergmann
Re: [PATCH] treewide: drop CONFIG_EMBEDDED
Hi Randy,
On Wed, Aug 16, 2023 at 7:50 AM Randy Dunlap wrote:
> There is only one Kconfig user of CONFIG_EMBEDDED and it can be
> switched to EXPERT or "if !ARCH_MULTIPLATFORM" (suggested by Arnd).
>
> Signed-off-by: Randy Dunlap
Makes perfect sense to me.
Acked-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
