Re: [PATCH 00/10 v6] Fix 8xx MMU/TLB
Scott Wood scottw...@freescale.com wrote on 30/11/2009 23:25:30: Benjamin Herrenschmidt wrote: On Fri, 2009-11-27 at 11:57 +0100, Joakim Tjernlund wrote: Scott and Rex, I think we need you s-o-b to make it into the kernel proper. Marcelo and Vitaly, I noticed you guys are listed as 8xx maintainers. Have you seen this? What do you think? I think Marcelo isn't much involved with 8xx anymore. I'd say if Scott and Vitaly are ok, then the patches are good. But I'll wait for at least Scott to give an Ack as he can at least test which I can't :-) ACK Can't see these patches in next yet, did they go somewhere else? ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 00/10 v6] Fix 8xx MMU/TLB
On Tue, 2009-12-08 at 09:38 +0100, Joakim Tjernlund wrote: Scott Wood scottw...@freescale.com wrote on 30/11/2009 23:25:30: Benjamin Herrenschmidt wrote: On Fri, 2009-11-27 at 11:57 +0100, Joakim Tjernlund wrote: Scott and Rex, I think we need you s-o-b to make it into the kernel proper. Marcelo and Vitaly, I noticed you guys are listed as 8xx maintainers. Have you seen this? What do you think? I think Marcelo isn't much involved with 8xx anymore. I'd say if Scott and Vitaly are ok, then the patches are good. But I'll wait for at least Scott to give an Ack as he can at least test which I can't :-) ACK Can't see these patches in next yet, did they go somewhere else? No, but Scott has been to lazy to write proper Acked-by: lines and I've been too lazy to do it for him so they'll go in the next batch, probably today :-) Cheers, Ben. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 00/10 v6] Fix 8xx MMU/TLB
Benjamin Herrenschmidt wrote: On Fri, 2009-11-27 at 11:57 +0100, Joakim Tjernlund wrote: Scott and Rex, I think we need you s-o-b to make it into the kernel proper. Marcelo and Vitaly, I noticed you guys are listed as 8xx maintainers. Have you seen this? What do you think? I think Marcelo isn't much involved with 8xx anymore. I'd say if Scott and Vitaly are ok, then the patches are good. But I'll wait for at least Scott to give an Ack as he can at least test which I can't :-) ACK -Scott ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 00/10 v6] Fix 8xx MMU/TLB
Scott Wood scottw...@freescale.com wrote on 30/11/2009 23:25:30: Benjamin Herrenschmidt wrote: On Fri, 2009-11-27 at 11:57 +0100, Joakim Tjernlund wrote: Scott and Rex, I think we need you s-o-b to make it into the kernel proper. Marcelo and Vitaly, I noticed you guys are listed as 8xx maintainers. Have you seen this? What do you think? I think Marcelo isn't much involved with 8xx anymore. I'd say if Scott and Vitaly are ok, then the patches are good. But I'll wait for at least Scott to give an Ack as he can at least test which I can't :-) ACK Yippie, lets see if I can work up the energy to do the same for 2.4 once this is in 2.6 :) ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 00/10 v6] Fix 8xx MMU/TLB
Scott and Rex, I think we need you s-o-b to make it into the kernel proper. Marcelo and Vitaly, I noticed you guys are listed as 8xx maintainers. Have you seen this? What do you think? Jocke Joakim Tjernlund joakim.tjernl...@transmode.se wrote on 20/11/2009 11:21:01: Yet again an iteration of the series. Rex Scott, please test and signoff. Changes since last version: - Fix rlwimi insn(from Scott) Joakim Tjernlund (10): 8xx: invalidate non present TLBs 8xx: Update TLB asm so it behaves as linux mm expects. 8xx: Tag DAR with 0x00f0 to catch buggy instructions. 8xx: Always pin kernel instruction TLB 8xx: Fixup DAR from buggy dcbX instructions. 8xx: Add missing Guarded setting in DTLB Error. 8xx: Restore _PAGE_WRITETHRU 8xx: start using dcbX instructions in various copy routines 8xx: Remove DIRTY pte handling in DTLB Error. 8xx: DTLB Miss cleanup arch/powerpc/include/asm/pte-8xx.h | 14 +- arch/powerpc/kernel/head_8xx.S | 315 ++-- arch/powerpc/kernel/misc_32.S | 18 -- arch/powerpc/lib/copy_32.S | 24 --- arch/powerpc/mm/fault.c|8 +- 5 files changed, 211 insertions(+), 168 deletions(-) ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 00/10 v6] Fix 8xx MMU/TLB
On Fri, 2009-11-27 at 11:57 +0100, Joakim Tjernlund wrote: Scott and Rex, I think we need you s-o-b to make it into the kernel proper. Marcelo and Vitaly, I noticed you guys are listed as 8xx maintainers. Have you seen this? What do you think? I think Marcelo isn't much involved with 8xx anymore. I'd say if Scott and Vitaly are ok, then the patches are good. But I'll wait for at least Scott to give an Ack as he can at least test which I can't :-) Cheers, Ben. Jocke Joakim Tjernlund joakim.tjernl...@transmode.se wrote on 20/11/2009 11:21:01: Yet again an iteration of the series. Rex Scott, please test and signoff. Changes since last version: - Fix rlwimi insn(from Scott) Joakim Tjernlund (10): 8xx: invalidate non present TLBs 8xx: Update TLB asm so it behaves as linux mm expects. 8xx: Tag DAR with 0x00f0 to catch buggy instructions. 8xx: Always pin kernel instruction TLB 8xx: Fixup DAR from buggy dcbX instructions. 8xx: Add missing Guarded setting in DTLB Error. 8xx: Restore _PAGE_WRITETHRU 8xx: start using dcbX instructions in various copy routines 8xx: Remove DIRTY pte handling in DTLB Error. 8xx: DTLB Miss cleanup arch/powerpc/include/asm/pte-8xx.h | 14 +- arch/powerpc/kernel/head_8xx.S | 315 ++-- arch/powerpc/kernel/misc_32.S | 18 -- arch/powerpc/lib/copy_32.S | 24 --- arch/powerpc/mm/fault.c|8 +- 5 files changed, 211 insertions(+), 168 deletions(-) ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 00/10 v6] Fix 8xx MMU/TLB
Thus spake Joakim Tjernlund (joakim.tjernl...@transmode.se): Yet again an iteration of the series. Rex Scott, please test and signoff. Changes since last version: - Fix rlwimi insn(from Scott) Hi Joakim, Things look much better with this patch set, I see none of the random crashes that I had with the earlier patches. I'll leave it running on a few boards here over the weekend and see if anything bad happens. Since patch #1 fixes a regression in the current kernel is there any way you can get that into .32? I know it is late, but without that patch .32 doesn't work for 8xx boards. On another note, how does your patch set affect performance? Have you been able to do any testing? What is the advantage of using dcbX in the kernel, besides keeping the code similar to other ppc platforms? Maybe it is good to catch/fixup userspace uses of dcbX, but why change the kernel? How does it affect performance? thanks! /rex. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
