Re: [PATCH 1/1] ibmvscsi: Non SCSI error status fixup

2008-05-20 Thread Brian King
Michael Ellerman wrote:
 On Mon, 2008-05-19 at 10:56 -0500, Dave Boutcher wrote:
 On Mon, 19 May 2008 10:27:56 -0500, Brian King [EMAIL PROTECTED] said:
 Some versions of the Virtual I/O Server on Power
 return 0x99 in the non-SCSI error status field as success,
 rather than 0. This fixes the ibmvscsi driver to treat this
 response as success.
 Yeah0x99...that's an intuitive value for success.
 
 Hopefully there are no versions that return 0x99 for an error? :)

There shouldn't be. 0x99 is actually not defined as a valid value for
that field, but it is what the ibmvscsis VIOS that is included in
SLES 9 and SLES 10 return on success, due to a bug in that driver.
We plan to fix the ibmvscsis driver as well, but it will take a while
for that fix to propagate. Until very recently, the status field was not
checked, which is why we are only recently running into this problem.

-Brian

-- 
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [PATCH 1/1] ibmvscsi: Non SCSI error status fixup

2008-05-19 Thread Michael Ellerman
On Mon, 2008-05-19 at 10:56 -0500, Dave Boutcher wrote:
 On Mon, 19 May 2008 10:27:56 -0500, Brian King [EMAIL PROTECTED] said:
  
  Some versions of the Virtual I/O Server on Power
  return 0x99 in the non-SCSI error status field as success,
  rather than 0. This fixes the ibmvscsi driver to treat this
  response as success.
 
 Yeah0x99...that's an intuitive value for success.

Hopefully there are no versions that return 0x99 for an error? :)

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person


signature.asc
Description: This is a digitally signed message part
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev