Re: [PATCH 1/3] powerpc: Make NUMA depend on SMP
On Tue, 24 Nov 2020 23:05:45 +1100, Michael Ellerman wrote: > Our Kconfig allows NUMA to be enabled without SMP, but none of > our defconfigs use that combination. This means it can easily be > broken inadvertently by code changes, which has happened recently. > > Although it's theoretically possible to have a machine with a single > CPU and multiple memory nodes, I can't think of any real systems where > that's the case. Even so if such a system exists, it can just run an > SMP kernel anyway. > > [...] Applied to powerpc/next. [1/3] powerpc: Make NUMA depend on SMP https://git.kernel.org/powerpc/c/25395cd2f8cb24ce6a5ce073c898acfb091e06cf [2/3] powerpc: Make NUMA default y for powernv https://git.kernel.org/powerpc/c/4c28b32b886f1489c5f510ed8e3f0c4e3dcb59f5 [3/3] powerpc: Update NUMA Kconfig description & help text https://git.kernel.org/powerpc/c/bae80c27fc2195b9e5723d7b05c592e0874f4ba9 cheers
Re: [PATCH 1/3] powerpc: Make NUMA depend on SMP
* Michael Ellerman [2020-11-24 23:05:45]: > Our Kconfig allows NUMA to be enabled without SMP, but none of > our defconfigs use that combination. This means it can easily be > broken inadvertently by code changes, which has happened recently. > > Although it's theoretically possible to have a machine with a single > CPU and multiple memory nodes, I can't think of any real systems where > that's the case. Even so if such a system exists, it can just run an > SMP kernel anyway. > > So to avoid the need to add extra #ifdefs and/or build breaks, make > NUMA depend on SMP. > > Reported-by: kernel test robot > Reported-by: Randy Dunlap > Signed-off-by: Michael Ellerman Looks good to me. Reviewed-by: Srikar Dronamraju > --- > arch/powerpc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index e9f13fe08492..a22db3db6b96 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -660,7 +660,7 @@ config IRQ_ALL_CPUS > > config NUMA > bool "NUMA support" > - depends on PPC64 > + depends on PPC64 && SMP > default y if SMP && PPC_PSERIES > > config NODES_SHIFT > -- > 2.25.1 > -- Thanks and Regards Srikar Dronamraju
Re: [PATCH 1/3] powerpc: Make NUMA depend on SMP
On 11/24/20 4:05 AM, Michael Ellerman wrote: > Our Kconfig allows NUMA to be enabled without SMP, but none of > our defconfigs use that combination. This means it can easily be > broken inadvertently by code changes, which has happened recently. > > Although it's theoretically possible to have a machine with a single > CPU and multiple memory nodes, I can't think of any real systems where > that's the case. Even so if such a system exists, it can just run an > SMP kernel anyway. > > So to avoid the need to add extra #ifdefs and/or build breaks, make > NUMA depend on SMP. > > Reported-by: kernel test robot > Reported-by: Randy Dunlap > Signed-off-by: Michael Ellerman Reviewed-by: Randy Dunlap Thanks. > --- > arch/powerpc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index e9f13fe08492..a22db3db6b96 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -660,7 +660,7 @@ config IRQ_ALL_CPUS > > config NUMA > bool "NUMA support" > - depends on PPC64 > + depends on PPC64 && SMP > default y if SMP && PPC_PSERIES > > config NODES_SHIFT > -- ~Randy
