Re: [PATCH 1/5] PowerPC: Move of_device allocation into of_device.[ch]

2007-09-27 Thread Arnd Bergmann
On Wednesday 26 September 2007, Joachim Fenkes wrote:
 Extract generic of_device allocation code from of_platform_device_create()
 and move it into of_device.[ch], called of_device_alloc(). Also, there's now
 of_device_free() which puts the device node.
 
 This way, bus drivers that build on of_platform (like ibmebus will) can
 build upon this code instead of reinventing the wheel.
 
 Signed-off-by: Joachim Fenkes [EMAIL PROTECTED]

Acked-by: Arnd Bergmann [EMAIL PROTECTED]
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [PATCH 1/5] PowerPC: Move of_device allocation into of_device.[ch]

2007-09-26 Thread Joachim Fenkes
Arnd Bergmann [EMAIL PROTECTED] wrote on 25.09.2007 16:27:57:

 The patch looks good to me, especially since you did exactly what I
 suggested ;-)

Yes, our discussions were very productive. Thanks and sorry I forgot to 
mention your input.
 
 Maybe the description should have another sentence in it about what
 the change is good for. You have that in the 0/5 mail, but that does
 not go into the changelog, so the information gets lost in the process.

Can do. New patch coming right up!

Joachim
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [PATCH 1/5] PowerPC: Move of_device allocation into of_device.[ch]

2007-09-25 Thread Arnd Bergmann
On Tuesday 25 September 2007, Joachim Fenkes wrote:
 Extract generic of_device allocation code from of_platform_device_create()
 and move it into of_device.[ch], called of_device_alloc(). Also, there's now
 of_device_free() which puts the device node.
 
 Signed-off-by: Joachim Fenkes [EMAIL PROTECTED]
 ---
  include/asm-powerpc/of_device.h   |    4 ++
  include/linux/of_device.h         |    5 ++
  arch/powerpc/kernel/of_device.c   |   80 
 +
  arch/powerpc/kernel/of_platform.c |   70 +---
  4 files changed, 91 insertions(+), 68 deletions(-)
 

Sorry I didn't review the patches earlier when you sent them in private.
The patch looks good to me, especially since you did exactly what I
suggested ;-)

Maybe the description should have another sentence in it about what
the change is good for. You have that in the 0/5 mail, but that does
not go into the changelog, so the information gets lost in the process.

Arnd 
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev