Re: [PATCH 4/3] Make swsusp_32.S usable for suspend-to-RAM.
Johannes Berg wrote: +config PPC32_SUSPEND +config PPC32_SWSUSP -obj32-$(CONFIG_HIBERNATION) += swsusp_32.o +obj32-$(CONFIG_PPC32_SUSPEND) += swsusp_32.o I think that's overkill, couldn't it just use CONFIG_PM_SLEEP here? This file is specific to 32-bit classic PPC chips. It doesn't matter, though, as I've redone the 83xx suspend to not need that file. -Scott ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 4/3] Make swsusp_32.S usable for suspend-to-RAM.
+config PPC32_SUSPEND +config PPC32_SWSUSP -obj32-$(CONFIG_HIBERNATION) += swsusp_32.o +obj32-$(CONFIG_PPC32_SUSPEND)+= swsusp_32.o I think that's overkill, couldn't it just use CONFIG_PM_SLEEP here? I'm not sure that was available at the time you posted this patchset though, so that may well be the reason you didn't use it. For reference, kernel/power/Kconfig has: config PM_SLEEP bool depends on SUSPEND || HIBERNATION default y johannes signature.asc Description: This is a digitally signed message part ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
