Re: [PATCH 4/6] powerpc: add USB peripheral support to MPC8272ADS

2008-08-07 Thread Scott Wood 
On Thu, Aug 07, 2008 at 11:50:14AM +0800, Li Yang wrote:
 udc is a common name for USB device mode drivers to work with Linux
 gadget.  We will have two separate drivers for USB host and device.
 Probably we can have two compatibles fsl,qe_udc and fsl,qe-usb-host

1. If you have separate compatibles, what do you need the mode property
for?
2. mpc8272 is not QE.
3. fsl,cpm2-usb-slave would be much more readable than fsl,qe_udc.

-Scott
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 4/6] powerpc: add USB peripheral support to MPC8272ADS

2008-08-06 Thread Stephen Rothwell 
Hi Li,

On Wed,  6 Aug 2008 15:04:43 +0800 Li Yang [EMAIL PROTECTED] wrote:

 @@ -150,6 +169,12 @@ static void __init mpc8272_ads_setup_arch(void)
   clrbits32(bcsr[3], BCSR3_FETHIEN2);
   setbits32(bcsr[3], BCSR3_FETH2_RST);
  
 + /* Enabling USB support in BCSR */
 + np = of_find_compatible_node(NULL, NULL, fsl,qe_udc);
 + if (np != NULL) {

of_node_put(np);

 + clrbits32(bcsr[3], BCSR3_USB_EN);
 + clrbits32(bcsr[3], BCSR3_USB_HI_SPEED);
 + }
-- 
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/


pgp8ccU0tfaOE.pgp
Description: PGP signature
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 4/6] powerpc: add USB peripheral support to MPC8272ADS

2008-08-06 Thread Scott Wood 
On Wed, Aug 06, 2008 at 03:04:43PM +0800, Li Yang wrote:
 Signed-off-by: Li Yang [EMAIL PROTECTED]
 ---
  arch/powerpc/boot/dts/mpc8272ads.dts  |8 
  arch/powerpc/platforms/82xx/mpc8272_ads.c |   25 +
  arch/powerpc/platforms/82xx/pq2ads.h  |3 +++
  3 files changed, 36 insertions(+), 0 deletions(-)
 
 diff --git a/arch/powerpc/boot/dts/mpc8272ads.dts 
 b/arch/powerpc/boot/dts/mpc8272ads.dts
 index b2ce4c0..75cc94c 100644
 --- a/arch/powerpc/boot/dts/mpc8272ads.dts
 +++ b/arch/powerpc/boot/dts/mpc8272ads.dts
 @@ -256,6 +256,14 @@
   #address-cells = 1;
   #size-cells = 0;
   };
 +
 + [EMAIL PROTECTED] {
 + compatible = fsl,qe_udc;

fsl,mpc8272-usb, fsl,cpm2-usb.

Where is fsl,qe_udc documented or used (other than in the BCSR setup)?
What does udc mean (the only reference to it in the 8272 manual is
under ATM)?

 + mode = slave;

Please document this property.

-Scott
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 4/6] powerpc: add USB peripheral support to MPC8272ADS

2008-08-06 Thread Li Yang 
On Wed, 2008-08-06 at 12:19 -0500, Scott Wood wrote:
 On Wed, Aug 06, 2008 at 03:04:43PM +0800, Li Yang wrote:
  Signed-off-by: Li Yang [EMAIL PROTECTED]
  ---
   arch/powerpc/boot/dts/mpc8272ads.dts  |8 
   arch/powerpc/platforms/82xx/mpc8272_ads.c |   25 +
   arch/powerpc/platforms/82xx/pq2ads.h  |3 +++
   3 files changed, 36 insertions(+), 0 deletions(-)
  
  diff --git a/arch/powerpc/boot/dts/mpc8272ads.dts 
  b/arch/powerpc/boot/dts/mpc8272ads.dts
  index b2ce4c0..75cc94c 100644
  --- a/arch/powerpc/boot/dts/mpc8272ads.dts
  +++ b/arch/powerpc/boot/dts/mpc8272ads.dts
  @@ -256,6 +256,14 @@
  #address-cells = 1;
  #size-cells = 0;
  };
  +
  +   [EMAIL PROTECTED] {
  +   compatible = fsl,qe_udc;
 
 fsl,mpc8272-usb, fsl,cpm2-usb.
 
 Where is fsl,qe_udc documented or used (other than in the BCSR setup)?
 What does udc mean (the only reference to it in the 8272 manual is
 under ATM)?

udc is a common name for USB device mode drivers to work with Linux
gadget.  We will have two separate drivers for USB host and device.
Probably we can have two compatibles fsl,qe_udc and fsl,qe-usb-host

- Leo

___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev