Re: [PATCH 6/8] pseries: phyp dump: Invalidate and print dump areas.

[Paul Mackerras]

Manish Ahuja writes:

 -static void
 -release_memory_range(unsigned long start_pfn, unsigned long nr_pages)
 +static
 +void release_memory_range(unsigned long start_pfn, unsigned long nr_pages)

This change looks rather pointless.  If you have to change it, I'd
prefer:

static void release_memory_range(unsigned long start_pfn,
unsigned long nr_pages)

Paul.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 6/8] pseries: phyp dump: Invalidate and print dump areas.

[Stephen Rothwell]

Hi Manish,

On Tue, 12 Feb 2008 01:18:22 -0600 Manish Ahuja [EMAIL PROTECTED] wrote:

 -static void
 -release_memory_range(unsigned long start_pfn, unsigned long nr_pages)
 +static
 +void release_memory_range(unsigned long start_pfn, unsigned long nr_pages)

Cosmetic changes like this should normally be put in separate patch as
they just distract from a real review (which this isn't :-))

-- 
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/


pgp0nUI4CWqt4.pgp
Description: PGP signature
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev