Re: [PATCH 6/9] powerpc: Add VSX CPU feature

2008-06-24 Thread Kumar Gala


On Jun 24, 2008, at 5:57 AM, Michael Neuling wrote:


Add a VSX CPU feature.  Also add code to detect if VSX is available
from the device tree.

Signed-off-by: Michael Neuling [EMAIL PROTECTED]
Signed-off-by: Joel Schopp [EMAIL PROTECTED]


Acked-by: Kumar Gala [EMAIL PROTECTED]

- k
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [PATCH 6/9] powerpc: Add VSX CPU feature

2008-06-19 Thread David Woodhouse
On Wed, 2008-06-18 at 10:47 +1000, Michael Neuling wrote:
 {ibm,vmx, 1, CPU_FTR_ALTIVEC, PPC_FEATURE_HAS_ALTIVEC},
  #endif /* CONFIG_ALTIVEC */
 +#ifdef CONFIG_VSX
 +   {ibm,vmx, 2, CPU_FTR_VSX, PPC_FEATURE_HAS_VSX},
 +#endif /* CONFIG_VSX */

Should that be ibm,vsx?

-- 
dwmw2

___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [PATCH 6/9] powerpc: Add VSX CPU feature

2008-06-19 Thread Michael Neuling
 On Wed, 2008-06-18 at 10:47 +1000, Michael Neuling wrote:
  {ibm,vmx, 1, CPU_FTR_ALTIVEC, PPC_FEATURE_HAS_ALTIVEC},
   #endif /* CONFIG_ALTIVEC */
  +#ifdef CONFIG_VSX
  +   {ibm,vmx, 2, CPU_FTR_VSX, PPC_FEATURE_HAS_VSX},
  +#endif /* CONFIG_VSX */
 
 Should that be ibm,vsx?

Nope ibm,vmx == 2 is correct for VSX.

You're not the first to think it looks wrong, so I should add a
comment.  

Mikey
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [PATCH 6/9] powerpc: Add VSX CPU feature

2008-06-18 Thread Joel Schopp

A couple of these lines originated with me.

Signed-off-by: Joel Schopp [EMAIL PROTECTED]

Michael Neuling wrote:

Add a VSX CPU feature.  Also add code to detect if VSX is available
from the device tree.

Signed-off-by: Michael Neuling [EMAIL PROTECTED]
---

 arch/powerpc/kernel/prom.c |3 +++
 include/asm-powerpc/cputable.h |   13 +
 2 files changed, 16 insertions(+)

Index: linux-2.6-ozlabs/arch/powerpc/kernel/prom.c
===
--- linux-2.6-ozlabs.orig/arch/powerpc/kernel/prom.c
+++ linux-2.6-ozlabs/arch/powerpc/kernel/prom.c
@@ -609,6 +609,9 @@ static struct feature_property {
{altivec, 0, CPU_FTR_ALTIVEC, PPC_FEATURE_HAS_ALTIVEC},
{ibm,vmx, 1, CPU_FTR_ALTIVEC, PPC_FEATURE_HAS_ALTIVEC},
 #endif /* CONFIG_ALTIVEC */
+#ifdef CONFIG_VSX
+   {ibm,vmx, 2, CPU_FTR_VSX, PPC_FEATURE_HAS_VSX},
+#endif /* CONFIG_VSX */
 #ifdef CONFIG_PPC64
{ibm,dfp, 1, 0, PPC_FEATURE_HAS_DFP},
{ibm,purr, 1, CPU_FTR_PURR, 0},
Index: linux-2.6-ozlabs/include/asm-powerpc/cputable.h
===
--- linux-2.6-ozlabs.orig/include/asm-powerpc/cputable.h
+++ linux-2.6-ozlabs/include/asm-powerpc/cputable.h
@@ -27,6 +27,7 @@
 #define PPC_FEATURE_HAS_DFP0x0400
 #define PPC_FEATURE_POWER6_EXT 0x0200
 #define PPC_FEATURE_ARCH_2_06  0x0100
+#define PPC_FEATURE_HAS_VSX0x0080
 
 #define PPC_FEATURE_TRUE_LE		0x0002

 #define PPC_FEATURE_PPC_LE 0x0001
@@ -181,6 +182,7 @@ extern void do_feature_fixups(unsigned l
 #define CPU_FTR_DSCR   LONG_ASM_CONST(0x0002)
 #define CPU_FTR_1T_SEGMENT LONG_ASM_CONST(0x0004)
 #define CPU_FTR_NO_SLBIE_B LONG_ASM_CONST(0x0008)
+#define CPU_FTR_VSXLONG_ASM_CONST(0x0010)
 
 #ifndef __ASSEMBLY__
 
@@ -199,6 +201,17 @@ extern void do_feature_fixups(unsigned l

 #define PPC_FEATURE_HAS_ALTIVEC_COMP0
 #endif
 
+/* We only set the VSX features if the kernel was compiled with VSX

+ * support
+ */
+#ifdef CONFIG_VSX
+#define CPU_FTR_VSX_COMP   CPU_FTR_VSX
+#define PPC_FEATURE_HAS_VSX_COMP PPC_FEATURE_HAS_VSX
+#else
+#define CPU_FTR_VSX_COMP   0
+#define PPC_FEATURE_HAS_VSX_COMP0
+#endif
+
 /* We only set the spe features if the kernel was compiled with spe
  * support
  */
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
  


___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev