Re: [PATCH net-next] net: freescale: Remove unused declarations
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski :
On Thu, 17 Aug 2023 21:41:59 +0800 you wrote:
> Commit 5d93cfcf7360 ("net: dpaa: Convert to phylink") removed
> fman_set_mac_active_pause()/fman_get_pause_cfg() but not declarations.
> Commit 48257c4f168e ("Add fs_enet ethernet network driver, for several
> embedded platforms.") declared but never implemented
> fs_enet_platform_init() and fs_enet_platform_cleanup().
>
> Signed-off-by: Yue Haibing
>
> [...]
Here is the summary with links:
- [net-next] net: freescale: Remove unused declarations
https://git.kernel.org/netdev/net-next/c/cb49ec034924
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Re: [PATCH net-next] net: freescale: Remove unused declarations
On Thu, Aug 17, 2023 at 09:41:59PM +0800, Yue Haibing wrote:
> Commit 5d93cfcf7360 ("net: dpaa: Convert to phylink") removed
> fman_set_mac_active_pause()/fman_get_pause_cfg() but not declarations.
> Commit 48257c4f168e ("Add fs_enet ethernet network driver, for several
> embedded platforms.") declared but never implemented
> fs_enet_platform_init() and fs_enet_platform_cleanup().
>
> Signed-off-by: Yue Haibing
> ---
> drivers/net/ethernet/freescale/fman/mac.h| 4
> drivers/net/ethernet/freescale/fs_enet/fs_enet.h | 5 -
> 2 files changed, 9 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky
RE: [PATCH net-next] net: freescale: Remove unused declarations
> -Original Message-
> From: Yue Haibing
> Sent: 17 August 2023 16:42
> To: Madalin Bucur ; Sean Anderson
> ; da...@davemloft.net; eduma...@google.com;
> k...@kernel.org; pab...@redhat.com; pantelis.anton...@gmail.com; Camelia
> Alexandra Groza ; christophe.le...@csgroup.eu;
> yuehaib...@huawei.com
> Cc: net...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> Subject: [PATCH net-next] net: freescale: Remove unused declarations
>
> Commit 5d93cfcf7360 ("net: dpaa: Convert to phylink") removed
> fman_set_mac_active_pause()/fman_get_pause_cfg() but not declarations.
> Commit 48257c4f168e ("Add fs_enet ethernet network driver, for several
> embedded platforms.") declared but never implemented
> fs_enet_platform_init() and fs_enet_platform_cleanup().
>
> Signed-off-by: Yue Haibing
> ---
> drivers/net/ethernet/freescale/fman/mac.h| 4
> drivers/net/ethernet/freescale/fs_enet/fs_enet.h | 5 -
> 2 files changed, 9 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fman/mac.h
> b/drivers/net/ethernet/freescale/fman/mac.h
> index ad06f8d7924b..fe747915cc73 100644
> --- a/drivers/net/ethernet/freescale/fman/mac.h
> +++ b/drivers/net/ethernet/freescale/fman/mac.h
> @@ -68,10 +68,6 @@ struct dpaa_eth_data {
>
> extern const char*mac_driver_description;
>
> -int fman_set_mac_active_pause(struct mac_device *mac_dev, bool rx, bool
> tx);
> -
> -void fman_get_pause_cfg(struct mac_device *mac_dev, bool *rx_pause,
> - bool *tx_pause);
> int fman_set_multi(struct net_device *net_dev, struct mac_device
> *mac_dev);
>
> #endif /* __MAC_H */
> diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet.h
> b/drivers/net/ethernet/freescale/fs_enet/fs_enet.h
> index d371072fff60..759bb7080e22 100644
> --- a/drivers/net/ethernet/freescale/fs_enet/fs_enet.h
> +++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet.h
> @@ -208,11 +208,6 @@ void fs_cleanup_bds(struct net_device *dev);
> #define DRV_MODULE_NAME "fs_enet"
> #define PFX DRV_MODULE_NAME ": "
>
> -
> /
> ***/
> -
> -int fs_enet_platform_init(void);
> -void fs_enet_platform_cleanup(void);
> -
>
> /
> ***/
> /* buffer descriptor access macros */
>
> --
> 2.34.1
Acked-by: Madalin Bucur
Re: [PATCH net-next] net: freescale: Remove unused declarations
On 8/17/23 09:41, Yue Haibing wrote:
> Commit 5d93cfcf7360 ("net: dpaa: Convert to phylink") removed
> fman_set_mac_active_pause()/fman_get_pause_cfg() but not declarations.
> Commit 48257c4f168e ("Add fs_enet ethernet network driver, for several
> embedded platforms.") declared but never implemented
> fs_enet_platform_init() and fs_enet_platform_cleanup().
>
> Signed-off-by: Yue Haibing
> ---
> drivers/net/ethernet/freescale/fman/mac.h| 4
> drivers/net/ethernet/freescale/fs_enet/fs_enet.h | 5 -
> 2 files changed, 9 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fman/mac.h
> b/drivers/net/ethernet/freescale/fman/mac.h
> index ad06f8d7924b..fe747915cc73 100644
> --- a/drivers/net/ethernet/freescale/fman/mac.h
> +++ b/drivers/net/ethernet/freescale/fman/mac.h
> @@ -68,10 +68,6 @@ struct dpaa_eth_data {
>
> extern const char*mac_driver_description;
>
> -int fman_set_mac_active_pause(struct mac_device *mac_dev, bool rx, bool tx);
> -
> -void fman_get_pause_cfg(struct mac_device *mac_dev, bool *rx_pause,
> - bool *tx_pause);
> int fman_set_multi(struct net_device *net_dev, struct mac_device *mac_dev);
>
> #endif /* __MAC_H */
> diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet.h
> b/drivers/net/ethernet/freescale/fs_enet/fs_enet.h
> index d371072fff60..759bb7080e22 100644
> --- a/drivers/net/ethernet/freescale/fs_enet/fs_enet.h
> +++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet.h
> @@ -208,11 +208,6 @@ void fs_cleanup_bds(struct net_device *dev);
> #define DRV_MODULE_NAME "fs_enet"
> #define PFX DRV_MODULE_NAME ": "
>
> -/***/
> -
> -int fs_enet_platform_init(void);
> -void fs_enet_platform_cleanup(void);
> -
> /***/
> /* buffer descriptor access macros */
>
Reviewed-by: Sean Anderson
