Re: [PATCH v1 1/1] soc: fsl: Replace kernel.h with the necessary inclusions
On Sat, Oct 30, 2021 at 10:28:01AM +0300, Andy Shevchenko wrote: > On Saturday, October 30, 2021, Christophe Leroy > wrote: > > Le 29/10/2021 à 22:31, Andy Shevchenko a écrit : ... > > That means that Michael considered it is not for him. > > > > And I think the reason is that in MAINTAINERS you have: > > > > FREESCALE QUICC ENGINE LIBRARY > > M: Qiang Zhao > > L: linuxppc-dev@lists.ozlabs.org > > S: Maintained > > F: drivers/soc/fsl/qe/ > > F: include/soc/fsl/*qe*.h > > F: include/soc/fsl/*ucc*.h > > > > > > FREESCALE SOC DRIVERS > > M: Li Yang > > L: linuxppc-dev@lists.ozlabs.org > > L: linux-arm-ker...@lists.infradead.org (moderated for > > non-subscribers) > > S: Maintained > > F: Documentation/devicetree/bindings/misc/fsl,dpaa2-console.yaml > > F: Documentation/devicetree/bindings/soc/fsl/ > > F: drivers/soc/fsl/ > > F: include/linux/fsl/ > > > Thanks! Now I should understand why get_maintainer hadn’t showed above for > me. He-he, there are two bugs in MAINTAINERS. v2 has been sent with the corresponding fixes and updated Cc list. -- With Best Regards, Andy Shevchenko
Re: [PATCH v1 1/1] soc: fsl: Replace kernel.h with the necessary inclusions
On Saturday, October 30, 2021, Christophe Leroy wrote: > > Le 29/10/2021 à 22:31, Andy Shevchenko a écrit : > >> On Fri, Oct 29, 2021 at 10:04 PM LEROY Christophe >> wrote: >> >>> >>> >>> >>> Le 29/10/2021 à 17:55, Andy Shevchenko a écrit : >>> On Wed, Oct 27, 2021 at 06:33:54PM +0300, Andy Shevchenko wrote: > When kernel.h is used in the headers it adds a lot into dependency > hell, > especially when there are circular dependencies are involved. > > Replace kernel.h inclusion with the list of what is really being used. > Seems nobody from PPC took this patch. Any idea who can take it? >>> You have to check in MAINTAINERS file in the root directory of kernel >>> sources: https://github.com/linuxppc/linux/blob/master/MAINTAINERS >>> >> >> Actually for these files get_maintainer.pl showed nothing. >> I have chosen PPC maintainers manually. >> >> That's Michael who takes them. But you have to allow him enough time for >>> it. >>> >> >> Thanks! >> >> I wrote that message because I have got a notification from checkpatch >> that it should go somewhere else. >> >> > That means that Michael considered it is not for him. > > And I think the reason is that in MAINTAINERS you have: > > FREESCALE QUICC ENGINE LIBRARY > M: Qiang Zhao > L: linuxppc-dev@lists.ozlabs.org > S: Maintained > F: drivers/soc/fsl/qe/ > F: include/soc/fsl/*qe*.h > F: include/soc/fsl/*ucc*.h > > > FREESCALE SOC DRIVERS > M: Li Yang > L: linuxppc-dev@lists.ozlabs.org > L: linux-arm-ker...@lists.infradead.org (moderated for > non-subscribers) > S: Maintained > F: Documentation/devicetree/bindings/misc/fsl,dpaa2-console.yaml > F: Documentation/devicetree/bindings/soc/fsl/ > F: drivers/soc/fsl/ > F: include/linux/fsl/ > > Thanks! Now I should understand why get_maintainer hadn’t showed above for me. > Sorry I overlooked your patch. NP > > Christophe > -- With Best Regards, Andy Shevchenko
Re: [PATCH v1 1/1] soc: fsl: Replace kernel.h with the necessary inclusions
Le 29/10/2021 à 22:31, Andy Shevchenko a écrit : On Fri, Oct 29, 2021 at 10:04 PM LEROY Christophe wrote: Le 29/10/2021 à 17:55, Andy Shevchenko a écrit : On Wed, Oct 27, 2021 at 06:33:54PM +0300, Andy Shevchenko wrote: When kernel.h is used in the headers it adds a lot into dependency hell, especially when there are circular dependencies are involved. Replace kernel.h inclusion with the list of what is really being used. Seems nobody from PPC took this patch. Any idea who can take it? You have to check in MAINTAINERS file in the root directory of kernel sources: https://github.com/linuxppc/linux/blob/master/MAINTAINERS Actually for these files get_maintainer.pl showed nothing. I have chosen PPC maintainers manually. That's Michael who takes them. But you have to allow him enough time for it. Thanks! I wrote that message because I have got a notification from checkpatch that it should go somewhere else. That means that Michael considered it is not for him. And I think the reason is that in MAINTAINERS you have: FREESCALE QUICC ENGINE LIBRARY M: Qiang Zhao L: linuxppc-dev@lists.ozlabs.org S: Maintained F: drivers/soc/fsl/qe/ F: include/soc/fsl/*qe*.h F: include/soc/fsl/*ucc*.h FREESCALE SOC DRIVERS M: Li Yang L: linuxppc-dev@lists.ozlabs.org L: linux-arm-ker...@lists.infradead.org (moderated for non-subscribers) S: Maintained F: Documentation/devicetree/bindings/misc/fsl,dpaa2-console.yaml F: Documentation/devicetree/bindings/soc/fsl/ F: drivers/soc/fsl/ F: include/linux/fsl/ Sorry I overlooked your patch. Christophe
Re: [PATCH v1 1/1] soc: fsl: Replace kernel.h with the necessary inclusions
On Fri, Oct 29, 2021 at 10:04 PM LEROY Christophe wrote: > > > > Le 29/10/2021 à 17:55, Andy Shevchenko a écrit : > > On Wed, Oct 27, 2021 at 06:33:54PM +0300, Andy Shevchenko wrote: > >> When kernel.h is used in the headers it adds a lot into dependency hell, > >> especially when there are circular dependencies are involved. > >> > >> Replace kernel.h inclusion with the list of what is really being used. > > > > Seems nobody from PPC took this patch. > > Any idea who can take it? > > > > You have to check in MAINTAINERS file in the root directory of kernel > sources: https://github.com/linuxppc/linux/blob/master/MAINTAINERS Actually for these files get_maintainer.pl showed nothing. I have chosen PPC maintainers manually. > That's Michael who takes them. But you have to allow him enough time for it. Thanks! I wrote that message because I have got a notification from checkpatch that it should go somewhere else. -- With Best Regards, Andy Shevchenko
Re: [PATCH v1 1/1] soc: fsl: Replace kernel.h with the necessary inclusions
Le 29/10/2021 à 17:55, Andy Shevchenko a écrit : On Wed, Oct 27, 2021 at 06:33:54PM +0300, Andy Shevchenko wrote: When kernel.h is used in the headers it adds a lot into dependency hell, especially when there are circular dependencies are involved. Replace kernel.h inclusion with the list of what is really being used. Seems nobody from PPC took this patch. Any idea who can take it? You have to check in MAINTAINERS file in the root directory of kernel sources: https://github.com/linuxppc/linux/blob/master/MAINTAINERS That's Michael who takes them. But you have to allow him enough time for it. Christophe
Re: [PATCH v1 1/1] soc: fsl: Replace kernel.h with the necessary inclusions
Le 29/10/2021 à 17:55, Andy Shevchenko a écrit : > On Wed, Oct 27, 2021 at 06:33:54PM +0300, Andy Shevchenko wrote: >> When kernel.h is used in the headers it adds a lot into dependency hell, >> especially when there are circular dependencies are involved. >> >> Replace kernel.h inclusion with the list of what is really being used. > > Seems nobody from PPC took this patch. > Any idea who can take it? > You have to check in MAINTAINERS file in the root directory of kernel sources: https://github.com/linuxppc/linux/blob/master/MAINTAINERS That's Michael who takes them. But you have to allow him enough time for it. Christophe
Re: [PATCH v1 1/1] soc: fsl: Replace kernel.h with the necessary inclusions
On Wed, Oct 27, 2021 at 06:33:54PM +0300, Andy Shevchenko wrote: > When kernel.h is used in the headers it adds a lot into dependency hell, > especially when there are circular dependencies are involved. > > Replace kernel.h inclusion with the list of what is really being used. Seems nobody from PPC took this patch. Any idea who can take it? -- With Best Regards, Andy Shevchenko
