Re: [PATCH v12 08/11] arm64/kasan: add and use kasan_map_populate()
1. Replace these two patches: arm64/kasan: add and use kasan_map_populate() x86/kasan: add and use kasan_map_populate() With: x86/mm/kasan: don't use vmemmap_populate() to initialize shadow arm64/mm/kasan: don't use vmemmap_populate() to initialize shadow Pavel, could you please send the patches? These patches doesn't interfere with rest of the series, so I think it should be enough to send just two patches to replace the old ones. Hi Andrey, I asked Michal and Andrew how to proceed but never received a reply from them. The patches independent from the deferred page init series as long as they come before the series. Anyway, I will post these two patches to the mailing list soon. But, not really sure if they will be taken into mm-tree. Pavel
Re: [PATCH v12 08/11] arm64/kasan: add and use kasan_map_populate()
Hi Andrew and Michal, There are a few changes I need to do to my series: 1. Replace these two patches: arm64/kasan: add and use kasan_map_populate() x86/kasan: add and use kasan_map_populate() With: x86/mm/kasan: don't use vmemmap_populate() to initialize shadow arm64/mm/kasan: don't use vmemmap_populate() to initialize shadow 2. Fix a kbuild warning about section mismatch in mm: deferred_init_memmap improvements How should I proceed to get these replaced in mm-tree? Send three new patches, or send a new series? Thank you, Pavel On 10/18/2017 01:18 PM, Andrey Ryabinin wrote: On 10/18/2017 08:08 PM, Pavel Tatashin wrote: As I said, I'm fine either way, I just didn't want to cause extra work or rebasing: http://lists.infradead.org/pipermail/linux-arm-kernel/2017-October/535703.html Makes sense. I am also fine either way, I can submit a new patch merging together the two if needed. Please, do this. Single patch makes more sense Pavel
Re: [PATCH v12 08/11] arm64/kasan: add and use kasan_map_populate()
As I said, I'm fine either way, I just didn't want to cause extra work or rebasing: http://lists.infradead.org/pipermail/linux-arm-kernel/2017-October/535703.html Makes sense. I am also fine either way, I can submit a new patch merging together the two if needed. Pavel
Re: [PATCH v12 08/11] arm64/kasan: add and use kasan_map_populate()
On Wed, Oct 18, 2017 at 01:03:10PM -0400, Pavel Tatashin wrote: > I asked Will, about it, and he preferred to have this patched added to the > end of my series instead of replacing "arm64/kasan: add and use > kasan_map_populate()". As I said, I'm fine either way, I just didn't want to cause extra work or rebasing: http://lists.infradead.org/pipermail/linux-arm-kernel/2017-October/535703.html > In addition, Will's patch stops using large pages for kasan memory, and thus > might add some regression in which case it is easier to revert just that > patch instead of the whole series. It is unlikely that regression is going > to be detectable, because kasan by itself makes system quiet slow already. If it causes problems, I'll just fix them. No need to revert. Will
Re: [PATCH v12 08/11] arm64/kasan: add and use kasan_map_populate()
Hi Andrey, I asked Will, about it, and he preferred to have this patched added to the end of my series instead of replacing "arm64/kasan: add and use kasan_map_populate()". In addition, Will's patch stops using large pages for kasan memory, and thus might add some regression in which case it is easier to revert just that patch instead of the whole series. It is unlikely that regression is going to be detectable, because kasan by itself makes system quiet slow already. Pasha
