Re: [PATCH v2] [POWERPC] 4xx: Add endpoint support to 4xx PCIe driver
On Mon, 2008-04-21 at 16:54 +0200, Stefan Roese wrote: This patch adds basic endpoint support to the 4xx PCIe driver. This is done by checking the device_type property of the PCIe device node (pci for root-complex and pci-endpoint for endpoint configuration). Note: Currently we map a fixed 64MByte window to PLB address 0 (SDRAM). This should probably be configurable via a dts property. Signed-off-by: Stefan Roese [EMAIL PROTECTED] Acked-by: Benjamin Herrenschmidt [EMAIL PROTECTED] --- Paul, I forgot to send that ack a while ago, this is .26 material, been around for some time. Cheers, Ben. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH v2] [POWERPC] 4xx: Add endpoint support to 4xx PCIe driver
On Fri, 25 Apr 2008 16:24:01 +1000 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Mon, 2008-04-21 at 16:54 +0200, Stefan Roese wrote: This patch adds basic endpoint support to the 4xx PCIe driver. This is done by checking the device_type property of the PCIe device node (pci for root-complex and pci-endpoint for endpoint configuration). Note: Currently we map a fixed 64MByte window to PLB address 0 (SDRAM). This should probably be configurable via a dts property. Signed-off-by: Stefan Roese [EMAIL PROTECTED] Acked-by: Benjamin Herrenschmidt [EMAIL PROTECTED] --- Paul, I forgot to send that ack a while ago, this is .26 material, been around for some time. I'll add it to my tree. And this version of the patch was only sent out on Monday. josh ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH v2] [POWERPC] 4xx: Add endpoint support to 4xx PCIe driver
On Fri, 2008-04-25 at 05:37 -0500, Josh Boyer wrote: On Fri, 25 Apr 2008 16:24:01 +1000 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Mon, 2008-04-21 at 16:54 +0200, Stefan Roese wrote: This patch adds basic endpoint support to the 4xx PCIe driver. This is done by checking the device_type property of the PCIe device node (pci for root-complex and pci-endpoint for endpoint configuration). Note: Currently we map a fixed 64MByte window to PLB address 0 (SDRAM). This should probably be configurable via a dts property. Signed-off-by: Stefan Roese [EMAIL PROTECTED] Acked-by: Benjamin Herrenschmidt [EMAIL PROTECTED] --- Paul, I forgot to send that ack a while ago, this is .26 material, been around for some time. I'll add it to my tree. And this version of the patch was only sent out on Monday. True but I'm to blame for waiting too long to review it... Ben. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH v2] [POWERPC] 4xx: Add endpoint support to 4xx PCIe driver
On Fri, 25 Apr 2008 22:58:04 +1000 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Fri, 2008-04-25 at 05:37 -0500, Josh Boyer wrote: On Fri, 25 Apr 2008 16:24:01 +1000 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Mon, 2008-04-21 at 16:54 +0200, Stefan Roese wrote: This patch adds basic endpoint support to the 4xx PCIe driver. This is done by checking the device_type property of the PCIe device node (pci for root-complex and pci-endpoint for endpoint configuration). Note: Currently we map a fixed 64MByte window to PLB address 0 (SDRAM). This should probably be configurable via a dts property. Signed-off-by: Stefan Roese [EMAIL PROTECTED] Acked-by: Benjamin Herrenschmidt [EMAIL PROTECTED] --- Paul, I forgot to send that ack a while ago, this is .26 material, been around for some time. I'll add it to my tree. And this version of the patch was only sent out on Monday. True but I'm to blame for waiting too long to review it... Oh, for sure. We blame you for all kinds of things. It's just easier that way ;) josh ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH v2] [POWERPC] 4xx: Add endpoint support to 4xx PCIe driver
On Apr 25, 2008, at 8:19 AM, Josh Boyer wrote: On Fri, 25 Apr 2008 22:58:04 +1000 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Fri, 2008-04-25 at 05:37 -0500, Josh Boyer wrote: On Fri, 25 Apr 2008 16:24:01 +1000 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Mon, 2008-04-21 at 16:54 +0200, Stefan Roese wrote: This patch adds basic endpoint support to the 4xx PCIe driver. This is done by checking the device_type property of the PCIe device node (pci for root-complex and pci-endpoint for endpoint configuration). Note: Currently we map a fixed 64MByte window to PLB address 0 (SDRAM). This should probably be configurable via a dts property. Signed-off-by: Stefan Roese [EMAIL PROTECTED] Acked-by: Benjamin Herrenschmidt [EMAIL PROTECTED] --- Paul, I forgot to send that ack a while ago, this is .26 material, been around for some time. I'll add it to my tree. And this version of the patch was only sent out on Monday. True but I'm to blame for waiting too long to review it... Oh, for sure. We blame you for all kinds of things. It's just easier that way ;) Can we include an example of the device node in the commit message (or some updates to docs/booting-with-of.txt) - k ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH v2] [POWERPC] 4xx: Add endpoint support to 4xx PCIe driver
On Mon, 2008-04-21 at 16:54 +0200, Stefan Roese wrote: -- - As suggested by Benjamin Herrenschmidt, don't determine endpoint mode by looking at the already configured PCIe port state, but evaluate the device_type property instead. This makes it possible for boards without a previously run PCIe configuration (e.g. U-Boot) to configure a port as endpoint as well. - Don't map the big external config space upon endpoint configuration. - Introduce vendor-id and device-id properties to be written to the host bridge. and class-code too ? Appart from that, I'll have a quick look at the patch later today but at first it looks good. Cheers, Ben. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH v2] [POWERPC] 4xx: Add endpoint support to 4xx PCIe driver
On Monday 21 April 2008, Benjamin Herrenschmidt wrote: On Mon, 2008-04-21 at 16:54 +0200, Stefan Roese wrote: -- - As suggested by Benjamin Herrenschmidt, don't determine endpoint mode by looking at the already configured PCIe port state, but evaluate the device_type property instead. This makes it possible for boards without a previously run PCIe configuration (e.g. U-Boot) to configure a port as endpoint as well. - Don't map the big external config space upon endpoint configuration. - Introduce vendor-id and device-id properties to be written to the host bridge. and class-code too ? Sure, could be done. But this is not really endpoint/root-complex related. So I suggest to add this later with an additional patch. Appart from that, I'll have a quick look at the patch later today but at first it looks good. Thanks. Best regards, Stefan ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
