Re: [PATCH v2 02/10] ARM: dts: ls1021a: add TQ-Systems MBLS102xA device tree
Hi Shawn,
thanks for your feedback.
Am Donnerstag, 26. Januar 2023, 10:44:21 CET schrieb Shawn Guo:
> On Fri, Jan 20, 2023 at 02:34:47PM +0100, Alexander Stein wrote:
> > Add device tree for the MBLS102xA mainboard with TQMLS1021A SoM.
> >
> > Signed-off-by: Alexander Stein
> > ---
> > Changes in v2:
> > * Remove unnecessary status = "okay"
> > * Remove underscore from node names
> > * Move reg direct below compatiblefor i2c devices
> > * Remove i2c device nodes without software support
> >
> > Add a comment about existance for the device though
> >
> > arch/arm/boot/dts/Makefile| 1 +
> > .../boot/dts/ls1021a-tqmls1021a-mbls1021a.dts | 406 ++
> > arch/arm/boot/dts/ls1021a-tqmls1021a.dtsi | 81
> > 3 files changed, 488 insertions(+)
> > create mode 100644 arch/arm/boot/dts/ls1021a-tqmls1021a-mbls1021a.dts
> > create mode 100644 arch/arm/boot/dts/ls1021a-tqmls1021a.dtsi
> >
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index d0c07867aeabe..44b5ed44b13d6 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -802,6 +802,7 @@ dtb-$(CONFIG_SOC_LS1021A) += \
> >
> > ls1021a-iot.dtb \
> > ls1021a-moxa-uc-8410a.dtb \
> > ls1021a-qds.dtb \
> >
> > + ls1021a-tqmls1021a-mbls1021a.dtb \
> >
> > ls1021a-tsn.dtb \
> > ls1021a-twr.dtb
> >
> > dtb-$(CONFIG_SOC_VF610) += \
> >
> > diff --git a/arch/arm/boot/dts/ls1021a-tqmls1021a-mbls1021a.dts
> > b/arch/arm/boot/dts/ls1021a-tqmls1021a-mbls1021a.dts new file mode 100644
> > index 0..aa8b605344655
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/ls1021a-tqmls1021a-mbls1021a.dts
> > @@ -0,0 +1,406 @@
> > +// SPDX-License-Identifier: (GPL-2.0-or-later OR X11)
> > +/*
> > + * Copyright 2013-2014 Freescale Semiconductor, Inc.
> > + * Copyright 2018-2023 TQ-Systems GmbH ,
> > + * D-82229 Seefeld, Germany.
> > + * Author: Alexander Stein
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include "ls1021a-tqmls1021a.dtsi"
> > +
> > +/ {
> > + model = "TQMLS102xA SOM on MBLS102xA";
> > + compatible = "tq,ls1021a-tqmls1021a-mbls102xa", "tq,ls1021a-
tqmls1021a",
> > "fsl,ls1021a"; +
> > + audio_mclk: audio-clock {
> > + compatible = "fixed-clock";
> > + #clock-cells = <0>;
> > + clock-frequency = <2500>;
> > + };
> > +
> > + backlight_dcu: backlight {
> > + compatible = "gpio-backlight";
> > + gpios = < 0 GPIO_ACTIVE_LOW>;
> > + status = "disabled";
> > + };
> > +
> > + gpio-keys {
> > + compatible = "gpio-keys";
> > + autorepeat;
> > +
> > + switch-1 {
> > + label = "S6";
> > + linux,code = ;
> > + gpios = <_0 0 GPIO_ACTIVE_LOW>;
> > + };
> > +
> > + btn2: switch-2 {
> > + label = "S7";
> > + linux,code = ;
> > + gpios = <_0 1 GPIO_ACTIVE_LOW>;
> > + };
> > +
> > + switch-3 {
> > + label = "S8";
> > + linux,code = ;
> > + gpios = <_0 2 GPIO_ACTIVE_LOW>;
> > + };
> > + };
> > +
> > + gpio_leds: gpio-leds {
> > + compatible = "gpio-leds";
> > +
> > + led-0 {
> > + color = ;
> > + function = LED_FUNCTION_STATUS;
> > + function-enumerator = <0>;
> > + gpios = <_2 4 GPIO_ACTIVE_LOW>;
> > + linux,default-trigger = "default-on";
> > + };
> > +
> > + led-1 {
> > + color = ;
> > + function = LED_FUNCTION_STATUS;
> > + function-enumerator = <1>;
> > + gpios = <_2 5 GPIO_ACTIVE_LOW>;
> > + linux,default-trigger = "default-on";
> > + };
> > +
> > + led-2 {
> > + color = ;
> > + function = LED_FUNCTION_STATUS;
> > + function-enumerator = <2>;
> > + gpios = <_2 6 GPIO_ACTIVE_LOW>;
> > + linux,default-trigger = "default-on";
> > + };
> > +
> > + led-3 {
> > + color = ;
> > + function = LED_FUNCTION_HEARTBEAT;
> > + function-enumerator = <0>;
> > + gpios = <_2 7 GPIO_ACTIVE_LOW>;
> > + linux,default-trigger = "heartbeat";
> > + };
> > + };
> > +
> > + lvds_encoder: lvds-encoder {
> > + compatible = "ti,sn75lvds83", "lvds-encoder";
> > + power-supply = <_3p3v>;
> > + status = "disabled";
> > +
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + port@0 {
> > + reg =
Re: [PATCH v2 02/10] ARM: dts: ls1021a: add TQ-Systems MBLS102xA device tree
On Fri, Jan 20, 2023 at 02:34:47PM +0100, Alexander Stein wrote:
> Add device tree for the MBLS102xA mainboard with TQMLS1021A SoM.
>
> Signed-off-by: Alexander Stein
> ---
> Changes in v2:
> * Remove unnecessary status = "okay"
> * Remove underscore from node names
> * Move reg direct below compatiblefor i2c devices
> * Remove i2c device nodes without software support
> Add a comment about existance for the device though
>
> arch/arm/boot/dts/Makefile| 1 +
> .../boot/dts/ls1021a-tqmls1021a-mbls1021a.dts | 406 ++
> arch/arm/boot/dts/ls1021a-tqmls1021a.dtsi | 81
> 3 files changed, 488 insertions(+)
> create mode 100644 arch/arm/boot/dts/ls1021a-tqmls1021a-mbls1021a.dts
> create mode 100644 arch/arm/boot/dts/ls1021a-tqmls1021a.dtsi
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index d0c07867aeabe..44b5ed44b13d6 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -802,6 +802,7 @@ dtb-$(CONFIG_SOC_LS1021A) += \
> ls1021a-iot.dtb \
> ls1021a-moxa-uc-8410a.dtb \
> ls1021a-qds.dtb \
> + ls1021a-tqmls1021a-mbls1021a.dtb \
> ls1021a-tsn.dtb \
> ls1021a-twr.dtb
> dtb-$(CONFIG_SOC_VF610) += \
> diff --git a/arch/arm/boot/dts/ls1021a-tqmls1021a-mbls1021a.dts
> b/arch/arm/boot/dts/ls1021a-tqmls1021a-mbls1021a.dts
> new file mode 100644
> index 0..aa8b605344655
> --- /dev/null
> +++ b/arch/arm/boot/dts/ls1021a-tqmls1021a-mbls1021a.dts
> @@ -0,0 +1,406 @@
> +// SPDX-License-Identifier: (GPL-2.0-or-later OR X11)
> +/*
> + * Copyright 2013-2014 Freescale Semiconductor, Inc.
> + * Copyright 2018-2023 TQ-Systems GmbH ,
> + * D-82229 Seefeld, Germany.
> + * Author: Alexander Stein
> + */
> +
> +/dts-v1/;
> +
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include "ls1021a-tqmls1021a.dtsi"
> +
> +/ {
> + model = "TQMLS102xA SOM on MBLS102xA";
> + compatible = "tq,ls1021a-tqmls1021a-mbls102xa",
> "tq,ls1021a-tqmls1021a", "fsl,ls1021a";
> +
> + audio_mclk: audio-clock {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <2500>;
> + };
> +
> + backlight_dcu: backlight {
> + compatible = "gpio-backlight";
> + gpios = < 0 GPIO_ACTIVE_LOW>;
> + status = "disabled";
> + };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> + autorepeat;
> +
> + switch-1 {
> + label = "S6";
> + linux,code = ;
> + gpios = <_0 0 GPIO_ACTIVE_LOW>;
> + };
> +
> + btn2: switch-2 {
> + label = "S7";
> + linux,code = ;
> + gpios = <_0 1 GPIO_ACTIVE_LOW>;
> + };
> +
> + switch-3 {
> + label = "S8";
> + linux,code = ;
> + gpios = <_0 2 GPIO_ACTIVE_LOW>;
> + };
> + };
> +
> + gpio_leds: gpio-leds {
> + compatible = "gpio-leds";
> +
> + led-0 {
> + color = ;
> + function = LED_FUNCTION_STATUS;
> + function-enumerator = <0>;
> + gpios = <_2 4 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "default-on";
> + };
> +
> + led-1 {
> + color = ;
> + function = LED_FUNCTION_STATUS;
> + function-enumerator = <1>;
> + gpios = <_2 5 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "default-on";
> + };
> +
> + led-2 {
> + color = ;
> + function = LED_FUNCTION_STATUS;
> + function-enumerator = <2>;
> + gpios = <_2 6 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "default-on";
> + };
> +
> + led-3 {
> + color = ;
> + function = LED_FUNCTION_HEARTBEAT;
> + function-enumerator = <0>;
> + gpios = <_2 7 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "heartbeat";
> + };
> + };
> +
> + lvds_encoder: lvds-encoder {
> + compatible = "ti,sn75lvds83", "lvds-encoder";
> + power-supply = <_3p3v>;
> + status = "disabled";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> +
> + lvds_encoder_in: endpoint {};
> + };
> +
> + port@1 {
> + reg = <1>;
> +
> + lvds_encoder_out: endpoint {};
> +
