Re: [PATCH v6 1/8] arch: enable relative relocations for arm64, power, x86, s390 and x86

2017-12-27 Thread Ard Biesheuvel 
On 27 December 2017 at 19:54, Linus Torvalds
 wrote:
> On Wed, Dec 27, 2017 at 12:50 AM, Ard Biesheuvel
>  wrote:
>> diff --git a/arch/arm64/kernel/vmlinux.lds.S 
>> b/arch/arm64/kernel/vmlinux.lds.S
>> index 7da3e5c366a0..49ae5b43fe2b 100644
>> --- a/arch/arm64/kernel/vmlinux.lds.S
>> +++ b/arch/arm64/kernel/vmlinux.lds.S
>> @@ -156,7 +156,7 @@ SECTIONS
>> CON_INITCALL
>> SECURITY_INITCALL
>> INIT_RAM_FS
>> -   *(.init.rodata.* .init.bss) /* from the EFI stub */
>> +   *(.init.rodata.* .init.bss .init.discard.*) /* EFI stub 
>> */
>> }
>> .exit.data : {
>> ARM_EXIT_KEEP(EXIT_DATA)
>
> Weren't you supposed to explain this part in the commit message?
>

Oops. Apologies, I indeed forgot to update the commit log.

> It isn't obvious why this is mixed up with the Kconfig changes, and
> somebody already asked about it. The commit message only talks about
> the Kconfig changes, and then suddenly there's that odd vmlinux.lds.S
> change in there...
>

Yeah. It doesn't make sense to respin right away for just that, so I
will give people some time to respond, and respin in a week or so.

Re: [PATCH v6 1/8] arch: enable relative relocations for arm64, power, x86, s390 and x86

2017-12-27 Thread Linus Torvalds 
On Wed, Dec 27, 2017 at 12:50 AM, Ard Biesheuvel
 wrote:
> diff --git a/arch/arm64/kernel/vmlinux.lds.S b/arch/arm64/kernel/vmlinux.lds.S
> index 7da3e5c366a0..49ae5b43fe2b 100644
> --- a/arch/arm64/kernel/vmlinux.lds.S
> +++ b/arch/arm64/kernel/vmlinux.lds.S
> @@ -156,7 +156,7 @@ SECTIONS
> CON_INITCALL
> SECURITY_INITCALL
> INIT_RAM_FS
> -   *(.init.rodata.* .init.bss) /* from the EFI stub */
> +   *(.init.rodata.* .init.bss .init.discard.*) /* EFI stub */
> }
> .exit.data : {
> ARM_EXIT_KEEP(EXIT_DATA)

Weren't you supposed to explain this part in the commit message?

It isn't obvious why this is mixed up with the Kconfig changes, and
somebody already asked about it. The commit message only talks about
the Kconfig changes, and then suddenly there's that odd vmlinux.lds.S
change in there...

  Linus