Re: [v2,9/9] fsl/fman: Add FMan MAC driver
On Thu, 2015-06-25 at 21:25 -0500, Scott Wood wrote: On Fri, 2015-06-26 at 12:21 +1000, Michael Ellerman wrote: On Thu, 2015-06-25 at 19:59 -0500, Scott Wood wrote: On Fri, 2015-06-26 at 01:06 +0200, Paul Bolle wrote: (Evolution 3.16 is basically unbearable for replying to patches. Anyone else running into this?) If you mean the crazy lag when selecting moderate-to-large amounts of text (for snipping), yes. I recommend the external editor plugin with vim. I tried the external editor plugin (not with vim) and it failed to bring the externally made edits back into the evolution compose window. It then started spastically respawning the external editor without my doing anything. I guess it only works with vim ;) cheers ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [v2,9/9] fsl/fman: Add FMan MAC driver
On Thu, 2015-06-25 at 19:59 -0500, Scott Wood wrote: On Fri, 2015-06-26 at 01:06 +0200, Paul Bolle wrote: (Evolution 3.16 is basically unbearable for replying to patches. Anyone else running into this?) You replied with Evolution v3.16, didn't you? Look how it wrapped that line. Now imagine how a patch of a few thousands lines might look like when replying. (Of course a patch of a few thousands lines is part of the issue here. As in: no one can really handle that.) And if you set certain lines to preformatted to undo the wrapping it inserts in the tabs! There's more. I'll stop now, as this is drifting too far off topic. If you mean the crazy lag when selecting moderate-to-large amounts of text (for snipping), yes. One of my replies I had to do over a few times because evolution or I lost track of what was selected. Ie, I thought I had selected hundreds of lines but something much smaller was deleted. Something like that. As confusing as it gets, so who knows what actually happened? Yes, I know, I should ask for a refund. Thanks, Paul Bolle ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [v2,9/9] fsl/fman: Add FMan MAC driver
(Evolution 3.16 is basically unbearable for replying to patches. Anyone
else running into this?)
On Wed, 2015-06-24 at 22:37 +0300, igal.liber...@freescale.com wrote:
--- /dev/null
+++ b/drivers/net/ethernet/freescale/fman/mac/mac-api.c
+int set_mac_active_pause(struct mac_device *mac_dev, bool rx, bool tx)
+{
+ [...]
+}
+EXPORT_SYMBOL(set_mac_active_pause);
Which module is using this function?
+void get_pause_cfg(struct mac_device *mac_dev, bool *rx_pause, bool
*tx_pause)
+{
+ [...]
+}
+EXPORT_SYMBOL(get_pause_cfg);
This exports a function that is only used in this file. Why?
Thanks,
Paul Bolle
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [v2,9/9] fsl/fman: Add FMan MAC driver
On Thu, 2015-06-25 at 19:59 -0500, Scott Wood wrote: On Fri, 2015-06-26 at 01:06 +0200, Paul Bolle wrote: (Evolution 3.16 is basically unbearable for replying to patches. Anyone else running into this?) If you mean the crazy lag when selecting moderate-to-large amounts of text (for snipping), yes. I recommend the external editor plugin with vim. cheers ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [v2,9/9] fsl/fman: Add FMan MAC driver
On Fri, 2015-06-26 at 12:21 +1000, Michael Ellerman wrote: On Thu, 2015-06-25 at 19:59 -0500, Scott Wood wrote: On Fri, 2015-06-26 at 01:06 +0200, Paul Bolle wrote: (Evolution 3.16 is basically unbearable for replying to patches. Anyone else running into this?) If you mean the crazy lag when selecting moderate-to-large amounts of text (for snipping), yes. I recommend the external editor plugin with vim. I tried the external editor plugin (not with vim) and it failed to bring the externally made edits back into the evolution compose window. It then started spastically respawning the external editor without my doing anything. -Scott ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [v2,9/9] fsl/fman: Add FMan MAC driver
On Fri, 2015-06-26 at 01:06 +0200, Paul Bolle wrote: (Evolution 3.16 is basically unbearable for replying to patches. Anyone else running into this?) If you mean the crazy lag when selecting moderate-to-large amounts of text (for snipping), yes. -Scott ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
