Re: Regarding irq_of_parse_and_map
On Thu, 2009-02-19 at 17:21 +0530, Vijay Nikam wrote: > Also is it possible to compile device tree on Linux host and genreate > dtb for powerpc ? ? ? If yes, then how ? ? ? please let me know ... > thanks ... Uh, get a copy of the DTC using: $ git clone git://git.jdl.com/software/dtc.git $ cd dtc $ make HTH, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: Regarding irq_of_parse_and_map
> Because dtc will generate phandles automatically when you reference the > node with the & operator. Yes the same statement I found in dts-bindings for gpio txt, sorry I missed it somehow ... > Do you want your changes to ever make it into the upstream kernel? Yes I would like to do that ... but the reason I asked is as it is my first try so I am thinking that I will edit the same file and do it in the same way ofcourse I will follow for device node gpio-controller the new apporach and later if it works then I will create new dts with upstream Linux base ... Now I have created the mpc8313erdb.dts with gpio-controller device node. I would like to ask that now I should compile it with dtc and generate dtb and I should load this dtb on board/target, Right ? ? ? please correct me if I am wrong ... Also is it possible to compile device tree on Linux host and genreate dtb for powerpc ? ? ? If yes, then how ? ? ? please let me know ... thanks ... Before I tried to generate virtual irq using irq_create_mapping and I got the same number as hw_irq_no i.e. 74 as virtual irq. Also the entry was made in proc/interrupts and trigger was 8 (Level). But when I tried to interrupt and the handler was never called ? ? ? Was it because of gpio device node missing in device tree ? ? ? please let me know ... thanks ... Kindly please acknowledge ... thank you ... Kind Regards, Vijay Nikam On 2/18/09, Scott Wood wrote: > On Wed, Feb 18, 2009 at 05:31:34PM +0530, Vijay Nikam wrote: > > > Don't specify this explicitly. Please base new development off of the > > > device tree that is in upstream Linux, not the very old tree in your BSP. > > > > May I know the reason why I should not specify it explicitly ? ? ? > > Because dtc will generate phandles automatically when you reference the > node with the & operator. > > > Also what would be the problem if I do in the same way as it is given > > in BSP mpc8313erdb.dts ? ? ? > > Do you want your changes to ever make it into the upstream kernel? > > > And should I use gpio-controller as a gpio device node ? ? ? > > Yes, the node should label itself as a gpio controller. > > -Scott > ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: Regarding irq_of_parse_and_map
On Wed, Feb 18, 2009 at 05:31:34PM +0530, Vijay Nikam wrote: > > Don't specify this explicitly. Please base new development off of the > > device tree that is in upstream Linux, not the very old tree in your BSP. > > May I know the reason why I should not specify it explicitly ? ? ? Because dtc will generate phandles automatically when you reference the node with the & operator. > Also what would be the problem if I do in the same way as it is given > in BSP mpc8313erdb.dts ? ? ? Do you want your changes to ever make it into the upstream kernel? > And should I use gpio-controller as a gpio device node ? ? ? Yes, the node should label itself as a gpio controller. -Scott ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: Regarding irq_of_parse_and_map
I checked and read the
Documentation/powerpc/dts-bindings/fsl/8xxx_gpio.txt and
booting-without-of.txt. It is different then what I read before from
booting-without-of.txt ... perhaps as it is old and came with BSP. Am
I right ? ? ?
> Don't specify this explicitly. Please base new development off of the
> device tree that is in upstream Linux, not the very old tree in your BSP.
May I know the reason why I should not specify it explicitly ? ? ?
Also what would be the problem if I do in the same way as it is given
in BSP mpc8313erdb.dts ? ? ?
And should I use gpio-controller as a gpio device node ? ? ?
Kindly please acknowledge ... thank you ...
Kind Regards,
Vijay Nikam
On 2/17/09, Scott Wood wrote:
> Vijay Nikam wrote:
> > I added the gpio node as follows to mpc8313erdb.dts;
> >
> > g...@c00 {
> >linux,phandle = ;
> >
>
> Don't specify this explicitly. Please base new development off of the
> device tree that is in upstream Linux, not the very old tree in your BSP.
>
> >device_type = "gpio";
> >
>
> No device_type.
>
> > The only thing I need to know what should I write at 'compatible' tag
> > ? ? ? the compatible tag format is "manufacturer,model" the
> > manufacturer is 'fsl' i.e. I think freescale but the model, as it is
> > the model number where I can find this model ? ? ? Please let me know
> > ... thanks ...
> >
>
> compatible = "fsl,mpc8313-gpio", "fsl,mpc8349-gpio";
>
> > Also I would like to ask if the above device node is written according
> > to bindings ... I think it should be right as I referred
> > 'bootingwithout-of.txt' ... but please correct me if I am worng ? ? ?
> >
>
> See also
> Documentation/powerpc/dts-bindings/fsl/8xxx_gpio.txt.
>
> Also note that current Linux has a driver in
> arch/powerpc/sysdev/mpc8xxx_gpio.c.
>
> -Scott
>
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: Regarding irq_of_parse_and_map
Vijay Nikam wrote:
I added the gpio node as follows to mpc8313erdb.dts;
g...@c00 {
linux,phandle = ;
Don't specify this explicitly. Please base new development off of the
device tree that is in upstream Linux, not the very old tree in your BSP.
device_type = "gpio";
No device_type.
The only thing I need to know what should I write at 'compatible' tag
? ? ? the compatible tag format is "manufacturer,model" the
manufacturer is 'fsl' i.e. I think freescale but the model, as it is
the model number where I can find this model ? ? ? Please let me know
... thanks ...
compatible = "fsl,mpc8313-gpio", "fsl,mpc8349-gpio";
Also I would like to ask if the above device node is written according
to bindings ... I think it should be right as I referred
'bootingwithout-of.txt' ... but please correct me if I am worng ? ? ?
See also Documentation/powerpc/dts-bindings/fsl/8xxx_gpio.txt.
Also note that current Linux has a driver in
arch/powerpc/sysdev/mpc8xxx_gpio.c.
-Scott
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: Regarding irq_of_parse_and_map
I added the gpio node as follows to mpc8313erdb.dts;
g...@c00 {
linux,phandle = ;
device_type = "gpio";
compatible = "";
reg = ;
interrupts = <4a 8>;
interrupt-parent = <700>;
};
The only thing I need to know what should I write at 'compatible' tag
? ? ? the compatible tag format is "manufacturer,model" the
manufacturer is 'fsl' i.e. I think freescale but the model, as it is
the model number where I can find this model ? ? ? Please let me know
... thanks ...
Also I would like to ask if the above device node is written according
to bindings ... I think it should be right as I referred
'bootingwithout-of.txt' ... but please correct me if I am worng ? ? ?
If yes then I would like to confirm my further action is to compile
with dtc and create dtb and load it on the target and boot the board
... Am I Right ? ? ?
Kindly please acknowledge ... thank you ...
Following is the content of mpc8313erdb.dts to make it sure if it is
in bindings ...
### DTS ##
/* MPC8313E RDB Device Tree Source */
/ {
model = "MPC8313ERDB";
compatible = "mpc83xx";
#address-cells = <1>;
#size-cells = <1>;
cpus {
#cpus = <1>;
#address-cells = <1>;
#size-cells = <0>;
PowerPC,8...@0 {
device_type = "cpu";
reg = <0>;
d-cache-line-size = <20>; // 32 bytes
i-cache-line-size = <20>; // 32 bytes
d-cache-size = <4000>; // L1, 16K
i-cache-size = <4000>; // L1, 16K
timebase-frequency = <0>; // from bootloader
bus-frequency = <0>;// from bootloader
clock-frequency = <0>; // from bootloader
32-bit;
};
};
memory {
device_type = "memory";
reg = < 0800>; // 128MB at 0
};
nand0 {
device_type = "nand";
compatible = "fsl-nand";
linux,phandle = <301>;
reg = ;
/*partitions = "nand0:1m(u-boot)ro,3m(kernel),-(jffs2)";*/
};
soc8...@e000 {
#address-cells = <1>;
#size-cells = <1>;
#interrupt-cells = <2>;
device_type = "soc";
ranges = <0 e000 0010>;
reg = ;
bus-frequency = <0>;
w...@200 {
device_type = "watchdog";
compatible = "mpc83xx_wdt";
reg = <200 100>;
};
i...@3000 {
device_type = "i2c";
compatible = "fsl-i2c";
reg = <3000 100>;
interrupts = ;
interrupt-parent = <700>;
dfsrr;
};
i...@3100 {
device_type = "i2c";
compatible = "fsl-i2c";
reg = <3100 100>;
interrupts = ;
interrupt-parent = <700>;
dfsrr;
};
s...@7000 {
device_type = "spi";
compatible = "mpc83xx_spi";
reg = <7000 1000>;
interrupts = <10 8>;
interrupt-parent = <700>;
mode = <0>;
};
/* phy type (ULPI, UTMI, UTMI_WIDE, SERIAL) */
u...@23000 {
device_type = "usb";
compatible = "fsl-usb2-dr";
reg = <23000 1000>;
#address-cells = <1>;
#size-cells = <0>;
interrupt-parent = <700>;
interrupts = <26 2>;
phy_type = "utmi_wide";
control_init = <0280>; // UTMI ext 48 MHz clk
sleep = ;
};
m...@24520 {
device_type = "mdio";
compatible = "gianfar";
reg = <24520 20>;
#address-cells = <1>;
#size-cells = <0>;
linux,phandle = <24520>;
ethernet-...@1 {
linux,phandle = <2452001>;
interrupt-parent = <700>;
interrupts = <13 2>;
reg = <1>;
device_type = "ether
Re: Regarding irq_of_parse_and_map
On Mon, Feb 16, 2009 at 05:25:23PM +0530, Vijay Nikam wrote: > 2. Also I would like to ask how I can determine the virtual irq using > irq_of_parse_and_map (struct device_node *dev, int index) ? ? ? > > here I am not getting what I should pass *dev and index ? ? ? as in my > mpc8313erdb.dts I could not find any node name 'gpio' so I do not know > what I can use ... You'd need to add a gpio node to the device tree. If you do this, be sure to follow existing bindings. > > Kindly please acknowledge ... thank you ... > > Following is the content of mpc8313erdb.dts That device tree looks very old, as if it came from a BSP rather than upstream Linux. -Scott ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
