RE: Request_irq fails for IRQ2
On Tue, 2011-10-04 at 11:21 +, smitha.va...@wipro.com wrote: Hi Scott, I am able to register the IRQ now once I add the call irq_set_default_host in cpm2_pic. This is a band-aid at best and will probably not be accepted upstream. You should -really- describe your interrupt in the device-tree instead. Ben. But when I call enable_irq the code throws the below warning and gives exception in enable irq at spin_unlock_irqrestore(desc-lock, flags); in enable_irq. printk(KERN_WARNING Unbalanced enable for IRQ %d\n, irq); Regards, Smitha Please do not print this email unless it is absolutely necessary. The information contained in this electronic message and any attachments to this message are intended for the exclusive use of the addressee(s) and may contain proprietary, confidential or privileged information. If you are not the intended recipient, you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately and destroy all copies of this message and any attachments. WARNING: Computer viruses can be transmitted via email. The recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email. www.wipro.com ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
RE: Request_irq fails for IRQ2
On Tue, 2011-10-04 at 13:55 +, smitha.va...@wipro.com wrote:
Hi Scoot,
When I try to use a atomic varaible in my ISR I see a kernel crash .
with mesage BUG: scheduling while atomic:
Below is the code :
My ISR
irqreturn_t cpld_irq_handler(int irq, void * dev_id, struct pt_regs
*regs)
{
wake_up(cpld_intr_wait);
atomic_inc(cpld_intr_data); /* incrementing this will indicate the
poll() that the interrupt is occured */
return 0;
}
This is of course completely racy, you should do the increment -before-
you wake up. I suppose you aren't SMP at the moment but even then, if
you ever switch for example to threaded interrupts or use RT it will
potentially break.
DRIVER_INIT
static int __init gpio_init(void)
{
int ret = 0;
int virq;
atomic_set(cpld_intr_data, 0); /* initialize
the Interrupt indicator */
init_waitqueue_head(cpld_intr_wait); /* Initialize
the wait queue */
virq = irq_create_mapping(NULL, CPLD1_INTERRUPT);
See comments earlier about using the device-tree here.
if ((ret = request_irq(virq,cpld_irq_handler, 0, GPIO_CHAR_PATH,
NULL))!=0)
{
printk(KERN_ERR gpio_init: Could not grab IRQ line for CPLD ret
= %d\n,ret);
goto err1;
}
if((s_nGPIOMajor = register_chrdev(MPC8247_DEVICE_MAJOR_NUM,
GPIO_CHAR_PATH, gpio_fops))0)
{
GPIO_DBG2(GPIO_DRIVER : unable to get major %d\n,
s_nGPIOMajor);
return s_nGPIOMajor;
}else{
GPIO_DBG2(GPIO_DRIVER : major = %x\n, s_nGPIOMajor
);
}
coding style FAIL
return 0;
}
I don't see anything that does your scheduling while atomic here,
probably a bug in your poll implementation but it's not here.
Oh and stop sending that crap:
Regards,
Smitha
Please do not print this email unless it is absolutely necessary.
The information contained in this electronic message and any
attachments to this message are intended for the exclusive use of the
addressee(s) and may contain proprietary, confidential or privileged
information. If you are not the intended recipient, you should not
disseminate, distribute or copy this e-mail. Please notify the sender
immediately and destroy all copies of this message and any
attachments.
WARNING: Computer viruses can be transmitted via email. The recipient
should check this email and any attachments for the presence of
viruses. The company accepts no liability for any damage caused by any
virus transmitted by this email.
It's a complete nonsense on a public mailing list
Ben.
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
RE: Request_irq fails for IRQ2
Hi Scott, Thank you. But I am not very clear where exactly I need to call the irq_set_default_host(). And also for the second fix I did not understand or to make cpm2_pic_host non-static (in which case you should pass that). in th previous mail what exactlyy you mean. Thanks Regards, Smitha Please do not print this email unless it is absolutely necessary. The information contained in this electronic message and any attachments to this message are intended for the exclusive use of the addressee(s) and may contain proprietary, confidential or privileged information. If you are not the intended recipient, you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately and destroy all copies of this message and any attachments. WARNING: Computer viruses can be transmitted via email. The recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email. www.wipro.com ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: Request_irq fails for IRQ2
Smitha,
Do you have the entry of this device node in your DTS file?
if yes, then is the device is getting registered properly?
If you are writing platform driver then you can use 'platform_get_irq'
it returns the irq number,
which you can pass in the 'request_irq'. If it is a simple character
driver then to determine the
virtual irq number you can use 'ioremap', in this call you can pass
the HW IRQ number e.g. 20
and then pass in the 'request_irq'.
But in both cases you have to have this device node in your device
tree and should be registered,
otherwise it should be returning error and no virtual irq will be allocated.
As per your return value it seems the device node is not getting
registered, perhaps the entry is
missing in DTS file. Try with just ioremap and see if virtual irq is
returned properly.
Kind Regards,
Vijay Nikam
On Mon, Oct 3, 2011 at 7:57 PM, smitha.va...@wipro.com wrote:
Hi Scott,
I try to request an IRQ (IRQ2 and IRQ3 which are ineterrupt no 20 and 21 in
mpc8247)in my driver . The
Call fails in setup_irq in Manage.c at /kernel/irq.
Setup _irq returns -ENOSYS
if (desc-irq_data.chip == no_irq_chip)
return -ENOSYS;
I found that I need to pass the virtual interrupt number instead of hardware
interrupt number.
So I added below piece of code
Below is the call to request irq in my driver.
virq = irq_create_mapping(NULL, CPLD1_INTERRUPT);
if ((ret = request_irq(virq,cpld_irq_handler, 0, GPIO_CHAR_PATH,
NULL))!=0)
{
printk(KERN_ERR gpio_init: Could not grab IRQ line for CPLD ret =
%d\n,ret);
goto err1;
}
Now it fails in irq_create_mapping with NO_IRQ error.
if (controller == NULL)
host = irq_default_host;
else
host = irq_find_host(controller);
if (host == NULL) {
printk(KERN_WARNING irq: no irq host found for %s !\n,
controller-full_name);
return NO_IRQ;
}
I just don't know what I should pass for host , also when I pass NULL for
host . I see the default host is NULL..
Could you please help me. My project delivery is near , I need help soon.
Regards,
Smitha
Please do not print this email unless it is absolutely necessary.
The information contained in this electronic message and any attachments to
this message are intended for the exclusive use of the addressee(s) and may
contain proprietary, confidential or privileged information. If you are not
the intended recipient, you should not disseminate, distribute or copy this
e-mail. Please notify the sender immediately and destroy all copies of this
message and any attachments.
WARNING: Computer viruses can be transmitted via email. The recipient should
check this email and any attachments for the presence of viruses. The
company accepts no liability for any damage caused by any virus transmitted
by this email.
www.wipro.com
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
RE: Request_irq fails for IRQ2
Hi Scott, I am able to register the IRQ now once I add the call irq_set_default_host in cpm2_pic. But when I call enable_irq the code throws the below warning and gives exception in enable irq at spin_unlock_irqrestore(desc-lock, flags); in enable_irq. printk(KERN_WARNING Unbalanced enable for IRQ %d\n, irq); Regards, Smitha Please do not print this email unless it is absolutely necessary. The information contained in this electronic message and any attachments to this message are intended for the exclusive use of the addressee(s) and may contain proprietary, confidential or privileged information. If you are not the intended recipient, you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately and destroy all copies of this message and any attachments. WARNING: Computer viruses can be transmitted via email. The recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email. www.wipro.com ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: Request_irq fails for IRQ2
On 10/04/2011 06:21 AM, smitha.va...@wipro.com wrote: Hi Scott, I am able to register the IRQ now once I add the call irq_set_default_host in cpm2_pic. But when I call enable_irq the code throws the below warning and gives exception in enable irq at spin_unlock_irqrestore(desc-lock, flags); in enable_irq. printk(KERN_WARNING Unbalanced enable for IRQ %d\n, irq); The IRQ is automatically enabled when you request it. Only call enable_irq() if you previously called disable_irq(). -Scott ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
RE: Request_irq fails for IRQ2
Hi Scoot,
When I try to use a atomic varaible in my ISR I see a kernel crash . with
mesage BUG: scheduling while atomic:
Below is the code :
My ISR
irqreturn_t cpld_irq_handler(int irq, void * dev_id, struct pt_regs *regs)
{
wake_up(cpld_intr_wait);
atomic_inc(cpld_intr_data); /* incrementing this will indicate the poll() that
the interrupt is occured */
return 0;
}
DRIVER_INIT
static int __init gpio_init(void)
{
int ret = 0;
int virq;
atomic_set(cpld_intr_data, 0); /* initialize the
Interrupt indicator */
init_waitqueue_head(cpld_intr_wait); /* Initialize the wait
queue */
virq = irq_create_mapping(NULL, CPLD1_INTERRUPT);
if ((ret = request_irq(virq,cpld_irq_handler, 0, GPIO_CHAR_PATH, NULL))!=0)
{
printk(KERN_ERR gpio_init: Could not grab IRQ line for CPLD ret =
%d\n,ret);
goto err1;
}
if((s_nGPIOMajor = register_chrdev(MPC8247_DEVICE_MAJOR_NUM,
GPIO_CHAR_PATH, gpio_fops))0)
{
GPIO_DBG2(GPIO_DRIVER : unable to get major %d\n,
s_nGPIOMajor);
return s_nGPIOMajor;
}else{
GPIO_DBG2(GPIO_DRIVER : major = %x\n, s_nGPIOMajor );
}
return 0;
}
Regards,
Smitha
Please do not print this email unless it is absolutely necessary.
The information contained in this electronic message and any attachments to
this message are intended for the exclusive use of the addressee(s) and may
contain proprietary, confidential or privileged information. If you are not the
intended recipient, you should not disseminate, distribute or copy this e-mail.
Please notify the sender immediately and destroy all copies of this message and
any attachments.
WARNING: Computer viruses can be transmitted via email. The recipient should
check this email and any attachments for the presence of viruses. The company
accepts no liability for any damage caused by any virus transmitted by this
email.
www.wipro.com
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Request_irq fails for IRQ2
Hi Scott,
I try to request an IRQ (IRQ2 and IRQ3 which are ineterrupt no 20 and 21 in
mpc8247)in my driver . The
Call fails in setup_irq in Manage.c at /kernel/irq.
Setup _irq returns -ENOSYS
if (desc-irq_data.chip == no_irq_chip)
return -ENOSYS;
I just want to know why it fails. Below is the call to request irq in my driver.
#define CPLD1_INTERRUPT 20
if (request_irq(CPLD1_INTERRUPT,cpld_irq_handler, 0, GPIO_CHAR_PATH, NULL))
{
printk(KERN_ERR gpio_init: Could not grab IRQ line for CPLD\n);
goto err1;
}
Regards,
Smitha
Please do not print this email unless it is absolutely necessary.
The information contained in this electronic message and any attachments to
this message are intended for the exclusive use of the addressee(s) and may
contain proprietary, confidential or privileged information. If you are not the
intended recipient, you should not disseminate, distribute or copy this e-mail.
Please notify the sender immediately and destroy all copies of this message and
any attachments.
WARNING: Computer viruses can be transmitted via email. The recipient should
check this email and any attachments for the presence of viruses. The company
accepts no liability for any damage caused by any virus transmitted by this
email.
www.wipro.com
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: Request_irq fails for IRQ2
On 10/03/2011 09:27 AM, smitha.va...@wipro.com wrote: I just don't know what I should pass for host , also when I pass NULL for host . I see the default host is NULL.. Could you please help me. My project delivery is near , I need help soon. Ideally you should just use the device tree to describe this device, then you wouldn't have to deal with finding the pointer to the controller. Otherwise, modify the cpm2_pic driver to either call irq_set_default_host() (in which case NULL should work) or to make cpm2_pic_host non-static (in which case you should pass that). -Scott ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
RE: Request_irq fails for IRQ2
Hi Scott,
I try to request an IRQ (IRQ2 and IRQ3 which are ineterrupt no 20 and 21 in
mpc8247)in my driver . The
Call fails in setup_irq in Manage.c at /kernel/irq.
Setup _irq returns -ENOSYS
if (desc-irq_data.chip == no_irq_chip)
return -ENOSYS;
I found that I need to pass the virtual interrupt number instead of hardware
interrupt number.
So I added below piece of code
Below is the call to request irq in my driver.
virq = irq_create_mapping(NULL, CPLD1_INTERRUPT);
if ((ret = request_irq(virq,cpld_irq_handler, 0, GPIO_CHAR_PATH, NULL))!=0)
{
printk(KERN_ERR gpio_init: Could not grab IRQ line for CPLD ret =
%d\n,ret);
goto err1;
}
Now it fails in irq_create_mapping with NO_IRQ error.
if (controller == NULL)
host = irq_default_host;
else
host = irq_find_host(controller);
if (host == NULL) {
printk(KERN_WARNING irq: no irq host found for %s !\n,
controller-full_name);
return NO_IRQ;
}
I just don't know what I should pass for host , also when I pass NULL for host
. I see the default host is NULL..
Could you please help me. My project delivery is near , I need help soon.
Regards,
Smitha
Please do not print this email unless it is absolutely necessary.
The information contained in this electronic message and any attachments to
this message are intended for the exclusive use of the addressee(s) and may
contain proprietary, confidential or privileged information. If you are not the
intended recipient, you should not disseminate, distribute or copy this e-mail.
Please notify the sender immediately and destroy all copies of this message and
any attachments.
WARNING: Computer viruses can be transmitted via email. The recipient should
check this email and any attachments for the presence of viruses. The company
accepts no liability for any damage caused by any virus transmitted by this
email.
www.wipro.com
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
