Re: dtc: Fix summary calculation in testsuite

2007-08-30 Thread Jon Loeliger
So, like, the other day David Gibson mumbled:
> The bookkeeping for producing the testsuite summary (total number of
> tests passed, failed and so forth) is broken.  It uses $? across
> several tests, but for checks after the first, the value of $? will no
> longer contain the original return code, but just that from the
> previous test.  This patch fixes the problem.
> 
> Signed-off-by: David Gibson <[EMAIL PROTECTED]>

Applied.

Thanks,
jdl
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


dtc: Fix summary calculation in testsuite

2007-08-28 Thread David Gibson
The bookkeeping for producing the testsuite summary (total number of
tests passed, failed and so forth) is broken.  It uses $? across
several tests, but for checks after the first, the value of $? will no
longer contain the original return code, but just that from the
previous test.  This patch fixes the problem.

Signed-off-by: David Gibson <[EMAIL PROTECTED]>

Index: dtc/tests/run_tests.sh
===
--- dtc.orig/tests/run_tests.sh 2007-08-29 12:04:11.0 +1000
+++ dtc/tests/run_tests.sh  2007-08-29 12:04:37.0 +1000
@@ -15,12 +15,15 @@
 echo -n "$@:   "
 if PATH=".:$PATH" $ENV "$@"; then
tot_pass=$[tot_pass + 1]
-elif [ "$?" == "1" ]; then
-   tot_config=$[tot_config + 1]
-elif [ "$?" == "2" ]; then
-   tot_fail=$[tot_fail + 1]
 else
-   tot_strange=$[tot_strange + 1]
+   ret="$?"
+   if [ "$ret" == "1" ]; then
+   tot_config=$[tot_config + 1]
+   elif [ "$ret" == "2" ]; then
+   tot_fail=$[tot_fail + 1]
+   else
+   tot_strange=$[tot_strange + 1]
+   fi
 fi
 }
 

-- 
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev