Re: linux-next: build failure after merge of the tip tree
Stephen Rothwell writes:
> Hi all,
>
> After merging the tip tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> arch/powerpc/lib/code-patching.c: In function 'text_area_cpu_up_mm':
> arch/powerpc/lib/code-patching.c:157:14: error: implicit declaration of
> function 'copy_init_mm' [-Werror=implicit-function-declaration]
> 157 | mm = copy_init_mm();
> | ^~~~
>
> Caused by commit
>
> 107b6828a7cd ("x86/mm: Use mm_alloc() in poking_init()")
>
> interacting with commit
>
> 55a02e6ea958 ("powerpc/code-patching: Use temporary mm for Radix MMU")
>
> from the powerpc tree.
>
> I partially reverted commit 107b6828a7cd - I left the change to
> arch/x86/mm/init.c applied. Though, I wonder if the powerpc tree should
> use mm_alloc() instead of copy_init_mm() as well? The tip tree commit
> says:
>
> Instead of duplicating init_mm, allocate a fresh mm. The advantage is
> that mm_alloc() has much simpler dependencies. Additionally it makes
> more conceptual sense, init_mm has no (and must not have) user state
> to duplicate.
I needed to rebase my next anyway, so I've squashed in a change to use
mm_alloc() in the powerpc commit. So this issue will be gone on Monday.
cheers
Re: linux-next: build failure after merge of the tip tree
On Fri, 2022-12-02 at 11:26 +1100, Stephen Rothwell wrote: > Though, I wonder if the powerpc tree should > use mm_alloc() instead of copy_init_mm() as well? The tip tree > commit > says: > > Instead of duplicating init_mm, allocate a fresh mm. The > advantage is > that mm_alloc() has much simpler dependencies. Additionally it > makes > more conceptual sense, init_mm has no (and must not have) user > state > to duplicate. > Yes, that seems fine. All we need is that the page table isn't shared and the kernel mappings are the same as in init_mm. It seems mm_alloc() does this at some point.
linux-next: build failure after merge of the tip tree
Hi all,
After merging the tip tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
arch/powerpc/lib/code-patching.c: In function 'text_area_cpu_up_mm':
arch/powerpc/lib/code-patching.c:157:14: error: implicit declaration of
function 'copy_init_mm' [-Werror=implicit-function-declaration]
157 | mm = copy_init_mm();
| ^~~~
Caused by commit
107b6828a7cd ("x86/mm: Use mm_alloc() in poking_init()")
interacting with commit
55a02e6ea958 ("powerpc/code-patching: Use temporary mm for Radix MMU")
from the powerpc tree.
I partially reverted commit 107b6828a7cd - I left the change to
arch/x86/mm/init.c applied. Though, I wonder if the powerpc tree should
use mm_alloc() instead of copy_init_mm() as well? The tip tree commit
says:
Instead of duplicating init_mm, allocate a fresh mm. The advantage is
that mm_alloc() has much simpler dependencies. Additionally it makes
more conceptual sense, init_mm has no (and must not have) user state
to duplicate.
--
Cheers,
Stephen Rothwell
pgp3WNyp_rAsc.pgp
Description: OpenPGP digital signature
Re: linux-next: build failure after merge of the tip tree
On Mon, Mar 30, 2020 at 1:17 AM Borislav Petkov wrote: > > On Mon, Mar 30, 2020 at 07:04:16PM +1100, Michael Ellerman wrote: > > Or just squash the hunk Stephen posted into the commit, which is what I > > thought would happen to begin with. > > > > You can have my ack for it: > > > > Acked-by: Michael Ellerman (powerpc) > > Thanks but considering how this is not really urgent stuff and it can > take its time and get some wider testing before getting upstream, I'd > prefer to delay it. Skip my commit will also delay other commits since they depend on my commit. -- H.J.
Re: linux-next: build failure after merge of the tip tree
On Mon, Mar 30, 2020 at 07:04:16PM +1100, Michael Ellerman wrote: > Or just squash the hunk Stephen posted into the commit, which is what I > thought would happen to begin with. > > You can have my ack for it: > > Acked-by: Michael Ellerman (powerpc) Thanks but considering how this is not really urgent stuff and it can take its time and get some wider testing before getting upstream, I'd prefer to delay it. -- Regards/Gruss, Boris. SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
Re: linux-next: build failure after merge of the tip tree
Borislav Petkov writes: > On Mon, Mar 30, 2020 at 03:08:19PM +1100, Stephen Rothwell wrote: >> What you really need is an Ack from the PowerPC people for the fix you >> suggested and then tha fix should go in the same series that is now >> causing the failure (preferably before the problematic (for PowerPC) >> patch. > > I'll zap this commit from the tip lineup. There's always another merge > window. Or just squash the hunk Stephen posted into the commit, which is what I thought would happen to begin with. You can have my ack for it: Acked-by: Michael Ellerman (powerpc) cheers
Re: linux-next: build failure after merge of the tip tree
On Mon, Mar 30, 2020 at 03:08:19PM +1100, Stephen Rothwell wrote: > What you really need is an Ack from the PowerPC people for the fix you > suggested and then tha fix should go in the same series that is now > causing the failure (preferably before the problematic (for PowerPC) > patch. I'll zap this commit from the tip lineup. There's always another merge window. -- Regards/Gruss, Boris. SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
Re: linux-next: build failure after merge of the tip tree
Hi H.J.,
On Sun, 29 Mar 2020 20:53:42 -0700 "H.J. Lu" wrote:
>
> Please see my enclosing email. Is anyone from PPC community reading emails?
What you really need is an Ack from the PowerPC people for the fix you
suggested and then tha fix should go in the same series that is now
causing the failure (preferably before the problematic (for PowerPC)
patch.
For reference, the change is (white space damaged):
diff --git a/arch/powerpc/kernel/vmlinux.lds.S
b/arch/powerpc/kernel/vmlinux.lds.S
index b4c89a1acebb..076b3e8a849d 100644
--- a/arch/powerpc/kernel/vmlinux.lds.S
+++ b/arch/powerpc/kernel/vmlinux.lds.S
@@ -365,9 +365,12 @@ SECTIONS
DISCARDS
/DISCARD/ : {
*(*.EMB.apuinfo)
- *(.glink .iplt .plt .rela* .comment)
+ *(.glink .iplt .plt .comment)
*(.gnu.version*)
*(.gnu.attributes)
*(.eh_frame)
+#ifndef CONFIG_RELOCATABLE
+ *(.rela*)
+#endif
}
}
--
Cheers,
Stephen Rothwell
pgpRDnjg8B0lk.pgp
Description: OpenPGP digital signature
linux-next: build failure after merge of the tip tree
Hi all, After merging the tip tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: arch/powerpc/perf/power7-pmu.c:397:2: error: initialization from incompatible pointer type [-Werror] arch/powerpc/perf/power7-pmu.c:397:2: error: (near initialization for 'power7_events_attr[0]') [-Werror] arch/powerpc/perf/power7-pmu.c:398:2: error: initialization from incompatible pointer type [-Werror] arch/powerpc/perf/power7-pmu.c:398:2: error: (near initialization for 'power7_events_attr[1]') [-Werror] arch/powerpc/perf/power7-pmu.c:399:2: error: initialization from incompatible pointer type [-Werror] arch/powerpc/perf/power7-pmu.c:399:2: error: (near initialization for 'power7_events_attr[2]') [-Werror] arch/powerpc/perf/power7-pmu.c:400:2: error: initialization from incompatible pointer type [-Werror] arch/powerpc/perf/power7-pmu.c:400:2: error: (near initialization for 'power7_events_attr[3]') [-Werror] arch/powerpc/perf/power7-pmu.c:401:2: error: initialization from incompatible pointer type [-Werror] arch/powerpc/perf/power7-pmu.c:401:2: error: (near initialization for 'power7_events_attr[4]') [-Werror] arch/powerpc/perf/power7-pmu.c:402:2: error: initialization from incompatible pointer type [-Werror] arch/powerpc/perf/power7-pmu.c:402:2: error: (near initialization for 'power7_events_attr[5]') [-Werror] arch/powerpc/perf/power7-pmu.c:403:2: error: initialization from incompatible pointer type [-Werror] arch/powerpc/perf/power7-pmu.c:403:2: error: (near initialization for 'power7_events_attr[6]') [-Werror] arch/powerpc/perf/power7-pmu.c:404:2: error: initialization from incompatible pointer type [-Werror] arch/powerpc/perf/power7-pmu.c:404:2: error: (near initialization for 'power7_events_attr[7]') [-Werror] arch/powerpc/perf/power7-pmu.c:406:2: error: initialization from incompatible pointer type [-Werror] arch/powerpc/perf/power7-pmu.c:406:2: error: (near initialization for 'power7_events_attr[8]') [-Werror] arch/powerpc/perf/power7-pmu.c:407:2: error: initialization from incompatible pointer type [-Werror] arch/powerpc/perf/power7-pmu.c:407:2: error: (near initialization for 'power7_events_attr[9]') [-Werror] arch/powerpc/perf/power7-pmu.c:408:2: error: initialization from incompatible pointer type [-Werror] arch/powerpc/perf/power7-pmu.c:408:2: error: (near initialization for 'power7_events_attr[10]') [-Werror] arch/powerpc/perf/power7-pmu.c:409:2: error: initialization from incompatible pointer type [-Werror] arch/powerpc/perf/power7-pmu.c:409:2: error: (near initialization for 'power7_events_attr[11]') [-Werror] arch/powerpc/perf/power7-pmu.c:410:2: error: initialization from incompatible pointer type [-Werror] arch/powerpc/perf/power7-pmu.c:410:2: error: (near initialization for 'power7_events_attr[12]') [-Werror] arch/powerpc/perf/power7-pmu.c:411:2: error: initialization from incompatible pointer type [-Werror] arch/powerpc/perf/power7-pmu.c:411:2: error: (near initialization for 'power7_events_attr[13]') [-Werror] arch/powerpc/perf/power7-pmu.c:412:2: error: initialization from incompatible pointer type [-Werror] arch/powerpc/perf/power7-pmu.c:412:2: error: (near initialization for 'power7_events_attr[14]') [-Werror] arch/powerpc/perf/power7-pmu.c:413:2: error: initialization from incompatible pointer type [-Werror] arch/powerpc/perf/power7-pmu.c:413:2: error: (near initialization for 'power7_events_attr[15]') [-Werror] Caused by commit 1c53a270724d (perf/POWER7: Make generic event translations available in sysfs). I have used the tip tree from 20130128 for today. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgp3Y5G9XwCFF.pgp Description: PGP signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
