Re: powerpc/pseries/mce: Improve array initialization.

2019-04-21 Thread Michael Ellerman
On Thu, 2019-03-28 at 11:40:33 UTC, Mahesh J Salgaonkar wrote:
> From: Mahesh Salgaonkar 
> 
> This is a follow up to the patch that fixed misleading print for TLB
> mutlihit due to wrongly populated mc_err_types[] array. Convert all the
> static array initialization to '[x] = val' style for better
> readability of array indexing and avoid any further confusion.
> 
> Suggested-by: Michael Ellerman 
> Signed-off-by: Mahesh Salgaonkar 

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/c9d8dda42372dce00ac3a1c653bef7b8

cheers


[PATCH] powerpc/pseries/mce: Improve array initialization.

2019-03-28 Thread Mahesh J Salgaonkar
From: Mahesh Salgaonkar 

This is a follow up to the patch that fixed misleading print for TLB
mutlihit due to wrongly populated mc_err_types[] array. Convert all the
static array initialization to '[x] = val' style for better
readability of array indexing and avoid any further confusion.

Suggested-by: Michael Ellerman 
Signed-off-by: Mahesh Salgaonkar 
---
 arch/powerpc/platforms/pseries/ras.c |   52 +-
 1 file changed, 26 insertions(+), 26 deletions(-)

diff --git a/arch/powerpc/platforms/pseries/ras.c 
b/arch/powerpc/platforms/pseries/ras.c
index 452dcfd7e5dd..a25c2ac0c9c0 100644
--- a/arch/powerpc/platforms/pseries/ras.c
+++ b/arch/powerpc/platforms/pseries/ras.c
@@ -539,44 +539,44 @@ static void pseries_print_mce_info(struct pt_regs *regs,
int disposition = rtas_error_disposition(errp);
 
static const char * const initiators[] = {
-   "Unknown",
-   "CPU",
-   "PCI",
-   "ISA",
-   "Memory",
-   "Power Mgmt",
+   [0] = "Unknown",
+   [1] = "CPU",
+   [2] = "PCI",
+   [3] = "ISA",
+   [4] = "Memory",
+   [5] = "Power Mgmt",
};
static const char * const mc_err_types[] = {
-   "UE",
-   "SLB",
-   "ERAT",
-   "Unknown",
-   "TLB",
-   "D-Cache",
-   "Unknown",
-   "I-Cache",
+   [0] = "UE",
+   [1] = "SLB",
+   [2] = "ERAT",
+   [3] = "Unknown",
+   [4] = "TLB",
+   [5] = "D-Cache",
+   [6] = "Unknown",
+   [7] = "I-Cache",
};
static const char * const mc_ue_types[] = {
-   "Indeterminate",
-   "Instruction fetch",
-   "Page table walk ifetch",
-   "Load/Store",
-   "Page table walk Load/Store",
+   [0] = "Indeterminate",
+   [1] = "Instruction fetch",
+   [2] = "Page table walk ifetch",
+   [3] = "Load/Store",
+   [4] = "Page table walk Load/Store",
};
 
/* SLB sub errors valid values are 0x0, 0x1, 0x2 */
static const char * const mc_slb_types[] = {
-   "Parity",
-   "Multihit",
-   "Indeterminate",
+   [0] = "Parity",
+   [1] = "Multihit",
+   [2] = "Indeterminate",
};
 
/* TLB and ERAT sub errors valid values are 0x1, 0x2, 0x3 */
static const char * const mc_soft_types[] = {
-   "Unknown",
-   "Parity",
-   "Multihit",
-   "Indeterminate",
+   [0] = "Unknown",
+   [1] = "Parity",
+   [2] = "Multihit",
+   [3] = "Indeterminate",
};
 
if (!rtas_error_extended(errp)) {