Re: powerpc/xmon: don't access ASDR in VMs
On Tue, 2020-01-07 at 02:16:33 UTC, Sukadev Bhattiprolu wrote: > >From 91a77dbea3c909ff15c66cded37f1334304a293d Mon Sep 17 00:00:00 2001 > From: Sukadev Bhattiprolu > Date: Mon, 6 Jan 2020 13:50:02 -0600 > Subject: [PATCH 1/1] powerpc/xmon: don't access ASDR in VMs > > ASDR is HV-privileged and must only be accessed in HV-mode. > Fixes a Program Check (0x700) when xmon in a VM dumps SPRs. > > Signed-off-by: Sukadev Bhattiprolu Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/c2a20711fc181e7f22ee5c16c28cb9578af84729 cheers
Re: powerpc/xmon: don't access ASDR in VMs
On 7/1/20 1:16 pm, Sukadev Bhattiprolu wrote: From 91a77dbea3c909ff15c66cded37f1334304a293d Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Mon, 6 Jan 2020 13:50:02 -0600 Subject: [PATCH 1/1] powerpc/xmon: don't access ASDR in VMs ASDR is HV-privileged and must only be accessed in HV-mode. Fixes a Program Check (0x700) when xmon in a VM dumps SPRs. Signed-off-by: Sukadev Bhattiprolu I think this should be: Fixes: d1e1b351f50f9 ("powerpc/xmon: Add ISA v3.0 SPRs to SPR dump") Cc: sta...@vger.kernel.org Apart from that Reviewed-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited
powerpc/xmon: don't access ASDR in VMs
>From 91a77dbea3c909ff15c66cded37f1334304a293d Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Mon, 6 Jan 2020 13:50:02 -0600 Subject: [PATCH 1/1] powerpc/xmon: don't access ASDR in VMs ASDR is HV-privileged and must only be accessed in HV-mode. Fixes a Program Check (0x700) when xmon in a VM dumps SPRs. Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/xmon/xmon.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c index 02fae453c2ec..b8d179b5cf4f 100644 --- a/arch/powerpc/xmon/xmon.c +++ b/arch/powerpc/xmon/xmon.c @@ -1949,15 +1949,14 @@ static void dump_300_sprs(void) printf("pidr = %.16lx tidr = %.16lx\n", mfspr(SPRN_PID), mfspr(SPRN_TIDR)); - printf("asdr = %.16lx psscr = %.16lx\n", - mfspr(SPRN_ASDR), hv ? mfspr(SPRN_PSSCR) - : mfspr(SPRN_PSSCR_PR)); + printf("psscr = %.16lx\n", + hv ? mfspr(SPRN_PSSCR) : mfspr(SPRN_PSSCR_PR)); if (!hv) return; - printf("ptcr = %.16lx\n", - mfspr(SPRN_PTCR)); + printf("ptcr = %.16lx asdr = %.16lx\n", + mfspr(SPRN_PTCR), mfspr(SPRN_ASDR)); #endif } -- 2.17.2