[2.6.24 patch] Fix Cell OProfile support
This patch restores the Cell OProfile support that was killed by commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9. It puts it in arch/powerpc/Kconfig. Since I don't see any good reason to leave this as a supplementary user-selectable option, it is now automatically enabled whenever SPU_FS and OPROFILE are enabled. Signed-off-by: Mathieu Desnoyers [EMAIL PROTECTED] CC: Adrian Bunk [EMAIL PROTECTED] CC: Randy Dunlap [EMAIL PROTECTED] CC: [EMAIL PROTECTED] CC: [EMAIL PROTECTED] CC: linuxppc-dev@ozlabs.org CC: [EMAIL PROTECTED] --- arch/powerpc/Kconfig |4 1 file changed, 4 insertions(+) Index: linux-2.6-lttng/arch/powerpc/Kconfig === --- linux-2.6-lttng.orig/arch/powerpc/Kconfig 2007-12-28 17:00:24.0 -0500 +++ linux-2.6-lttng/arch/powerpc/Kconfig2007-12-28 17:00:39.0 -0500 @@ -163,6 +163,10 @@ config PPC_OF_PLATFORM_PCI depends on PPC64 # not supported on 32 bits yet default n +config OPROFILE_CELL + def_bool y + depends on (SPU_FS = y OPROFILE = m) || (SPU_FS = y OPROFILE = y) + source init/Kconfig source arch/powerpc/platforms/Kconfig -- Mathieu Desnoyers Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
RE: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layerfunctionality
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] abs.org] On Behalf Of Vitaly Bordug Sent: den 6 december 2007 23:51 To: Paul Mackerras Cc: [EMAIL PROTECTED]; linuxppc-dev Subject: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layerfunctionality With that patch fixed.c now fully emulates MDIO bus, thus no need to duplicate PHY layer functionality. That, in turn, drastically simplifies the code, and drops down line count. As an additional bonus, now there is no need to register MDIO bus for each PHY, all emulated PHYs placed on the platform fixed MDIO bus. There is also no more need to pre-allocate PHYs via .config option, this is all now handled dynamically. Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] Signed-off-by: Vitaly Bordug [EMAIL PROTECTED] Acked-by: Jeff Garzik [EMAIL PROTECTED] What happened to this patch set? Is it sitting in a tree somewhere waiting for 2.4.25 or does it need more work? Jocke ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Please pull from 'for-2.6.25' branch of 4xx tree
Hi Paul, Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/jwboyer/powerpc-4xx.git for-2.6.25 to pick up the current 4xx patches for 2.6.25. There is a large PCI port from Ben, some new board ports from Stefan, Valentine and Hugh, and a handful of various fixes. The total diff stat is large, but a lot of it comes from new DTS and defconfig files. josh Benjamin Herrenschmidt (19): [POWERPC] Reworking machine check handling and Fix 440/440A [POWERPC] 4xx: Improve support for 4xx indirect DCRs [POWERPC] 4xx: PLB to PCI-X support [POWERPC] 4xx: PLB to PCI 2.x support [POWERPC] 4xx: PLB to PCI Express support [POWERPC] 4xx: PCI support for Ebony board [POWERPC] 4xx: Add early udbg support for 40x processors [POWERPC] 4xx: EP405 boards support for arch/powerpc [POWERPC] 4xx: Add PCI to Walnut platform [POWERPC] 4xx: Wire up PCI on Bamboo board [POWERPC] 4xx: Wire up 440EP USB controller support to Bamboo board [POWERPC] 4xx: Adds decoding of 440SPE memory size to boot wrapper library [POWERPC] 4xx: Add mfspr/mtspr inline macros to 4xx bootwrapper [POWERPC] 4xx: Add CPR0 accessors to boot wrapper [POWERPC] 4xx: Rework clock probing in boot wrapper [POWERPC] 4xx: Base support for 440SPe Katmai eval board [POWERPC] 4xx: remove bogus ranges property in Bamboo EBC node [POWERPC] 4xx: PCI-E Link setup improvements [POWERPC] pci32: 4xx embedded platforms want to reassign all PCI resources Hugh Blemings (1): [POWERPC] 4xx: Base support for 440GX Taishan eval board Josh Boyer (11): [POWERPC] 4xx: Fix 440grx setup function to call 440A fixup [POWERPC] 4xx: Include missing header [POWERPC] 4xx: libfdt and pci fixes for Rainier [POWERPC] 4xx: Rename CPU nodes to avoid dtc incompatibility [POWERPC] 4xx: Update Kilauea, Rainier, and Walnut defconfigs [POWERPC] 4xx: Mark of_bus structures as __initdata [POWERPC] Conditionally compile e200 and e500 platforms in cputable [POWERPC] Remove unneeded variable declarations from mpc837x_mds [POWERPC] 4xx: Use machine_device_initcall for bus probe [POWERPC] 4xx: Minor coding style cleanups for 4xx bootwrapper [POWERPC] 4xx: Update defconfigs Stefan Roese (11): [POWERPC] 4xx: Add 440SPe revA runtime detection to PCIe [POWERPC] 4xx: Fix TLB 0 problem with CONFIG_SERIAL_TEXT_DEBUG [POWERPC] 4xx: Add 405EX CPU type needed for EMAC support on Kilauea [POWERPC] 4xx: Change Kilauea dts to support new EMAC device tree properti [POWERPC] 4xx: Add Kilauea PCIe support to dts and Kconfig [POWERPC] 4xx: Set ibpre for 405EX in 4xx PCIe driver [POWERPC] 4xx: Add aliases node to 4xx dts files [POWERPC] 4xx: Change Kilauea PCIe bus ranges in dts file [POWERPC] 4xx: Add AMCC Makalu board support to platforms/40x [POWERPC] 4xx: Makalu dts [POWERPC] 4xx: Makalu defconfig Valentine Barshak (12): [POWERPC] 4xx: 440EPx Sequoia USB OHCI DTS entry [POWERPC] 4xx: 440GRx Rainier bootwrapper. [POWERPC] 4xx: 440GRx Rainier DTS. [POWERPC] 4xx: 440GRx Rainier board support. [POWERPC] 4xx: 440GRx Rainier default config [POWERPC] 4xx: make UIC use generic level irq handler [POWERPC] 4xx: rework UIC cascade irq handling [POWERPC] 4xx: Correct 440GRx machine_check callback [POWERPC] 4xx: Add PCI entry to 440EPx Sequoia DTS. [POWERPC] 44x: Sequoia and Rainier updates for 2.6.25 [POWERPC] 4xx: update 440EP(x)/440GR(x) identical PVR issue workaround [POWERPC] 4xx: Add PCI entry to 440GRx Rainier DTS. arch/powerpc/Kconfig |1 + arch/powerpc/Kconfig.debug| 19 +- arch/powerpc/boot/4xx.c | 405 ++-- arch/powerpc/boot/4xx.h | 13 +- arch/powerpc/boot/Makefile| 10 +- arch/powerpc/boot/bamboo.c|4 +- arch/powerpc/boot/cuboot-katmai.c | 56 ++ arch/powerpc/boot/cuboot-rainier.c| 56 ++ arch/powerpc/boot/cuboot-sequoia.c|2 +- arch/powerpc/boot/cuboot-taishan.c| 54 + arch/powerpc/boot/dcr.h | 54 +- arch/powerpc/boot/dts/bamboo.dts | 62 ++- arch/powerpc/boot/dts/ebony.dts | 53 +- arch/powerpc/boot/dts/ep405.dts | 228 + arch/powerpc/boot/dts/katmai.dts | 400 arch/powerpc/boot/dts/kilauea.dts | 99 ++- arch/powerpc/boot/dts/makalu.dts | 347 +++ arch/powerpc/boot/dts/rainier.dts | 353 +++ arch/powerpc/boot/dts/sequoia.dts | 49 +- arch/powerpc/boot/dts/taishan.dts | 383 arch/powerpc/boot/dts/walnut.dts | 50 +- arch/powerpc/boot/ebony.c | 62 +-- arch/powerpc/boot/ep405.c | 74 ++ arch/powerpc/boot/reg.h |8 +
Re: [linux-usb-devel] [PATCH v2 3/4] USB: add Cypress c67x00 OTG controller HCD driver
On Fri, 28 Dec 2007, Grant Likely wrote:
From: Grant Likely [EMAIL PROTECTED]
This patch adds HDC support for the Cypress c67x00 family of devices.
One minor correction:
+static void c67x00_sched_done(unsigned long __c67x00)
+{
+ struct c67x00_hcd *c67x00 = (struct c67x00_hcd *)__c67x00;
+ struct c67x00_urb_priv *urbp, *tmp;
+ struct usb_hcd *hcd = c67x00_hcd_to_hcd(c67x00);
+ struct urb *urb;
+ int status;
+ unsigned long flags;
+
+ spin_lock_irqsave(c67x00-lock, flags);
+
+ /* Loop over the done list and give back all the urbs */
+ list_for_each_entry_safe(urbp, tmp, c67x00-done_list, hep_node) {
+ urb = urbp-urb;
+ status = urbp-status;
+
+ c67x00_release_urb(c67x00, urb);
+
+ usb_hcd_unlink_urb_from_ep(hcd, urb);
+
+ spin_unlock_irqrestore(c67x00-lock, flags);
+ usb_hcd_giveback_urb(hcd, urb, status);
+ spin_lock_irqsave(c67x00-lock, flags);
The giveback routine is supposed to be called with interrupts disabled.
Consequently you should use spin_unlock() and spin_lock() here, not the
_irqsave/_irqrestore variants.
+ }
+ spin_unlock_irqrestore(c67x00-lock, flags);
+}
Alan Stern
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH v2] ucc_uart: add support for Freescale QUICCEngine UART
Anton Vorontsov wrote:
+[EMAIL PROTECTED] {
+device_type = serial;
+compatible = ucc_uart;
+model = UCC;
model isn't used, is it needed at all?
I have no idea, but all the other UCC nodes have it, so I'm going to
keep it. Maybe one day we'll merge QE and CPM drivers, so this would be
useful.
+if (soft_uart) {
+struct qe_firmware_info *qe_fw_info;
+
+qe_fw_info = qe_get_firmware_info();
+
+/* Check if the firmware has been uploaded. */
+if (strstr(qe_fw_info-id, Soft-UART)) {
qe_fw_info used w/o NULL checking.
Ok.
[...]
+
+qe_port-port.irq = irq_of_parse_and_map(np, 0);
+if (qe_port-port.irq == NO_IRQ) {
+dev_err(ofdev-dev, could not map IRQ for UCC%u\n,
+ qe_port-ucc_num + 1);
+kfree(qe_port);
+return -EINVAL;
+}
+
+np = of_find_node_by_type(NULL, qe);
Please, add fsl,qe compatible matching.
Ok.
+static struct of_platform_driver ucc_uart_of_driver = {
+.owner = THIS_MODULE,
+.name = ucc_uart,
Maybe better fsl,ucc_uart?
The CPM serial driver uses cpm_uart and the QE ethernet driver uses
ucc_geth, so ucc_uart matches the pattern.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH v5] qe: add ability to upload QE firmware
On Sat, Dec 29, 2007 at 04:07:20PM -0600, Timur Tabi wrote:
Anton Vorontsov wrote:
+ firmware {
+ id = Soft-UART;
+ extended_modes = 0 0;
+ virtual_traps = 0 0 0 0 0 0 0 0;
I believe using underscores for the property name is discouraged.
Ugh, this one change would require me to repost all my patches. Oh
well. I wish someone else had noticed it before I got to version 5.
Yeah, sorry about that.
But you know it, reviewing is tedious, and only few of us are doing
reviews for the code they don't use.
I've started to use this code just now, so I reviewed it on the way.
I'll post a new version on January 7, when I get back to the office.
+A Python program that creates firmware binaries from the header files
normally
+distributed by Freescale can be found on http://opensource.freescale.com.
Hm... I didn't find it there. Could you provide more specific pointer?
I'll add those files only after my patches have been applied. The
layout may change between now and then, and I don't want to have to
repost the firmware.
+
+ /*
+ * If we haven't checked yet, and a driver hasn't uploaded a firmware
+ * yet, then check the device tree for information.
+ */
+ do {
This is very unusual method of error handling. You could stick
to gotos and lower the indentation level.
Ok, I'll change it. I wasn't crazy about it after I wrote it, anyway.
+ qe = of_find_node_by_type(NULL, qe);
Please, add compatible fsl,qe matching, so this code could
work with new device trees.
Ok, but that new design was added after I posted this patch.
+ /* Find the 'firmware' child node */
+ while ((fw = of_get_next_child(qe, fw)))
+ if (strcmp(fw-name, firmware) == 0)
+ break;
Hmm. Maybe of_find_node_by_name? Or better by compatible.
What's wrong with looking for the firmware node inside the QE node?
That's the only place it can be?
Ah, I see it now. Revoking my comment.
+ iprop = of_get_property(fw, extended_modes, NULL);
Checking for size?
Ok.
Thanks,
--
Anton Vorontsov
email: [EMAIL PROTECTED]
backup email: [EMAIL PROTECTED]
irc://irc.freenode.net/bd2
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
