Re: [Linuxptp-devel] [PATCH v2 4/7] Add BMCA config option.
On Tue, 2018-10-02 at 16:00 -0700, Richard Cochran wrote: > On Tue, Oct 02, 2018 at 04:25:32PM +, Patel, Vedang wrote: > > > > We still need to clear out the timer when the device transitions > > out of > > slave state for other events like EV_FAULT_DETECTED. So, I think we > > still need to keep it there. > So, IOW, the reset is a special case for the noop-BCMA, right? > Yes, it is a special case. So, I guess it makes sense to do it only when we are running noop-BMCA. Thanks, Vedang > Thanks, > Richard ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
Re: [Linuxptp-devel] [PATCH v2 4/7] Add BMCA config option.
On Tue, Oct 02, 2018 at 04:25:32PM +, Patel, Vedang wrote: > We still need to clear out the timer when the device transitions out of > slave state for other events like EV_FAULT_DETECTED. So, I think we > still need to keep it there. So, IOW, the reset is a special case for the noop-BCMA, right? Thanks, Richard ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
Re: [Linuxptp-devel] [PATCH v2 6/7] Add ignore_source_id config option.
> -Original Message- > From: Patel, Vedang > Sent: Monday, October 01, 2018 3:29 PM > To: Keller, Jacob E ; linuxptp- > de...@lists.sourceforge.net > Cc: Sanchez-Palencia, Jesus ; Gomes, > Vinicius > Subject: Re: [Linuxptp-devel] [PATCH v2 6/7] Add ignore_source_id config > option. > > On Mon, 2018-10-01 at 21:32 +, Keller, Jacob E wrote: > > > > > > > > -Original Message- > > > From: Vedang Patel [mailto:vedang.pa...@intel.com] > > > Sent: Wednesday, September 26, 2018 2:58 PM > > > To: linuxptp-devel@lists.sourceforge.net > > > Cc: Gomes, Vinicius ; Sanchez-Palencia, > > > Jesus > > > > > > Subject: [Linuxptp-devel] [PATCH v2 6/7] Add ignore_source_id > > > config option. > > > > > > This config option will skip the source port identity verification > > > in > > > the Sync and Follow_up messages. This option is needed when the > > > announce > > > messages are disabled because the slave cannot know the identity of > > > master without announce messages. > > > > > > This is required by Automotive Profile as part of skipping the Best > > > Master Clock Algorithm (BMCA). > > > > > Would it be better to allow configuring the expected source id > > instead? > > > Manually configuring source ids for all slave devices is not going to > be ideal in mass production. > > Also, the spec[1] (look at Section 6.3, point #2) specifically asks for > the source id to be ignored. > > Thanks, > Vedang Yep, thanks for the explanation. Regards, Jake > > [1] - https://avnu.org/wp-content/uploads/2014/05/Automotive-Ethernet-A > VB-Func-Interop-Spec-v1.5-Public.pdf > > Thanks, > > Jake > > ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
Re: [Linuxptp-devel] [PATCH v2 4/7] Add BMCA config option.
On Mon, 2018-10-01 at 18:26 -0700, Richard Cochran wrote: > On Mon, Oct 01, 2018 at 06:11:16PM +, Patel, Vedang wrote: > > > > On Mon, 2018-10-01 at 10:59 -0700, Richard Cochran wrote: > > > > > > On Mon, Oct 01, 2018 at 05:24:48PM +, Patel, Vedang wrote: > > > > > > > > > > > > I will add the comment for clearing the SYNC_RX_TIMER. It is > > > > basically > > > > to clear out the event returned by poll(). > > > But why? Does the original code have a bug? Please explain. > > > > > In the original code, whenever we receive a FD_SYNC_RX_TIMER > > timeout, > > it is usually accompanied by a state transition. So, > > port_*_transition() will take care of clearing the event for us (by > > calling port_clr_tmo() at the beginning). But, when BMCA == 'noop', > > there is nothing to do, so we are not clearing out the event and > > poll() > > will report the event in every loop. I am just taking care of > > clearing > > this event here. > Then you should have followed through and removed the redundant clear > in the state transition code. Or what am I missing? > We still need to clear out the timer when the device transitions out of slave state for other events like EV_FAULT_DETECTED. So, I think we still need to keep it there. Thanks, Vedang > Thanks, > Richard ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
