> -Original Message-
> From: Petr Machata [mailto:pe...@mellanox.com]
> Sent: Wednesday, September 04, 2019 1:35 AM
> To: Keller, Jacob E
> Cc: linuxptp-devel@lists.sourceforge.net
> Subject: Re: [PATCH 1/2] port: Introduce per-port stats for received and
> transmitted
> messages
>
>
> Keller, Jacob E writes:
>
> >> diff --git a/ddt.h b/ddt.h
> >> index 4acaa4f..5486203 100644
> >> --- a/ddt.h
> >> +++ b/ddt.h
> >> @@ -100,4 +100,9 @@ struct FaultRecord {
> >>struct PTPText faultDescription;
> >> };
> >>
> >> +struct PortStats {
> >> + uint64_t rxMsgType[16];
> >> + uint64_t txMsgType[16];
> >
> > Is there some define we could use that represents this 16, instead of
> > just using the number? that would make it more clear why this is 16,
> > and possibly update if that ever changes in the future.
>
> messageType in Common Message Header has four bits (Table 18 in IEEE
> 1588-2008), hence 16 different messages can be encoded. There is no
> define for it in ptp4l, at least I haven't found any. I can add one if
> you prefer, or add an explanatory comment.
I'd appreciate one of those two options.
Thanks,
Jake
___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
