Re: [Linuxptp-devel] [PATCH 3/5] Move signal handling to util.c.

2014-07-10 Thread Keller, Jacob E 
On Thu, 2014-07-10 at 11:35 +0200, Miroslav Lichvar wrote:
 On Wed, Jul 09, 2014 at 06:55:23PM +, Keller, Jacob E wrote:
  On Wed, 2014-07-09 at 10:21 +0200, Miroslav Lichvar wrote:
   I'm not sure I understand your question. Would you prefer to export
   the running variable and use it in other modules directly instead of
   the is_running fuction?
   
  
  Oh nope. I see now you use the variable inside the module, and function
  outside.
  
  I was just thinking for consistency to just always use the function.
 
 I think that's what the patch does, or not? The running variable is
 used only in is_running() in util.c and everything else uses
 is_running().
 

Ah yes, you are right, I saw the - line and misread the patch.

Thanks,
Jake
--
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Re: [Linuxptp-devel] [PATCH 3/5] Move signal handling to util.c.

2014-07-09 Thread Miroslav Lichvar 
On Tue, Jul 08, 2014 at 05:18:29PM +, Keller, Jacob E wrote:
 On Tue, 2014-07-08 at 16:14 +0200, Miroslav Lichvar wrote:
  @@ -404,7 +385,7 @@ int main(int argc, char *argv[])
  return -1;
  }
   
  -   while (running) {
  +   while (is_running()) {
 
 Is there a reason we no longer use the is_running() function and just
 reference the variable directly?

I'm not sure I understand your question. Would you prefer to export
the running variable and use it in other modules directly instead of
the is_running fuction?

-- 
Miroslav Lichvar

--
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel