Re: [Linuxsampler-devel] svn gigedit and gtkmm-3.24.0 compilation issue
hi again, thank you for guiding me :-) here's the patch that works for me: https://cgit.gentoo.org/dev/fordfrog.git/tree/media-sound/gigedit/files/gigedit--gtkmm-3.24.patch regards. miroslav Dne 2019-01-01 20:50, Christian Schoenebeck napsal: On Dienstag, 1. Januar 2019 20:23:52 CET Miroslav Šulc wrote: thanks for the clarification. i patched the file (patch attached) and the original errors are gone, but now i get these: mainwindow.cpp: In constructor ‘PropDialog::PropDialog()’: mainwindow.cpp:2769:11: error: ‘class Table’ has no member named ‘set_margin’; did you mean ‘set_halign’? table.set_margin(5); ^~ set_halign If you look at the mentioned locations of those errors in the source files you will see there are the same GTK version checks as previously described. Adjusting them in the same way should do the trick. You are a Gentoo user, you can do that! :) CU Christian ___ Linuxsampler-devel mailing list Linuxsampler-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel ___ Linuxsampler-devel mailing list Linuxsampler-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel
Re: [Linuxsampler-devel] svn gigedit and gtkmm-3.24.0 compilation issue
On Wednesday, 2. Januar 2019 13:55:00 CET Miroslav Šulc wrote: > thank you for guiding me :-) here's the patch that works for me: > https://cgit.gentoo.org/dev/fordfrog.git/tree/media-sound/gigedit/files/gige > dit--gtkmm-3.24.patch Perfect! And it is now in SVN r3450 on our side. Thanks for your patch Miroslav! CU Christian ___ Linuxsampler-devel mailing list Linuxsampler-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel
Re: [Linuxsampler-devel] svn gigedit and gtkmm-3.24.0 compilation issue
thanks for guiding me and for the work you do! :-) regards. miroslav Dne 2019-01-02 17:44, Christian Schoenebeck napsal: On Wednesday, 2. Januar 2019 13:55:00 CET Miroslav Šulc wrote: thank you for guiding me :-) here's the patch that works for me: https://cgit.gentoo.org/dev/fordfrog.git/tree/media-sound/gigedit/files/gige dit--gtkmm-3.24.patch Perfect! And it is now in SVN r3450 on our side. Thanks for your patch Miroslav! CU Christian ___ Linuxsampler-devel mailing list Linuxsampler-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel ___ Linuxsampler-devel mailing list Linuxsampler-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel
Re: [Linuxsampler-devel] Sustain release velocity & Gigastudio 4
Hi Christian
On 23/12/2018 23:18, Christian Schoenebeck wrote:
I also committed required changes to gigedit. You find a new combo box and a
new checkbox on the "Misc" tab there.
Didn't have the time to test these things. I'm off for couple days now;
Christmas obligations.
I just want to draw your attention to the 'or' operator for
release_trigger_t at the top of linuxsampler/src/engines/common/Note.h.
This operator calls itself recursively causing a segmentation fault when
I load an instrument containing release trigger samples and try to play
it. Casting variables a and b to int before the bitwise operation solves
the problem but I'm not sure if that's what you intended? I've attached
a patch with my suggested change.
All the best,
Ivan
diff -Naur linuxsampler_original/src/engines/common/Note.h linuxsampler_modified/src/engines/common/Note.h
--- linuxsampler_original/src/engines/common/Note.h 2019-01-02 22:11:50.500839803 +
+++ linuxsampler_modified/src/engines/common/Note.h 2019-01-02 22:12:38.765204989 +
@@ -34,10 +34,10 @@
// remove strictness of C++ regarding raw bitwise operations (on type release_trigger_t)
inline release_trigger_t operator|(release_trigger_t a, release_trigger_t b) {
-return (release_trigger_t) (a | b);
+return (release_trigger_t) ((int)a | (int)b);
}
inline release_trigger_t& operator|=(release_trigger_t& a, release_trigger_t b) {
-a = (release_trigger_t) (a | b);
+a = (release_trigger_t) ((int)a | (int)b);
return a;
}
___
Linuxsampler-devel mailing list
Linuxsampler-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxsampler-devel
