[git:media_stage/master] media: saa7134: Use devm_request_irq

[Hans Verkuil]

This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: saa7134: Use devm_request_irq
Author:  Ricardo Ribalda <riba...@chromium.org>
Date:    Thu Apr 11 21:17:52 2024 +0000

The handled version of request_irq let us remove the free_irq and makes
smatch happier:

drivers/media/pci/saa7134/saa7134-alsa.c:1186 alsa_card_saa7134_create() warn: 
'dev->pci->irq' from request_irq() not released on lines: 1186

Signed-off-by: Ricardo Ribalda <riba...@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil-ci...@xs4all.nl>

 drivers/media/pci/saa7134/saa7134-alsa.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

---

diff --git a/drivers/media/pci/saa7134/saa7134-alsa.c 
b/drivers/media/pci/saa7134/saa7134-alsa.c
index d3cde05a6eba..dd2236c5c4a1 100644
--- a/drivers/media/pci/saa7134/saa7134-alsa.c
+++ b/drivers/media/pci/saa7134/saa7134-alsa.c
@@ -1096,9 +1096,6 @@ static void snd_saa7134_free(struct snd_card * card)
        if (chip->dev->dmasound.priv_data == NULL)
                return;
 
-       if (chip->irq >= 0)
-               free_irq(chip->irq, &chip->dev->dmasound);
-
        chip->dev->dmasound.priv_data = NULL;
 
 }
@@ -1147,10 +1144,8 @@ static int alsa_card_saa7134_create(struct saa7134_dev 
*dev, int devnum)
        chip->iobase = pci_resource_start(dev->pci, 0);
 
 
-       err = request_irq(dev->pci->irq, saa7134_alsa_irq,
-                               IRQF_SHARED, dev->name,
-                               (void*) &dev->dmasound);
-
+       err = devm_request_irq(&dev->pci->dev, dev->pci->irq, saa7134_alsa_irq,
+                              IRQF_SHARED, dev->name, &dev->dmasound);
        if (err < 0) {
                pr_err("%s: can't get IRQ %d for ALSA\n",
                        dev->name, dev->pci->irq);