Re: [Linuxwacom-devel] [PATCH libwacom 2/2] tools: unset ID_INPUT_JOYSTICK for wacom tablets
On Thu, Feb 05, 2015 at 05:12:21PM -0800, Ping Cheng wrote:
On Wed, Feb 4, 2015 at 8:39 PM, Peter Hutterer peter.hutte...@who-t.net
wrote:
udev's input_id builtin assigns ID_INPUT_JOYSTICK based on BTN_1, ABS_WHEEL
and a couple of other bits. Wacom devices trigger that but they're
definitely
not joysticks.
Unset the bit, we know better than udev here.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
tools/generate-udev-rules.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/generate-udev-rules.c b/tools/generate-udev-rules.c
index c6d430b..6883451 100644
--- a/tools/generate-udev-rules.c
+++ b/tools/generate-udev-rules.c
@@ -82,7 +82,8 @@ static void print_udev_entry_for_match (WacomDevice
*device, const WacomMatch *m
return;
}
- printf(ENV{ID_INPUT}=\1\, ENV{ID_INPUT_TABLET}=\1\%s\n,
touchpad);
+ /* unset joystick, set tablet and possibly touchpad */
+ printf(ENV{ID_INPUT}=\1\, ENV{ID_INPUT_JOYSTICK}=\\,
ENV{ID_INPUT_TABLET}=\1\%s\n, touchpad);
On kernels 3.17 and later, those PADs will never be touchpad any more,
They are express keypads. Do we need/want to distinguish them?
yeah, I think we should figure out a way to tag them. We're going to use
this information in libinput to decide what device we're dealing with,
having an easy way in the form of tags will just help. I'll talk to Benjamin
to figure out what the best way of tagging them is
Except that, the patchset looks good. Thank you.
Reviewed-by: Ping Cheng pi...@wacom.com for the series.
thanks
Cheers,
Peter
}
static void print_uinput_entry_for_match (WacomDevice *device, const
WacomMatch *match,
--
2.1.0
--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
Re: [Linuxwacom-devel] [PATCH libwacom 2/2] tools: unset ID_INPUT_JOYSTICK for wacom tablets
On Wed, Feb 4, 2015 at 8:39 PM, Peter Hutterer peter.hutte...@who-t.net wrote:
udev's input_id builtin assigns ID_INPUT_JOYSTICK based on BTN_1, ABS_WHEEL
and a couple of other bits. Wacom devices trigger that but they're definitely
not joysticks.
Unset the bit, we know better than udev here.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
tools/generate-udev-rules.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/generate-udev-rules.c b/tools/generate-udev-rules.c
index c6d430b..6883451 100644
--- a/tools/generate-udev-rules.c
+++ b/tools/generate-udev-rules.c
@@ -82,7 +82,8 @@ static void print_udev_entry_for_match (WacomDevice
*device, const WacomMatch *m
return;
}
- printf(ENV{ID_INPUT}=\1\, ENV{ID_INPUT_TABLET}=\1\%s\n,
touchpad);
+ /* unset joystick, set tablet and possibly touchpad */
+ printf(ENV{ID_INPUT}=\1\, ENV{ID_INPUT_JOYSTICK}=\\,
ENV{ID_INPUT_TABLET}=\1\%s\n, touchpad);
On kernels 3.17 and later, those PADs will never be touchpad any more,
They are express keypads. Do we need/want to distinguish them?
Except that, the patchset looks good. Thank you.
Reviewed-by: Ping Cheng pi...@wacom.com for the series.
Ping
}
static void print_uinput_entry_for_match (WacomDevice *device, const
WacomMatch *match,
--
2.1.0
--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
