On Wed, Aug 10, 2016 at 9:14 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > The server guarantees that DEVICE_OFF is called for any previously enabled > device, so we don't really have anything to do here. And since the input > thread addition to the server we can't safely call xf86RemoveEnabledDevice() > twice for the same device. > > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
I tested this set of 3 patches on the xserver built from master of git.freedesktop.org/git/xorg/xserver. My script that emulates a series of repeated disconnecting and connecting of Wacom device didn't show issues related to either X server or Wacom driver. The new X server is quite robust. And I am more confident with the performance of xf86-input-wacom than before. Thank you for your effort here and at freedesktop! The whole series is: Tested-by: Ping Cheng <pi...@wacom.com> Cheers, Ping > --- > src/xf86Wacom.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/xf86Wacom.c b/src/xf86Wacom.c > index 4127239..40b5c3d 100644 > --- a/src/xf86Wacom.c > +++ b/src/xf86Wacom.c > @@ -854,7 +854,6 @@ static int wcmDevProc(DeviceIntPtr pWcm, int what) > break; > > case DEVICE_OFF: > - case DEVICE_CLOSE: > wcmDisableTool(pWcm); > wcmUnlinkTouchAndPen(pInfo); > if (pInfo->fd >= 0) > @@ -864,6 +863,8 @@ static int wcmDevProc(DeviceIntPtr pWcm, int what) > } > pWcm->public.on = FALSE; > break; > + case DEVICE_CLOSE: > + break; > #if GET_ABI_MAJOR(ABI_XINPUT_VERSION) * 100 + > GET_ABI_MINOR(ABI_XINPUT_VERSION) >= 1901 > case DEVICE_ABORT: > break; > -- > 2.7.4 > > > ------------------------------------------------------------------------------ > What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic > patterns at an interface-level. Reveals which users, apps, and protocols are > consuming the most bandwidth. Provides multi-vendor support for NetFlow, > J-Flow, sFlow and other flows. Make informed decisions using capacity > planning reports. http://sdm.link/zohodev2dev > _______________________________________________ > Linuxwacom-devel mailing list > Linuxwacom-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel ------------------------------------------------------------------------------ _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
