Run-time axis configuration is not really allowed. The XI2 protocol permits
it but it's forbidden for XI1 clients since they have no notification
mechanisms. And we don't have any server APIs for the XI2 stuff yet.

If a client issues ListInputDevices and the driver reconfigures _after_
that, the client assumes wrong coordinate ranges, causing possible scaling
issues. The right way to handle axis reconfiguration is to scale _inside_
the driver only.

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
---
 src/wcmXCommand.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/src/wcmXCommand.c b/src/wcmXCommand.c
index 7a69f60..f0ea99e 100644
--- a/src/wcmXCommand.c
+++ b/src/wcmXCommand.c
@@ -40,17 +40,9 @@ int wcmDevSwitchModeCall(LocalDevicePtr local, int mode)
                return (mode == Relative) ? Success : XI_BadMode;
 
        if ((mode == Absolute) && !is_absolute(local))
-       {
                set_absolute(local, TRUE);
-               wcmInitialCoordinates(local, 0);
-               wcmInitialCoordinates(local, 1);
-       }
        else if ((mode == Relative) && is_absolute(local))
-       {
                set_absolute(local, FALSE);
-               wcmInitialCoordinates(local, 0);
-               wcmInitialCoordinates(local, 1);
-       }
        else if ( (mode != Absolute) && (mode != Relative))
        {
                DBG(10, priv, "invalid mode=%d\n", mode);
-- 
1.7.0.1


------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate 
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the 
lucky parental unit.  See the prize list and enter to win: 
http://p.sf.net/sfu/thinkgeek-promo
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to