Re: [Linuxwacom-devel] [PATCH libwacom v2 2/3] layouts: fix the anchors of some svg button labels

[Peter Hutterer]

On Fri, May 27, 2016 at 10:52:32AM -0700, Ping Cheng wrote:
> On Friday, May 27, 2016, Benjamin Tissoires 
> wrote:
> 
> > If g-s-d is to rely on the actual anchor position and orientation of the
> > labels, we need to make sure our labels are correct.
> 
> 
> Thank you Benjamin for cleanning up the mess. I've never
> noticed those start, middle, and end details when I copy/pasted the labels.
> 
> The other two patches are sensible to me too. So, the whole series is
> 
> Reviewed-by: Ping Cheng 

and pushed, thanks.

   a03828c..a1150d2  master -> master

Cheers,
   Peter
 

> > ---
> >
> > new in v2
> >
> >  data/layouts/dtu-1031.svg | 8 
> >  data/layouts/intuos-m-p.svg   | 4 ++--
> >  data/layouts/intuos-m-p2.svg  | 4 ++--
> >  data/layouts/intuos-m-pt.svg  | 4 ++--
> >  data/layouts/intuos-m-pt2.svg | 4 ++--
> >  data/layouts/intuos-s-p.svg   | 4 ++--
> >  data/layouts/intuos-s-p2.svg  | 4 ++--
> >  data/layouts/intuos-s-pt.svg  | 4 ++--
> >  data/layouts/intuos-s-pt2.svg | 4 ++--
> >  9 files changed, 20 insertions(+), 20 deletions(-)
> >
> > diff --git a/data/layouts/dtu-1031.svg b/data/layouts/dtu-1031.svg
> > index f27c14d..04682f2 100644
> > --- a/data/layouts/dtu-1031.svg
> > +++ b/data/layouts/dtu-1031.svg
> > @@ -26,7 +26,7 @@
> > class="A Label"
> > x="91"
> > y="42.5"
> > -   style="text-anchor:middle;">A
> > +   style="text-anchor:start;">A
> >
> >
> >   > @@ -44,7 +44,7 @@
> > class="B Label"
> > x="91"
> > y="62.5"
> > -   style="text-anchor:middle;">B
> > +   style="text-anchor:start;">B
> >
> >
> >   > @@ -62,7 +62,7 @@
> > class="C Label"
> > x="91"
> > y="82.5"
> > -   style="text-anchor:middle;">C
> > +   style="text-anchor:start;">C
> >
> >
> >   > @@ -80,6 +80,6 @@
> > class="D Label"
> > x="91"
> > y="102.5"
> > -   style="text-anchor:middle;">D
> > +   style="text-anchor:start;">D
> >
> >  
> > diff --git a/data/layouts/intuos-m-p.svg b/data/layouts/intuos-m-p.svg
> > index 3cf1f9b..eaf4177 100644
> > --- a/data/layouts/intuos-m-p.svg
> > +++ b/data/layouts/intuos-m-p.svg
> > @@ -22,7 +22,7 @@
> >  
> >  
> >  
> > - > style="text-anchor:start;">C
> > + > style="text-anchor:end;">C
> >
> >
> >
> > @@ -30,7 +30,7 @@
> >  
> >  
> >  
> > - > style="text-anchor:start;">D
> > + > style="text-anchor:end;">D
> >
> >
> >  
> > diff --git a/data/layouts/intuos-m-p2.svg b/data/layouts/intuos-m-p2.svg
> > index 10ef9ac..dbd8809 100644
> > --- a/data/layouts/intuos-m-p2.svg
> > +++ b/data/layouts/intuos-m-p2.svg
> > @@ -22,7 +22,7 @@
> >  
> >  
> >  
> > - > style="text-anchor:start;">C
> > + > style="text-anchor:end;">C
> >
> >
> >
> > @@ -30,7 +30,7 @@
> >  
> >  
> >  
> > - > style="text-anchor:start;">D
> > + > style="text-anchor:end;">D
> >
> >
> >  
> > diff --git a/data/layouts/intuos-m-pt.svg b/data/layouts/intuos-m-pt.svg
> > index 0969a59..c952993 100644
> > --- a/data/layouts/intuos-m-pt.svg
> > +++ b/data/layouts/intuos-m-pt.svg
> > @@ -22,7 +22,7 @@
> >  
> >  
> >  
> > - > style="text-anchor:start;">C
> > + > style="text-anchor:end;">C
> >
> >
> >
> > @@ -30,7 +30,7 @@
> >  
> >  
> >  
> > - > style="text-anchor:start;">D
> > + > style="text-anchor:end;">D
> >
> >
> >  
> > diff --git a/data/layouts/intuos-m-pt2.svg b/data/layouts/intuos-m-pt2.svg
> > index 091613e..a16e4b3 100644
> > --- a/data/layouts/intuos-m-pt2.svg
> > +++ b/data/layouts/intuos-m-pt2.svg
> > @@ -22,7 +22,7 @@
> >  
> >  
> >  
> > - > style="text-anchor:start;">C
> > + > style="text-anchor:end;">C
> >
> >
> >
> > @@ -30,7 +30,7 @@
> >  
> >  
> >  
> > - > style="text-anchor:start;">D
> > + > style="text-anchor:end;">D
> >
> >
> >  
> > diff --git a/data/layouts/intuos-s-p.svg b/data/layouts/intuos-s-p.svg
> > index fe96474..c833ce0 100644
> > --- a/data/layouts/intuos-s-p.svg
> > +++ b/data/layouts/intuos-s-p.svg
> > @@ -22,7 +22,7 @@
> >  
> >  
> >  
> > - > style="text-anchor:start;">C
> > + > style="text-anchor:end;">C
> >
> >
> >
> > @@ -30,7 +30,7 @@
> >  
> >  
> >  
> > - > style="text-anchor:start;">D
> > + > style="text-anchor:end;">D
> >
> >
> >  
> > diff --git a/data/layouts/intuos-s-p2.svg b/data/layouts/intuos-s-p2.svg
> > index 11ec08e..d3d5549 100644
> > --- a/data/layouts/intuos-s-p2.svg
> > +++ b/data/layouts/intuos-s-p2.svg
> > @@ -22,7 +22,7 @@
> >  
> >  
> >  
> > - > style="text-anchor:start;">C
> > + > style="text-anchor:end;">C
> >
> >
> >
> > @@ -30,7 +30,7 @@
> >  
> >  
> >  
> > - > style="text-anchor:start;">D
> > + > style="text-anchor:end;">D
> >
> >
> >  
> > 

Re: [Linuxwacom-devel] [PATCH libwacom v2 2/3] layouts: fix the anchors of some svg button labels

[Ping Cheng]

On Friday, May 27, 2016, Benjamin Tissoires 
wrote:

> If g-s-d is to rely on the actual anchor position and orientation of the
> labels, we need to make sure our labels are correct.


Thank you Benjamin for cleanning up the mess. I've never
noticed those start, middle, and end details when I copy/pasted the labels.

The other two patches are sensible to me too. So, the whole series is

Reviewed-by: Ping Cheng 

Ping


> Signed-off-by: Benjamin Tissoires  >
> ---
>
> new in v2
>
>  data/layouts/dtu-1031.svg | 8 
>  data/layouts/intuos-m-p.svg   | 4 ++--
>  data/layouts/intuos-m-p2.svg  | 4 ++--
>  data/layouts/intuos-m-pt.svg  | 4 ++--
>  data/layouts/intuos-m-pt2.svg | 4 ++--
>  data/layouts/intuos-s-p.svg   | 4 ++--
>  data/layouts/intuos-s-p2.svg  | 4 ++--
>  data/layouts/intuos-s-pt.svg  | 4 ++--
>  data/layouts/intuos-s-pt2.svg | 4 ++--
>  9 files changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/data/layouts/dtu-1031.svg b/data/layouts/dtu-1031.svg
> index f27c14d..04682f2 100644
> --- a/data/layouts/dtu-1031.svg
> +++ b/data/layouts/dtu-1031.svg
> @@ -26,7 +26,7 @@
> class="A Label"
> x="91"
> y="42.5"
> -   style="text-anchor:middle;">A
> +   style="text-anchor:start;">A
>
>
>   @@ -44,7 +44,7 @@
> class="B Label"
> x="91"
> y="62.5"
> -   style="text-anchor:middle;">B
> +   style="text-anchor:start;">B
>
>
>   @@ -62,7 +62,7 @@
> class="C Label"
> x="91"
> y="82.5"
> -   style="text-anchor:middle;">C
> +   style="text-anchor:start;">C
>
>
>   @@ -80,6 +80,6 @@
> class="D Label"
> x="91"
> y="102.5"
> -   style="text-anchor:middle;">D
> +   style="text-anchor:start;">D
>
>  
> diff --git a/data/layouts/intuos-m-p.svg b/data/layouts/intuos-m-p.svg
> index 3cf1f9b..eaf4177 100644
> --- a/data/layouts/intuos-m-p.svg
> +++ b/data/layouts/intuos-m-p.svg
> @@ -22,7 +22,7 @@
>  
>  
>  
> - style="text-anchor:start;">C
> + style="text-anchor:end;">C
>
>
>
> @@ -30,7 +30,7 @@
>  
>  
>  
> - style="text-anchor:start;">D
> + style="text-anchor:end;">D
>
>
>  
> diff --git a/data/layouts/intuos-m-p2.svg b/data/layouts/intuos-m-p2.svg
> index 10ef9ac..dbd8809 100644
> --- a/data/layouts/intuos-m-p2.svg
> +++ b/data/layouts/intuos-m-p2.svg
> @@ -22,7 +22,7 @@
>  
>  
>  
> - style="text-anchor:start;">C
> + style="text-anchor:end;">C
>
>
>
> @@ -30,7 +30,7 @@
>  
>  
>  
> - style="text-anchor:start;">D
> + style="text-anchor:end;">D
>
>
>  
> diff --git a/data/layouts/intuos-m-pt.svg b/data/layouts/intuos-m-pt.svg
> index 0969a59..c952993 100644
> --- a/data/layouts/intuos-m-pt.svg
> +++ b/data/layouts/intuos-m-pt.svg
> @@ -22,7 +22,7 @@
>  
>  
>  
> - style="text-anchor:start;">C
> + style="text-anchor:end;">C
>
>
>
> @@ -30,7 +30,7 @@
>  
>  
>  
> - style="text-anchor:start;">D
> + style="text-anchor:end;">D
>
>
>  
> diff --git a/data/layouts/intuos-m-pt2.svg b/data/layouts/intuos-m-pt2.svg
> index 091613e..a16e4b3 100644
> --- a/data/layouts/intuos-m-pt2.svg
> +++ b/data/layouts/intuos-m-pt2.svg
> @@ -22,7 +22,7 @@
>  
>  
>  
> - style="text-anchor:start;">C
> + style="text-anchor:end;">C
>
>
>
> @@ -30,7 +30,7 @@
>  
>  
>  
> - style="text-anchor:start;">D
> + style="text-anchor:end;">D
>
>
>  
> diff --git a/data/layouts/intuos-s-p.svg b/data/layouts/intuos-s-p.svg
> index fe96474..c833ce0 100644
> --- a/data/layouts/intuos-s-p.svg
> +++ b/data/layouts/intuos-s-p.svg
> @@ -22,7 +22,7 @@
>  
>  
>  
> - style="text-anchor:start;">C
> + style="text-anchor:end;">C
>
>
>
> @@ -30,7 +30,7 @@
>  
>  
>  
> - style="text-anchor:start;">D
> + style="text-anchor:end;">D
>
>
>  
> diff --git a/data/layouts/intuos-s-p2.svg b/data/layouts/intuos-s-p2.svg
> index 11ec08e..d3d5549 100644
> --- a/data/layouts/intuos-s-p2.svg
> +++ b/data/layouts/intuos-s-p2.svg
> @@ -22,7 +22,7 @@
>  
>  
>  
> - style="text-anchor:start;">C
> + style="text-anchor:end;">C
>
>
>
> @@ -30,7 +30,7 @@
>  
>  
>  
> - style="text-anchor:start;">D
> + style="text-anchor:end;">D
>
>
>  
> diff --git a/data/layouts/intuos-s-pt.svg b/data/layouts/intuos-s-pt.svg
> index 326d4ea..82667f6 100644
> --- a/data/layouts/intuos-s-pt.svg
> +++ b/data/layouts/intuos-s-pt.svg
> @@ -22,7 +22,7 @@
>  
>  
>  
> - style="text-anchor:start;">C
> + style="text-anchor:end;">C
>
>
>
> @@ -30,7 +30,7 @@
>  
>  
>  
> - style="text-anchor:start;">D
> + style="text-anchor:end;">D
>
>
>  
> diff --git a/data/layouts/intuos-s-pt2.svg 

[Linuxwacom-devel] [PATCH libwacom v2 2/3] layouts: fix the anchors of some svg button labels

[Benjamin Tissoires]

If g-s-d is to rely on the actual anchor position and orientation of the
labels, we need to make sure our labels are correct.

Signed-off-by: Benjamin Tissoires 
---

new in v2

 data/layouts/dtu-1031.svg | 8 
 data/layouts/intuos-m-p.svg   | 4 ++--
 data/layouts/intuos-m-p2.svg  | 4 ++--
 data/layouts/intuos-m-pt.svg  | 4 ++--
 data/layouts/intuos-m-pt2.svg | 4 ++--
 data/layouts/intuos-s-p.svg   | 4 ++--
 data/layouts/intuos-s-p2.svg  | 4 ++--
 data/layouts/intuos-s-pt.svg  | 4 ++--
 data/layouts/intuos-s-pt2.svg | 4 ++--
 9 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/data/layouts/dtu-1031.svg b/data/layouts/dtu-1031.svg
index f27c14d..04682f2 100644
--- a/data/layouts/dtu-1031.svg
+++ b/data/layouts/dtu-1031.svg
@@ -26,7 +26,7 @@
class="A Label"
x="91"
y="42.5"
-   style="text-anchor:middle;">A
+   style="text-anchor:start;">A
   
   
 B
+   style="text-anchor:start;">B
   
   
 C
+   style="text-anchor:start;">C
   
   
 D
+   style="text-anchor:start;">D
   
 
diff --git a/data/layouts/intuos-m-p.svg b/data/layouts/intuos-m-p.svg
index 3cf1f9b..eaf4177 100644
--- a/data/layouts/intuos-m-p.svg
+++ b/data/layouts/intuos-m-p.svg
@@ -22,7 +22,7 @@
 
 
 
-C
+C
   
 
 
@@ -30,7 +30,7 @@
 
 
 
-D
+D
   
 
 
diff --git a/data/layouts/intuos-m-p2.svg b/data/layouts/intuos-m-p2.svg
index 10ef9ac..dbd8809 100644
--- a/data/layouts/intuos-m-p2.svg
+++ b/data/layouts/intuos-m-p2.svg
@@ -22,7 +22,7 @@
 
 
 
-C
+C
   
 
 
@@ -30,7 +30,7 @@
 
 
 
-D
+D
   
 
 
diff --git a/data/layouts/intuos-m-pt.svg b/data/layouts/intuos-m-pt.svg
index 0969a59..c952993 100644
--- a/data/layouts/intuos-m-pt.svg
+++ b/data/layouts/intuos-m-pt.svg
@@ -22,7 +22,7 @@
 
 
 
-C
+C
   
 
 
@@ -30,7 +30,7 @@
 
 
 
-D
+D
   
 
 
diff --git a/data/layouts/intuos-m-pt2.svg b/data/layouts/intuos-m-pt2.svg
index 091613e..a16e4b3 100644
--- a/data/layouts/intuos-m-pt2.svg
+++ b/data/layouts/intuos-m-pt2.svg
@@ -22,7 +22,7 @@
 
 
 
-C
+C
   
 
 
@@ -30,7 +30,7 @@
 
 
 
-D
+D
   
 
 
diff --git a/data/layouts/intuos-s-p.svg b/data/layouts/intuos-s-p.svg
index fe96474..c833ce0 100644
--- a/data/layouts/intuos-s-p.svg
+++ b/data/layouts/intuos-s-p.svg
@@ -22,7 +22,7 @@
 
 
 
-C
+C
   
 
 
@@ -30,7 +30,7 @@
 
 
 
-D
+D
   
 
 
diff --git a/data/layouts/intuos-s-p2.svg b/data/layouts/intuos-s-p2.svg
index 11ec08e..d3d5549 100644
--- a/data/layouts/intuos-s-p2.svg
+++ b/data/layouts/intuos-s-p2.svg
@@ -22,7 +22,7 @@
 
 
 
-C
+C
   
 
 
@@ -30,7 +30,7 @@
 
 
 
-D
+D
   
 
 
diff --git a/data/layouts/intuos-s-pt.svg b/data/layouts/intuos-s-pt.svg
index 326d4ea..82667f6 100644
--- a/data/layouts/intuos-s-pt.svg
+++ b/data/layouts/intuos-s-pt.svg
@@ -22,7 +22,7 @@
 
 
 
-C
+C
   
 
 
@@ -30,7 +30,7 @@
 
 
 
-D
+D
   
 
 
diff --git a/data/layouts/intuos-s-pt2.svg b/data/layouts/intuos-s-pt2.svg
index 3c0303d..45b6298 100644
--- a/data/layouts/intuos-s-pt2.svg
+++ b/data/layouts/intuos-s-pt2.svg
@@ -22,7 +22,7 @@
 
 
 
-C
+C
   
 
 
@@ -30,7 +30,7 @@
 
 
 
-D
+D
   
 
 
-- 
2.5.5


--
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity 
planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel