[Lldb-commits] [lldb] r205539 - Add explict dependencies on swig .i files for cmake builds

2014-04-03 Thread Ed Maste
Author: emaste
Date: Thu Apr  3 10:03:11 2014
New Revision: 205539

URL: http://llvm.org/viewvc/llvm-project?rev=205539view=rev
Log:
Add explict dependencies on swig .i files for cmake builds

llvm.org/pr19316

Modified:
lldb/trunk/scripts/CMakeLists.txt

Modified: lldb/trunk/scripts/CMakeLists.txt
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/scripts/CMakeLists.txt?rev=205539r1=205538r2=205539view=diff
==
--- lldb/trunk/scripts/CMakeLists.txt (original)
+++ lldb/trunk/scripts/CMakeLists.txt Thu Apr  3 10:03:11 2014
@@ -1,8 +1,11 @@
 set(LLVM_NO_RTTI 1)
 
+file(GLOB SWIG_INPUTS Python/interface/*.i)
+
 add_custom_command(
   OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/LLDBWrapPython.cpp
   DEPENDS ${LLDB_SOURCE_DIR}/scripts/lldb.swig
+  DEPENDS ${SWIG_INPUTS}
   # swig was directly invoked on Windows (where the Python API is not being 
generated) but on other platforms, we need to run the *swig-wrapper-classes.sh 
shell-scripts.
   #COMMAND swig -c++ -shadow -python -I${LLDB_SOURCE_DIR}/include -I./. 
-outdir ${LLDB_SOURCE_DIR}/scripts/Python  -o 
${LLDB_SOURCE_DIR}/source/LLDBWrapPython.cpp 
${LLDB_SOURCE_DIR}/scripts/lldb.swig
   COMMAND ${CMAKE_CURRENT_SOURCE_DIR}/build-swig-wrapper-classes.sh 
${LLDB_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR} ${CMAKE_CURRENT_BINARY_DIR} 
${CMAKE_BINARY_DIR} -m


___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits


[Lldb-commits] [lldb] r205544 - Get dis -c -s working again.

2014-04-03 Thread Jim Ingham
Author: jingham
Date: Thu Apr  3 12:16:17 2014
New Revision: 205544

URL: http://llvm.org/viewvc/llvm-project?rev=205544view=rev
Log:
Get dis -c -s working again.

pr19324

Modified:
lldb/trunk/source/Commands/CommandObjectDisassemble.cpp

Modified: lldb/trunk/source/Commands/CommandObjectDisassemble.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectDisassemble.cpp?rev=205544r1=205543r2=205544view=diff
==
--- lldb/trunk/source/Commands/CommandObjectDisassemble.cpp (original)
+++ lldb/trunk/source/Commands/CommandObjectDisassemble.cpp Thu Apr  3 12:16:17 
2014
@@ -442,8 +442,8 @@ CommandObjectDisassemble::DoExecute (Arg
 return false;
 }
 range.SetByteSize (m_options.end_addr - 
m_options.start_addr);
-ranges.push_back(range);
 }
+ranges.push_back(range);
 }
 else
 {


___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits


[Lldb-commits] [lldb] r205555 - Avoid crash if symbol returns a null name

2014-04-03 Thread Ed Maste
Author: emaste
Date: Thu Apr  3 14:27:39 2014
New Revision: 20

URL: http://llvm.org/viewvc/llvm-project?rev=20view=rev
Log:
Avoid crash if symbol returns a null name

Modified:

lldb/trunk/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp

Modified: 
lldb/trunk/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp?rev=20r1=205554r2=20view=diff
==
--- 
lldb/trunk/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp
 (original)
+++ 
lldb/trunk/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp
 Thu Apr  3 14:27:39 2014
@@ -107,7 +107,7 @@ ItaniumABILanguageRuntime::GetDynamicTyp
 if (symbol != NULL)
 {
 const char *name = 
symbol-GetMangled().GetDemangledName().AsCString();
-if (strstr(name, vtable_demangled_prefix) == name)
+if (name  strstr(name, vtable_demangled_prefix) == name)
 {
 Log *log (lldb_private::GetLogIfAllCategoriesSet 
(LIBLLDB_LOG_OBJECT));
 if (log)


___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits


Re: [Lldb-commits] [lldb] r205555 - Avoid crash if symbol returns a null name

2014-04-03 Thread Greg Clayton
It is possible to get a NULL name. The ConstString class has the following:

const char *
AsCString(const char *value_if_empty = NULL) const

Since no value was provided, it will return NULL if empty, so your fix is good.


On Apr 3, 2014, at 12:44 PM, Ed Maste ema...@freebsd.org wrote:

 On 3 April 2014 15:27, Ed Maste ema...@freebsd.org wrote:
 Author: emaste
 Date: Thu Apr  3 14:27:39 2014
 New Revision: 20
 
 URL: http://llvm.org/viewvc/llvm-project?rev=20view=rev
 Log:
 Avoid crash if symbol returns a null name
 
 I'm not sure if it should be possible for LLDB to have a symbol with a
 null name; if not, I'll replace this with an assert and track down
 where it originated.
 
 This crash started happening on FreeBSD after r205450, when the test
 executes frame var -d run-target --ptr-depth=2 --show-types
 anotherA.m_client_A
 ___
 lldb-commits mailing list
 lldb-commits@cs.uiuc.edu
 http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits