Re: [Lldb-commits] [PATCH] Revert r205480 and rename enums defined in llvm/Support/MachO.h
Please don't commit. Work with Nick Kledzik to get this ironed out in LLVM and Clang first. When you have a solution that they are happy with, we can then fix LLDB. On Apr 8, 2014, at 3:20 PM, Akira Hatanaka ahata...@gmail.com wrote: This patch reverts the workaround introduced in r205480 that was required to avoid collision between enums defined in llvm/Support/MachO.h and macros defined in system header files. The patch should be applied along with the patch posted here that renames enums in MachO.h: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20140407/212243.html Please review. machoenum-rename-lldb1.patch___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] Revert r205480 and rename enums defined in llvm/Support/MachO.h
Akira, please disregard my last statement, I see it is already committed to both llvm/clang and LLDB. I assume if there are any changes that need to be made all sources will be updated. On Apr 9, 2014, at 10:25 AM, Greg Clayton gclay...@apple.com wrote: Please don't commit. Work with Nick Kledzik to get this ironed out in LLVM and Clang first. When you have a solution that they are happy with, we can then fix LLDB. On Apr 8, 2014, at 3:20 PM, Akira Hatanaka ahata...@gmail.com wrote: This patch reverts the workaround introduced in r205480 that was required to avoid collision between enums defined in llvm/Support/MachO.h and macros defined in system header files. The patch should be applied along with the patch posted here that renames enums in MachO.h: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20140407/212243.html Please review. machoenum-rename-lldb1.patch___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] Revert r205480 and rename enums defined in llvm/Support/MachO.h
That looks okay to me, please commit. Jim On Apr 8, 2014, at 3:20 PM, Akira Hatanaka ahata...@gmail.com wrote: This patch reverts the workaround introduced in r205480 that was required to avoid collision between enums defined in llvm/Support/MachO.h and macros defined in system header files. The patch should be applied along with the patch posted here that renames enums in MachO.h: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20140407/212243.html Please review. machoenum-rename-lldb1.patch___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
