Re: [Lldb-commits] [PATCH] D13224: [DWARFASTParserClang] Strengthen incomplete type handling.

[Greg Clayton via lldb-commits]

clayborg added a comment.

So this fix is really to take care of the case where a class methods might be 
defined on only some class instances? Can you explain more of what this fixes?


http://reviews.llvm.org/D13224



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13247: RenderScript command for printing allocation information

[Greg Clayton via lldb-commits]

clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

Back from vacation, sorry for the delay. Looks good.


Repository:
  rL LLVM

http://reviews.llvm.org/D13247



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13154: [MIPS] Use Address::GetAddressClass() instead of elf flags to decide address space of an address

[Greg Clayton via lldb-commits]

clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

Back from vacation, sorry for the delay. Looks good.


Repository:
  rL LLVM

http://reviews.llvm.org/D13154



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

[Greg Clayton via lldb-commits]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

This can't be the real fix for this. We must be able to trust the empty() 
function call. We must have someone playing with the collection without locking 
the mutex. Please find the real bug.


Repository:
  rL LLVM

http://reviews.llvm.org/D12968



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

[Greg Clayton via lldb-commits]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

Back from vacation, sorry for the delay.

One quick fix as noted in inlined comments.



Comment at: source/Breakpoint/Watchpoint.cpp:224-235
@@ -223,7 +223,14 @@
 {
-s->Printf("\n%sold value: %s", prefix, 
m_old_value_sp->GetValueAsCString());
+if (m_old_value_sp->GetValueAsCString())
+s->Printf("\n%sold value: %s", prefix, 
m_old_value_sp->GetValueAsCString());
+else
+s->Printf("\n%sold value: %s", prefix, 
m_old_value_sp->GetSummaryAsCString());
 }
+
 if (m_new_value_sp)
 {
-s->Printf("\n%snew value: %s", prefix, 
m_new_value_sp->GetValueAsCString());
+if (m_new_value_sp->GetValueAsCString())
+s->Printf("\n%snew value: %s", prefix, 
m_new_value_sp->GetValueAsCString());
+else
+s->Printf("\n%snew value: %s", prefix, 
m_new_value_sp->GetSummaryAsCString());
 }

It would be nice to store these in local variables and clean up the code a bit 
like:

```
const char *old_value_cstr =  m_old_value_sp->GetValueAsCString();
if (old_value_cstr && old_value_cstr[0])
s->Printf("\n%sold value: %s", prefix, old_value_cstr);
else
{
const char *old_summary_cstr =  m_old_value_sp-> GetSummaryAsCString();
if (old_summary_cstr && old_summary_cstr[0])
s->Printf("\n%sold value: %s", prefix, old_summary_cstr);
}

```

This way we don't ever print "old value: " when there is no value or summary...


Repository:
  rL LLVM

http://reviews.llvm.org/D13202



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13154: [MIPS] Use Address::GetAddressClass() instead of elf flags to decide address space of an address

[Zachary Turner via lldb-commits]

zturner added a subscriber: zturner.
zturner added a comment.

You should add a test for this.  You might need a `@skipIfNotMips` decorator


Repository:
  rL LLVM

http://reviews.llvm.org/D13154



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13268: Simple readline functionality for interactive python on linux.

[Todd Fiala via lldb-commits]

tfiala added a comment.

And if you'd prefer, I'd be happy to put in that patch as is (the one I tested 
with both libedit included and libedit excluded).


Repository:
  rL LLVM

http://reviews.llvm.org/D13268



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13448: Update swig generation shell scripts to run under Python 3.x

[Todd Fiala via lldb-commits]

tfiala added a comment.

Okay all that said, the change itself looks fine. Have you tried it on Linux?  
I'll give it a go there in the morning.  If it doesn't break there, I have no 
issues with this change.


http://reviews.llvm.org/D13448



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13404: Teach CMake to find versions of Python != 2.7

[Vadim Macagon via lldb-commits]

enlight added inline comments.


Comment at: cmake/modules/LLDBConfig.cmake:113
@@ +112,3 @@
+  set (PYTHON_LIBRARY ${PYTHON_LIBRARY} PARENT_SCOPE)
+  set (PYTHON_DLL ${PYTHON_LIBRARY} PYTHON_DLL PARENT_SCOPE)
+  set (PYTHON_INCLUDE_DIRS ${PYTHON_INCLUDE_DIRS} PARENT_SCOPE)

You missed :P


Comment at: cmake/modules/LLDBConfig.cmake:140
@@ -106,1 +139,3 @@
+  
+  if (PYTHON_LIBRARY)
 include_directories(${PYTHON_INCLUDE_DIRS})

Can we make this `if (PYTHON_INCLUDE_DIRS)` instead?


http://reviews.llvm.org/D13404



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r249377 - [LLDB][MIPS] Fix hit_count for mips watchpoints

[Mohit K. Bhakkad via lldb-commits]

Author: mohit.bhakkad
Date: Tue Oct  6 00:25:17 2015
New Revision: 249377

URL: http://llvm.org/viewvc/llvm-project?rev=249377=rev
Log:
[LLDB][MIPS] Fix hit_count for mips watchpoints

Reviewers: clayborg, jingham.
Subscribers: jaydeep, bhushan, dsanders, sagar, nitesh.jain, zturner, 
jasonmolenda, lldb-commits.
Differential Revision: http://reviews.llvm.org/D13241

Modified:
lldb/trunk/source/Target/StopInfo.cpp

Modified: lldb/trunk/source/Target/StopInfo.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/StopInfo.cpp?rev=249377=249376=249377=diff
==
--- lldb/trunk/source/Target/StopInfo.cpp (original)
+++ lldb/trunk/source/Target/StopInfo.cpp Tue Oct  6 00:25:17 2015
@@ -757,9 +757,12 @@ protected:
 {
 WatchpointSP wp_hit_sp = 
thread_sp->CalculateTarget()->GetWatchpointList().FindByAddress(m_watch_hit_addr);
 if (!wp_hit_sp)
+{
 m_should_stop = false;
+wp_sp->IncrementFalseAlarmsAndReviseHitCount();
+}
 }
-
+
 if (m_should_stop && wp_sp->GetConditionText() != NULL)
 {
 // We need to make sure the user sees any parse errors in 
their condition, so we'll hook the


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13241: [LLDB][MIPS] Fix hit_count for mips watchpoints

[Mohit Bhakkad via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL249377: [LLDB][MIPS] Fix hit_count for mips watchpoints 
(authored by mohit.bhakkad).

Changed prior to commit:
  http://reviews.llvm.org/D13241?vs=35958=36583#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D13241

Files:
  lldb/trunk/source/Target/StopInfo.cpp

Index: lldb/trunk/source/Target/StopInfo.cpp
===
--- lldb/trunk/source/Target/StopInfo.cpp
+++ lldb/trunk/source/Target/StopInfo.cpp
@@ -757,9 +757,12 @@
 {
 WatchpointSP wp_hit_sp = 
thread_sp->CalculateTarget()->GetWatchpointList().FindByAddress(m_watch_hit_addr);
 if (!wp_hit_sp)
+{
 m_should_stop = false;
+wp_sp->IncrementFalseAlarmsAndReviseHitCount();
+}
 }
-
+
 if (m_should_stop && wp_sp->GetConditionText() != NULL)
 {
 // We need to make sure the user sees any parse errors in 
their condition, so we'll hook the


Index: lldb/trunk/source/Target/StopInfo.cpp
===
--- lldb/trunk/source/Target/StopInfo.cpp
+++ lldb/trunk/source/Target/StopInfo.cpp
@@ -757,9 +757,12 @@
 {
 WatchpointSP wp_hit_sp = thread_sp->CalculateTarget()->GetWatchpointList().FindByAddress(m_watch_hit_addr);
 if (!wp_hit_sp)
+{
 m_should_stop = false;
+wp_sp->IncrementFalseAlarmsAndReviseHitCount();
+}
 }
-
+
 if (m_should_stop && wp_sp->GetConditionText() != NULL)
 {
 // We need to make sure the user sees any parse errors in their condition, so we'll hook the
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13448: Update swig generation shell scripts to run under Python 3.x

[Todd Fiala via lldb-commits]

tfiala added a comment.

In http://reviews.llvm.org/D13448#260195, @tfiala wrote:

> In http://reviews.llvm.org/D13448#260194, @tfiala wrote:
>
> > > Todd, I'm putting you as the reviewer since you seem to be the most 
> > > knowledgeable about Python. If you can think of someone better, let me 
> > > know.
> >
> >
> > I'll have a look tonight.
>
>
> I may try to switch over the Xcode build to use it as well, at the same time.


I attempted to drop in the script on the OS X Xcode build tonight.  Detailed 
here:
https://llvm.org/bugs/show_bug.cgi?id=25062

It ends up not being a fast operation.  I've spent a few hours getting it going 
but I still have link errors.

I was hoping I could have that working, and then make sure this doesn't break 
it, but at this point I don't have my desired starting condition (plugged into 
Xcode) satisfied.

I'll have to look at this tomorrow and I'll do it from a Linux slant since I 
may not have time at the moment to put more effort into getting it running on 
the Xcode side.


http://reviews.llvm.org/D13448



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13241: [LLDB][MIPS] Fix hit_count for mips watchpoints

[Greg Clayton via lldb-commits]

clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

Back from vacation, sorry for the delay. Looks good.


Repository:
  rL LLVM

http://reviews.llvm.org/D13241



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13296: [LLDB] Fix watchpoint ignore feature for architectures with watchpoint_exceptions_received=before

[Greg Clayton via lldb-commits]

clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.

I will defer to Jim Ingham on this one.


Repository:
  rL LLVM

http://reviews.llvm.org/D13296



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D13448: Update swig generation shell scripts to run under Python 3.x

[Zachary Turner via lldb-commits]

zturner created this revision.
zturner added a reviewer: tfiala.
zturner added a subscriber: lldb-commits.

Todd, I'm putting you as the reviewer since you seem to be the most 
knowledgeable about Python.  If you can think of someone better, let me know.

The goal here is for these scripts to be able to run successfully under both 
Python 2.x and Python 3.5.  In most cases this was fairly straightforward.  
Only 1 or 2 places needed a version-switch.


http://reviews.llvm.org/D13448

Files:
  scripts/Python/buildSwigPython.py
  scripts/Python/modify-python-lldb.py
  scripts/buildSwigWrapperClasses.py
  scripts/finishSwigWrapperClasses.py
  scripts/utilsArgsParse.py
  scripts/utilsDebug.py
  scripts/utilsOsType.py

Index: scripts/utilsOsType.py
===
--- scripts/utilsOsType.py
+++ scripts/utilsOsType.py
@@ -26,22 +26,32 @@
 # Authors:  Illya Rudkin 28/11/2013.
 # Changes:  None.
 #--
-class EnumOsType( object ):
-values = [  "Unknown",
-"Darwin",
-"FreeBSD",
-"Linux", 
-"NetBSD",
-"Windows" ]
-class __metaclass__( type ):
+if sys.version_info.major >= 3:
+from enum import Enum
+class EnumOsType(Enum):
+Unknown = 0
+Darwin = 1
+FreeBSD = 2
+Linux = 3
+NetBSD = 4
+Windows = 5
+else:
+class EnumOsType( object ):
+values = [  "Unknown",
+"Darwin",
+"FreeBSD",
+"Linux", 
+"NetBSD",
+"Windows" ]
+class __metaclass__( type ):
 #++---
 # Details:  Fn acts as an enumeration.
 # Args: vName - (R) Enumeration to match.
 # Returns:  Int - Matching enumeration/index.
 # Throws:   None.
 #--
-def __getattr__( self, vName ):
-return self.values.index( vName );
+def __getattr__( self, vName ):
+return self.values.index( vName );
 
 #++---
 # Details:  Reverse fast lookup of the values list.
@@ -49,8 +59,8 @@
 # Returns:  Str - text description matching enumeration.
 # Throws:   None.
 #--
-def name_of( self, vI ):
-return EnumOsType.values[ vI ];
+def name_of( self, vI ):
+return EnumOsType.values[ vI ];
 
 #-
 #-
Index: scripts/utilsDebug.py
===
--- scripts/utilsDebug.py
+++ scripts/utilsDebug.py
@@ -55,9 +55,9 @@
 	def dump_object( self, vstrText, vObject ):
 		if CDebugFnVerbose.bVerboseOn == False:
 			return;
-		print "%d%s> Dp: %s" % (CDebugFnVerbose.__nLevel, self.__get_dots(), 
-vstrText),;
-		print vObject;
+		sys.stdout.write("%d%s> Dp: %s" % (CDebugFnVerbose.__nLevel, self.__get_dots(), 
+vstrText));
+		print(vObject);
 	
 	#++
 	# Details:	Print out some progress text given by the client.
@@ -69,8 +69,8 @@
 	def dump_text( self, vstrText ):
 		if CDebugFnVerbose.bVerboseOn == False:
 			return;
-		print "%d%s> Dp: %s" % (CDebugFnVerbose.__nLevel, self.__get_dots(),
-vstrText);
+		print("%d%s> Dp: %s" % (CDebugFnVerbose.__nLevel, self.__get_dots(),
+vstrText));
 
 	# Private methods:
 	def __init__( self, vstrFnName ):
@@ -100,8 +100,8 @@
 	#--
 	def __indent_back( self ):
 		if CDebugFnVerbose.bVerboseOn:
-			print "%d%s< fn: %s" % (CDebugFnVerbose.__nLevel, self.__get_dots(),
-	self.__strFnName);
+			print("%d%s< fn: %s" % (CDebugFnVerbose.__nLevel, self.__get_dots(),
+	self.__strFnName));
 		CDebugFnVerbose.__nLevel -= 1;
 
 	#++
@@ -116,8 +116,8 @@
 		CDebugFnVerbose.__nLevel += 1;
 		self.__strFnName = vstrFnName;
 		if CDebugFnVerbose.bVerboseOn:
-			print "%d%s> fn: %s" % ( CDebugFnVerbose.__nLevel, self.__get_dots(), 
-	 self.__strFnName);
+			print("%d%s> fn: %s" % ( CDebugFnVerbose.__nLevel, self.__get_dots(), 
+	 self.__strFnName));
 
 	# Private statics attributes:
 	__nLevel = 0;	# Indentation level counter
Index: scripts/utilsArgsParse.py
===
--- scripts/utilsArgsParse.py
+++ scripts/utilsArgsParse.py
@@ -87,7 +87,7 @@
 	
 	# Count the number of mandatory args required (if any one found)
 	countMandatory = 0;
-	for opt, man in vDictArgReq.iteritems():
+	for opt, man in vDictArgReq.items():
 		if man == "m":
 		  countMandatory = countMandatory + 1;
 	
Index: scripts/finishSwigWrapperClasses.py

Re: [Lldb-commits] [PATCH] D13362: Enhance test runner timeout logic to detect successful completion of spawned process when stdout/stderr are shared to still-existing child processes

[Todd Fiala via lldb-commits]

tfiala added a comment.

In http://reviews.llvm.org/D13362#259543, @labath wrote:

> In http://reviews.llvm.org/D13362#258972, @tfiala wrote:
>
> > I've fixed:
> >  https://llvm.org/bugs/show_bug.cgi?id=25019
> >
> > I think for now I am not interested in trying to tackle the intent of this 
> > change as it unduly complicates the timeout detection logic.
> >
> > I am okay with saying:
> >  "If you run a process http://reviews.llvm.org/P1, and that process creates 
> > child processes C1..CN, and shares the stdout/stderr file handles from 
> > http://reviews.llvm.org/P1 to C1..CN, and if http://reviews.llvm.org/P1 
> > exits, we don't detect the exit until all stdout/stderr handles shared with 
> > C1..CN are closed."  That's just a bad test if it is leaving children 
> > around.  It will time out.
>
>
> Sounds good to me. This motivates people to write correct tests, which I 
> think is good. My main concern was not leaving those children around after we 
> time out, which I believe you fixed already.


Yep, great thanks!

I just closed the bugzilla ticket for this feature as WONTFIX.  If we really 
want this later, we can revisit.


http://reviews.llvm.org/D13362



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13282: [MIPS] Emulate microMIPS instructions

[Greg Clayton via lldb-commits]

clayborg accepted this revision.
clayborg added a comment.

Back from vacation, sorry for the delay. Looks good.


Repository:
  rL LLVM

http://reviews.llvm.org/D13282



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r249256 - cmake: ensure readline python module target is added before finishing swig.

[Todd Fiala via lldb-commits]

Oops, missed this.  I see how it can be gnarly finding things in
lldb-commits!



On Sat, Oct 3, 2015 at 7:25 PM, Zachary Turner  wrote:

> You just reminded me.  Since you've been hitting a lot of this stuff
> lately and doing a lot of great cleanup work, how do you feel about
> integrating the swig python scripts into the Xcode build?
>

Can you tell me more about what you had in mind?  (I am actually way more
familiar with how we do it on the cmake side than the Xcode side!)


>   I've been meaning to do this for a long time but I don't have enough
> Xcode knowledge.
>

I'm pretty sure I can do whatever we want to try to do here, as soon as I
know what that is.  The only thing that might be interesting is we have a
group of external folks using a cmake build on OS X and not using
xcodebuild.  So whatever change you're thinking here needs to still work
for a straight cmake approach (I think).


>   Having parallel scripts for Xcode and CMake introduces an obvious
> technical debt that we could get rid of if there was just one script.
>
> As far as I know it should be a drop-in replacement, and it supports
> everything the shell scripts currently support.  It's been lingering long
> enough that there's obviously no rush, but if you ever feel the urge to
> look at it, I think it would be easy.
>
>
Sure, tell me a bit more and I can look into getting this on my queue.

-Todd



> On Sat, Oct 3, 2015 at 6:30 PM Todd Fiala via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
>
>> Author: tfiala
>> Date: Sat Oct  3 20:28:51 2015
>> New Revision: 249256
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=249256=rev
>> Log:
>> cmake: ensure readline python module target is added before finishing
>> swig.
>>
>> When the readline target exists (only for non-Android Linux currently),
>> ensure that target is made a dependency of the finish_swig python-wrap-up
>> steps.  This ensures it is built when building the lldb target.
>>
>> Fixes:
>> https://llvm.org/bugs/show_bug.cgi?id=25038
>>
>> Modified:
>> lldb/trunk/CMakeLists.txt
>>
>> Modified: lldb/trunk/CMakeLists.txt
>> URL:
>> http://llvm.org/viewvc/llvm-project/lldb/trunk/CMakeLists.txt?rev=249256=249255=249256=diff
>>
>> ==
>> --- lldb/trunk/CMakeLists.txt (original)
>> +++ lldb/trunk/CMakeLists.txt Sat Oct  3 20:28:51 2015
>> @@ -24,6 +24,12 @@ if (NOT LLDB_DISABLE_PYTHON)
>>  # We depend on liblldb being built before we can do this step.
>>  add_dependencies(finish_swig liblldb argdumper)
>>
>> +# If we build the readline module, we depend on that happening
>> +# first.
>> +if (TARGET readline)
>> +add_dependencies(finish_swig readline)
>> +endif()
>> +
>>  # Ensure we do the python post-build step when building lldb.
>>  add_dependencies(lldb finish_swig)
>>
>>
>>
>> ___
>> lldb-commits mailing list
>> lldb-commits@lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>>
>


-- 
-Todd
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13300: Run tests with dwo symbol files

[Greg Clayton via lldb-commits]

clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

Back from vacation, sorry for the delay. Looks good.


http://reviews.llvm.org/D13300



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r249256 - cmake: ensure readline python module target is added before finishing swig.

[Zachary Turner via lldb-commits]

So on the Xcode side, there is a script that runs called
`build-swig-wrapper-classes.sh` that converts the SWIG into python stuff.
On the Windows side, there's no such thing as shell scripts, so we wrote
python scripts instead.  It's called buildSwigWrapperClasses.py, in the
same folder ad the shell script.

The command line syntax is different, but functionally they should be
equivalent.  To see what the syntax looks like for the python file, you
could probably just edit the CMakeLists.txt and print out the command line
during CMake generation time. Then change the shell script in the Xcode
project to use the python script instead, and finally delete the shell
script from the repo.

On Mon, Oct 5, 2015 at 12:55 PM Todd Fiala  wrote:

> Oops, missed this.  I see how it can be gnarly finding things in
> lldb-commits!
>
>
>
> On Sat, Oct 3, 2015 at 7:25 PM, Zachary Turner  wrote:
>
>> You just reminded me.  Since you've been hitting a lot of this stuff
>> lately and doing a lot of great cleanup work, how do you feel about
>> integrating the swig python scripts into the Xcode build?
>>
>
> Can you tell me more about what you had in mind?  (I am actually way more
> familiar with how we do it on the cmake side than the Xcode side!)
>
>
>>   I've been meaning to do this for a long time but I don't have enough
>> Xcode knowledge.
>>
>
> I'm pretty sure I can do whatever we want to try to do here, as soon as I
> know what that is.  The only thing that might be interesting is we have a
> group of external folks using a cmake build on OS X and not using
> xcodebuild.  So whatever change you're thinking here needs to still work
> for a straight cmake approach (I think).
>
>
>>   Having parallel scripts for Xcode and CMake introduces an obvious
>> technical debt that we could get rid of if there was just one script.
>>
>> As far as I know it should be a drop-in replacement, and it supports
>> everything the shell scripts currently support.  It's been lingering long
>> enough that there's obviously no rush, but if you ever feel the urge to
>> look at it, I think it would be easy.
>>
>>
> Sure, tell me a bit more and I can look into getting this on my queue.
>
> -Todd
>
>
>
>> On Sat, Oct 3, 2015 at 6:30 PM Todd Fiala via lldb-commits <
>> lldb-commits@lists.llvm.org> wrote:
>>
>>> Author: tfiala
>>> Date: Sat Oct  3 20:28:51 2015
>>> New Revision: 249256
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=249256=rev
>>> Log:
>>> cmake: ensure readline python module target is added before finishing
>>> swig.
>>>
>>> When the readline target exists (only for non-Android Linux currently),
>>> ensure that target is made a dependency of the finish_swig python-wrap-up
>>> steps.  This ensures it is built when building the lldb target.
>>>
>>> Fixes:
>>> https://llvm.org/bugs/show_bug.cgi?id=25038
>>>
>>> Modified:
>>> lldb/trunk/CMakeLists.txt
>>>
>>> Modified: lldb/trunk/CMakeLists.txt
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/lldb/trunk/CMakeLists.txt?rev=249256=249255=249256=diff
>>>
>>> ==
>>> --- lldb/trunk/CMakeLists.txt (original)
>>> +++ lldb/trunk/CMakeLists.txt Sat Oct  3 20:28:51 2015
>>> @@ -24,6 +24,12 @@ if (NOT LLDB_DISABLE_PYTHON)
>>>  # We depend on liblldb being built before we can do this step.
>>>  add_dependencies(finish_swig liblldb argdumper)
>>>
>>> +# If we build the readline module, we depend on that happening
>>> +# first.
>>> +if (TARGET readline)
>>> +add_dependencies(finish_swig readline)
>>> +endif()
>>> +
>>>  # Ensure we do the python post-build step when building lldb.
>>>  add_dependencies(lldb finish_swig)
>>>
>>>
>>>
>>> ___
>>> lldb-commits mailing list
>>> lldb-commits@lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>>>
>>
>
>
> --
> -Todd
>
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13201: Fix segmentation fault in lldb_private::Symbols::LocateExecutableSymbolFile()

[Greg Clayton via lldb-commits]

clayborg accepted this revision.
clayborg added a comment.

Back from vacation, sorry for the delay. Looks good.


Repository:
  rL LLVM

http://reviews.llvm.org/D13201



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13270: Remove instance reference to static member function

[Greg Clayton via lldb-commits]

clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

Back from vacation, sorry for the delay. Looks good.


http://reviews.llvm.org/D13270



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13350: [lldb] Fix evaluation of qualified global variables

[Greg Clayton via lldb-commits]

clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.

DeclBase.h will need to be submitted against clang, not LLDB.

Then add Sean Callanan and Jim Ingham as the reviewers as they are the masters 
of the expression parser. I helped to get the CompilerDecl and 
CompilerDeclContext stuff in, but Sean and Jim should review expression parser 
changes.

Please add Jim Ingham and Sean Callanan as reviewers.


http://reviews.llvm.org/D13350



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13271: Fix Darwin build of lldb-server.

[Greg Clayton via lldb-commits]

clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

Back from vacation, sorry for the delay. Looks good.


http://reviews.llvm.org/D13271



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

[Greg Clayton via lldb-commits]

clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

Back from vacation, sorry for the delay. Looks good if Enrico is happy.


http://reviews.llvm.org/D13058



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13362: Enhance test runner timeout logic to detect successful completion of spawned process when stdout/stderr are shared to still-existing child processes

[Pavel Labath via lldb-commits]

labath added a comment.

In http://reviews.llvm.org/D13362#258972, @tfiala wrote:

> I've fixed:
>  https://llvm.org/bugs/show_bug.cgi?id=25019
>
> I think for now I am not interested in trying to tackle the intent of this 
> change as it unduly complicates the timeout detection logic.
>
> I am okay with saying:
>  "If you run a process http://reviews.llvm.org/P1, and that process creates 
> child processes C1..CN, and shares the stdout/stderr file handles from 
> http://reviews.llvm.org/P1 to C1..CN, and if http://reviews.llvm.org/P1 
> exits, we don't detect the exit until all stdout/stderr handles shared with 
> C1..CN are closed."  That's just a bad test if it is leaving children around. 
>  It will time out.


Sounds good to me. This motivates people to write correct tests, which I think 
is good. My main concern was not leaving those children around after we time 
out, which I believe you fixed already.


http://reviews.llvm.org/D13362



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r249366 - Introduce a FormattersMatchData class which contains all the information that data formatters need in one place, and also allows for lazy computation of expensive chunk

[Enrico Granata via lldb-commits]

Author: enrico
Date: Mon Oct  5 20:02:47 2015
New Revision: 249366

URL: http://llvm.org/viewvc/llvm-project?rev=249366=rev
Log:
Introduce a FormattersMatchData class which contains all the information that 
data formatters need in one place, and also allows for lazy computation of 
expensive chunks of information if need be

This is a NFC commit that is essentially plumbing the new currency through the 
system


Modified:
lldb/trunk/include/lldb/DataFormatters/FormatClasses.h
lldb/trunk/include/lldb/DataFormatters/FormatManager.h
lldb/trunk/include/lldb/DataFormatters/LanguageCategory.h
lldb/trunk/include/lldb/DataFormatters/TypeCategoryMap.h
lldb/trunk/lldb.xcodeproj/xcshareddata/xcschemes/lldb-tool.xcscheme
lldb/trunk/source/DataFormatters/FormatClasses.cpp
lldb/trunk/source/DataFormatters/FormatManager.cpp
lldb/trunk/source/DataFormatters/LanguageCategory.cpp
lldb/trunk/source/DataFormatters/TypeCategoryMap.cpp

Modified: lldb/trunk/include/lldb/DataFormatters/FormatClasses.h
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/DataFormatters/FormatClasses.h?rev=249366=249365=249366=diff
==
--- lldb/trunk/include/lldb/DataFormatters/FormatClasses.h (original)
+++ lldb/trunk/include/lldb/DataFormatters/FormatClasses.h Mon Oct  5 20:02:47 
2015
@@ -118,6 +118,36 @@ private:
 };
 
 typedef std::vector FormattersMatchVector;
+typedef std::vector CandidateLanguagesVector;
+
+class FormattersMatchData
+{
+public:
+FormattersMatchData (ValueObject&,
+ lldb::DynamicValueType);
+
+FormattersMatchVector
+GetMatchesVector ();
+
+ConstString
+GetTypeForCache ();
+
+CandidateLanguagesVector
+GetCandidateLanguages ();
+
+ValueObject&
+GetValueObject ();
+
+lldb::DynamicValueType
+GetDynamicValueType ();
+
+private:
+ValueObject& m_valobj;
+lldb::DynamicValueType m_dynamic_value_type;
+std::pair m_formatters_match_vector;
+ConstString m_type_for_cache;
+CandidateLanguagesVector m_candidate_languages;
+};
 
 class TypeNameSpecifierImpl
 {

Modified: lldb/trunk/include/lldb/DataFormatters/FormatManager.h
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/DataFormatters/FormatManager.h?rev=249366=249365=249366=diff
==
--- lldb/trunk/include/lldb/DataFormatters/FormatManager.h (original)
+++ lldb/trunk/include/lldb/DataFormatters/FormatManager.h Mon Oct  5 20:02:47 
2015
@@ -311,16 +311,16 @@ private:
 ConstString m_vectortypes_category_name;
 
 lldb::TypeFormatImplSP
-GetHardcodedFormat (ValueObject&,lldb::DynamicValueType);
+GetHardcodedFormat (FormattersMatchData&);
 
 lldb::TypeSummaryImplSP
-GetHardcodedSummaryFormat (ValueObject&,lldb::DynamicValueType);
+GetHardcodedSummaryFormat (FormattersMatchData&);
 
 lldb::SyntheticChildrenSP
-GetHardcodedSyntheticChildren (ValueObject&,lldb::DynamicValueType);
+GetHardcodedSyntheticChildren (FormattersMatchData&);
 
 lldb::TypeValidatorImplSP
-GetHardcodedValidator (ValueObject&,lldb::DynamicValueType);
+GetHardcodedValidator (FormattersMatchData&);
 
 TypeCategoryMap&
 GetCategories ()
@@ -338,6 +338,8 @@ private:
 
 void
 LoadVectorFormatters ();
+
+friend class FormattersMatchData;
 };
 
 } // namespace lldb_private

Modified: lldb/trunk/include/lldb/DataFormatters/LanguageCategory.h
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/DataFormatters/LanguageCategory.h?rev=249366=249365=249366=diff
==
--- lldb/trunk/include/lldb/DataFormatters/LanguageCategory.h (original)
+++ lldb/trunk/include/lldb/DataFormatters/LanguageCategory.h Mon Oct  5 
20:02:47 2015
@@ -31,51 +31,39 @@ public:
 LanguageCategory (lldb::LanguageType lang_type);
 
 bool
-Get (ValueObject& valobj,
- lldb::DynamicValueType dynamic,
- FormattersMatchVector matches,
+Get (FormattersMatchData& match_data,
  lldb::TypeFormatImplSP& format_sp);
 
 bool
-Get (ValueObject& valobj,
- lldb::DynamicValueType dynamic,
- FormattersMatchVector matches,
+Get (FormattersMatchData& match_data,
  lldb::TypeSummaryImplSP& format_sp);
 
 bool
-Get (ValueObject& valobj,
- lldb::DynamicValueType dynamic,
- FormattersMatchVector matches,
+Get (FormattersMatchData& match_data,
  lldb::SyntheticChildrenSP& format_sp);
 
 bool
-Get (ValueObject& valobj,
- lldb::DynamicValueType dynamic,
- FormattersMatchVector matches,
+Get (FormattersMatchData& match_data,
  lldb::TypeValidatorImplSP& format_sp);
 
 bool
-GetHardcoded 

Re: [Lldb-commits] [PATCH] D13448: Update swig generation shell scripts to run under Python 3.x

[Todd Fiala via lldb-commits]

tfiala added a comment.

> Todd, I'm putting you as the reviewer since you seem to be the most 
> knowledgeable about Python. If you can think of someone better, let me know.


I'll have a look tonight.


http://reviews.llvm.org/D13448



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13448: Update swig generation shell scripts to run under Python 3.x

[Todd Fiala via lldb-commits]

tfiala added a comment.

In http://reviews.llvm.org/D13448#260194, @tfiala wrote:

> > Todd, I'm putting you as the reviewer since you seem to be the most 
> > knowledgeable about Python. If you can think of someone better, let me know.
>
>
> I'll have a look tonight.


I may try to switch over the Xcode build to use it as well, at the same time.


http://reviews.llvm.org/D13448



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r249256 - cmake: ensure readline python module target is added before finishing swig.

[Todd Fiala via lldb-commits]

Filed this bugzilla bug:
https://llvm.org/bugs/show_bug.cgi?id=25062

to capture.

On Mon, Oct 5, 2015 at 1:12 PM, Todd Fiala  wrote:

> Oh I see what you mean.
>
> Yeah that would be easy enough to do.  I'll put it on a cleanup-priority
> list.  (Not promising I'll hit it very soon but I will do it).
>
> On Mon, Oct 5, 2015 at 1:08 PM, Zachary Turner  wrote:
>
>> So on the Xcode side, there is a script that runs called
>> `build-swig-wrapper-classes.sh` that converts the SWIG into python stuff.
>> On the Windows side, there's no such thing as shell scripts, so we wrote
>> python scripts instead.  It's called buildSwigWrapperClasses.py, in the
>> same folder ad the shell script.
>>
>> The command line syntax is different, but functionally they should be
>> equivalent.  To see what the syntax looks like for the python file, you
>> could probably just edit the CMakeLists.txt and print out the command line
>> during CMake generation time. Then change the shell script in the Xcode
>> project to use the python script instead, and finally delete the shell
>> script from the repo.
>>
>> On Mon, Oct 5, 2015 at 12:55 PM Todd Fiala  wrote:
>>
>>> Oops, missed this.  I see how it can be gnarly finding things in
>>> lldb-commits!
>>>
>>>
>>>
>>> On Sat, Oct 3, 2015 at 7:25 PM, Zachary Turner 
>>> wrote:
>>>
 You just reminded me.  Since you've been hitting a lot of this stuff
 lately and doing a lot of great cleanup work, how do you feel about
 integrating the swig python scripts into the Xcode build?

>>>
>>> Can you tell me more about what you had in mind?  (I am actually way
>>> more familiar with how we do it on the cmake side than the Xcode side!)
>>>
>>>
   I've been meaning to do this for a long time but I don't have enough
 Xcode knowledge.

>>>
>>> I'm pretty sure I can do whatever we want to try to do here, as soon as
>>> I know what that is.  The only thing that might be interesting is we have a
>>> group of external folks using a cmake build on OS X and not using
>>> xcodebuild.  So whatever change you're thinking here needs to still work
>>> for a straight cmake approach (I think).
>>>
>>>
   Having parallel scripts for Xcode and CMake introduces an obvious
 technical debt that we could get rid of if there was just one script.

 As far as I know it should be a drop-in replacement, and it supports
 everything the shell scripts currently support.  It's been lingering long
 enough that there's obviously no rush, but if you ever feel the urge to
 look at it, I think it would be easy.


>>> Sure, tell me a bit more and I can look into getting this on my queue.
>>>
>>> -Todd
>>>
>>>
>>>
 On Sat, Oct 3, 2015 at 6:30 PM Todd Fiala via lldb-commits <
 lldb-commits@lists.llvm.org> wrote:

> Author: tfiala
> Date: Sat Oct  3 20:28:51 2015
> New Revision: 249256
>
> URL: http://llvm.org/viewvc/llvm-project?rev=249256=rev
> Log:
> cmake: ensure readline python module target is added before finishing
> swig.
>
> When the readline target exists (only for non-Android Linux currently),
> ensure that target is made a dependency of the finish_swig
> python-wrap-up
> steps.  This ensures it is built when building the lldb target.
>
> Fixes:
> https://llvm.org/bugs/show_bug.cgi?id=25038
>
> Modified:
> lldb/trunk/CMakeLists.txt
>
> Modified: lldb/trunk/CMakeLists.txt
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/CMakeLists.txt?rev=249256=249255=249256=diff
>
> ==
> --- lldb/trunk/CMakeLists.txt (original)
> +++ lldb/trunk/CMakeLists.txt Sat Oct  3 20:28:51 2015
> @@ -24,6 +24,12 @@ if (NOT LLDB_DISABLE_PYTHON)
>  # We depend on liblldb being built before we can do this step.
>  add_dependencies(finish_swig liblldb argdumper)
>
> +# If we build the readline module, we depend on that happening
> +# first.
> +if (TARGET readline)
> +add_dependencies(finish_swig readline)
> +endif()
> +
>  # Ensure we do the python post-build step when building lldb.
>  add_dependencies(lldb finish_swig)
>
>
>
> ___
> lldb-commits mailing list
> lldb-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>

>>>
>>>
>>> --
>>> -Todd
>>>
>>
>
>
> --
> -Todd
>



-- 
-Todd
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r249361 - SBTarget::Attach(SBAttachInfo &) was changed to not be asynchronous back in February and this affected Xcode's abililty to cancel an attach to process by name.

[Greg Clayton via lldb-commits]

Author: gclayton
Date: Mon Oct  5 17:58:37 2015
New Revision: 249361

URL: http://llvm.org/viewvc/llvm-project?rev=249361=rev
Log:
SBTarget::Attach(SBAttachInfo &) was changed to not be asynchronous back in 
February and this affected Xcode's abililty to cancel an attach to process by 
name.

Added the ability to specify if an attach by name should be synchronous or not 
in SBAttachInfo and ProcessAttachInfo.




Modified:
lldb/trunk/include/lldb/API/SBAttachInfo.h
lldb/trunk/include/lldb/Target/Process.h
lldb/trunk/scripts/interface/SBAttachInfo.i
lldb/trunk/source/API/SBAttachInfo.cpp
lldb/trunk/source/Target/Target.cpp

Modified: lldb/trunk/include/lldb/API/SBAttachInfo.h
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/API/SBAttachInfo.h?rev=249361=249360=249361=diff
==
--- lldb/trunk/include/lldb/API/SBAttachInfo.h (original)
+++ lldb/trunk/include/lldb/API/SBAttachInfo.h Mon Oct  5 17:58:37 2015
@@ -23,8 +23,47 @@ public:
 
 SBAttachInfo (lldb::pid_t pid);
 
+//--
+/// Attach to a process by name.
+///
+/// This function implies that a future call to SBTarget::Attach(...)
+/// will be synchronous.
+///
+/// @param[in] path
+/// A full or partial name for the process to attach to.
+///
+/// @param[in] wait_for
+/// If \b false, attach to an existing process whose name matches.
+/// If \b true, then wait for the next process whose name matches.
+//--
 SBAttachInfo (const char *path, bool wait_for);
 
+//--
+/// Attach to a process by name.
+///
+/// Future calls to SBTarget::Attach(...) will be synchronous or
+/// asynchronous depending on the \a async argument.
+///
+/// @param[in] path
+/// A full or partial name for the process to attach to.
+///
+/// @param[in] wait_for
+/// If \b false, attach to an existing process whose name matches.
+/// If \b true, then wait for the next process whose name matches.
+///
+/// @param[in] async
+/// If \b false, then the SBTarget::Attach(...) call will be a
+/// synchronous call with no way to cancel the attach in
+/// progress.
+/// If \b true, then the SBTarget::Attach(...) function will
+/// return immediately and clients are expected to wait for a
+/// process eStateStopped event if a suitable process is
+/// eventually found. If the client wants to cancel the event,
+/// SBProcess::Stop() can be called and an eStateExited process
+/// event will be delivered.
+//--
+SBAttachInfo (const char *path, bool wait_for, bool async);
+
 SBAttachInfo (const SBAttachInfo );
 
 ~SBAttachInfo();
@@ -47,9 +86,45 @@ public:
 bool
 GetWaitForLaunch ();
 
+//--
+/// Set attach by process name settings.
+///
+/// Designed to be used after a call to SBAttachInfo::SetExecutable().
+/// This function implies that a call to SBTarget::Attach(...) will
+/// be synchronous.
+///
+/// @param[in] wait_for
+/// If \b false, attach to an existing process whose name matches.
+/// If \b true, then wait for the next process whose name matches.
+//--
 void
 SetWaitForLaunch (bool b);
 
+//--
+/// Set attach by process name settings.
+///
+/// Designed to be used after a call to SBAttachInfo::SetExecutable().
+/// Future calls to SBTarget::Attach(...) will be synchronous or
+/// asynchronous depending on the \a async argument.
+///
+/// @param[in] wait_for
+/// If \b false, attach to an existing process whose name matches.
+/// If \b true, then wait for the next process whose name matches.
+///
+/// @param[in] async
+/// If \b false, then the SBTarget::Attach(...) call will be a
+/// synchronous call with no way to cancel the attach in
+/// progress.
+/// If \b true, then the SBTarget::Attach(...) function will
+/// return immediately and clients are expected to wait for a
+/// process eStateStopped event if a suitable process is
+/// eventually found. If the client wants to cancel the event,
+/// SBProcess::Stop() can be called and an eStateExited process
+/// event will be delivered.
+//--
+void
+SetWaitForLaunch (bool b, bool async);
+
 bool
  

Re: [Lldb-commits] [PATCH] D13335: [LLDB][MIPS] Skip invalid size watchpoint testcase for MIPS

[Mohit Bhakkad via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL249299: [LLDB][MIPS] Skip invalid size watchpoint testcase 
for MIPS (authored by mohit.bhakkad).

Changed prior to commit:
  http://reviews.llvm.org/D13335?vs=36212=36498#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D13335

Files:
  lldb/trunk/test/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py

Index: 
lldb/trunk/test/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py
===
--- 
lldb/trunk/test/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py
+++ 
lldb/trunk/test/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py
@@ -87,6 +87,7 @@
 
 @python_api_test
 @expectedFailureAndroid(archs=['arm', 'aarch64']) # Watchpoints not 
supported
+@skipIf(archs=['mips', 'mipsel', 'mips64', 'mips64el']) # No size 
constraint on MIPS for watches
 def test_watch_address_with_invalid_watch_size(self):
 """Exercise SBTarget.WatchAddress() API but pass an invalid 
watch_size."""
 self.build()


Index: lldb/trunk/test/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py
===
--- lldb/trunk/test/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py
+++ lldb/trunk/test/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py
@@ -87,6 +87,7 @@
 
 @python_api_test
 @expectedFailureAndroid(archs=['arm', 'aarch64']) # Watchpoints not supported
+@skipIf(archs=['mips', 'mipsel', 'mips64', 'mips64el']) # No size constraint on MIPS for watches
 def test_watch_address_with_invalid_watch_size(self):
 """Exercise SBTarget.WatchAddress() API but pass an invalid watch_size."""
 self.build()
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r249299 - [LLDB][MIPS] Skip invalid size watchpoint testcase for MIPS

[Mohit K. Bhakkad via lldb-commits]

Author: mohit.bhakkad
Date: Mon Oct  5 05:56:19 2015
New Revision: 249299

URL: http://llvm.org/viewvc/llvm-project?rev=249299=rev
Log:
[LLDB][MIPS] Skip invalid size watchpoint testcase for MIPS

Reviewers: jaydeep.
Subscribers: lldb-commits.
Differential Revision: http://reviews.llvm.org/D13335

Modified:

lldb/trunk/test/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py

Modified: 
lldb/trunk/test/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/test/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py?rev=249299=249298=249299=diff
==
--- 
lldb/trunk/test/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py 
(original)
+++ 
lldb/trunk/test/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py 
Mon Oct  5 05:56:19 2015
@@ -87,6 +87,7 @@ class TargetWatchAddressAPITestCase(Test
 
 @python_api_test
 @expectedFailureAndroid(archs=['arm', 'aarch64']) # Watchpoints not 
supported
+@skipIf(archs=['mips', 'mipsel', 'mips64', 'mips64el']) # No size 
constraint on MIPS for watches
 def test_watch_address_with_invalid_watch_size(self):
 """Exercise SBTarget.WatchAddress() API but pass an invalid 
watch_size."""
 self.build()


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits