[Lldb-commits] [lldb] e13fca4 - [lldb] Remove unused includes (NFC)
Author: Jonas Devlieghere Date: 2020-06-20T22:38:45-07:00 New Revision: e13fca4fac3119ebde8d7c4cf302fee47f95931f URL: https://github.com/llvm/llvm-project/commit/e13fca4fac3119ebde8d7c4cf302fee47f95931f DIFF: https://github.com/llvm/llvm-project/commit/e13fca4fac3119ebde8d7c4cf302fee47f95931f.diff LOG: [lldb] Remove unused includes (NFC) Added: Modified: lldb/include/lldb/Utility/ReproducerInstrumentation.h lldb/source/Host/common/Editline.cpp Removed: diff --git a/lldb/include/lldb/Utility/ReproducerInstrumentation.h b/lldb/include/lldb/Utility/ReproducerInstrumentation.h index f06b8c038818..5fc33ad1a17b 100644 --- a/lldb/include/lldb/Utility/ReproducerInstrumentation.h +++ b/lldb/include/lldb/Utility/ReproducerInstrumentation.h @@ -16,7 +16,6 @@ #include "llvm/ADT/StringRef.h" #include "llvm/Support/ErrorHandling.h" -#include #include #include diff --git a/lldb/source/Host/common/Editline.cpp b/lldb/source/Host/common/Editline.cpp index 56203e37dec0..226e638aba25 100644 --- a/lldb/source/Host/common/Editline.cpp +++ b/lldb/source/Host/common/Editline.cpp @@ -7,7 +7,6 @@ //===--===// #include -#include #include #include "lldb/Host/ConnectionFileDescriptor.h" ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [lldb] 90c1af1 - [lldb][NFC] Add more test for builtin formats
This is failing on some of the debian buildbots so I've temporarily reverted it here: commit 10b43541360efb35a1d33e9cf1e93023ebd69b15 (HEAD -> master, origin/master, origin/HEAD) Author: Eric Christopher Date: Sat Jun 20 14:21:42 2020 Temporarily Revert "[lldb][NFC] Add more test for builtin formats" as it's failing on the debian buildbots: http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/12531 This reverts commit 90c1af106a20785ffd01c0d6a41db8bc0160fd11. buildbot link: http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/12531 Sorry for any inconvenience. -eric On Sat, Jun 20, 2020 at 12:35 PM Raphael Isemann via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > Author: Raphael Isemann > Date: 2020-06-20T19:31:40+02:00 > New Revision: 90c1af106a20785ffd01c0d6a41db8bc0160fd11 > > URL: > https://github.com/llvm/llvm-project/commit/90c1af106a20785ffd01c0d6a41db8bc0160fd11 > DIFF: > https://github.com/llvm/llvm-project/commit/90c1af106a20785ffd01c0d6a41db8bc0160fd11.diff > > LOG: [lldb][NFC] Add more test for builtin formats > > The previous tests apparently missed a few code branches in > DumpDataExtractor > code. Also renames the 'test_instruction' which had the same name as > another > test (and Python therefore ignored the test entirely). > > Added: > > > Modified: > > lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py > > Removed: > > > > > > diff --git > a/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py > b/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py > index 9fefae6bbf5c..1a413a13986a 100644 > --- > a/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py > +++ > b/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py > @@ -42,6 +42,9 @@ def test(self): > self.assertIn("= 0\n", self.getFormatted("float", "0")) > self.assertIn("= 2\n", self.getFormatted("float", "0x4000")) > self.assertIn("= NaN\n", self.getFormatted("float", "-1")) > +# Checks the float16 code. > +self.assertIn("= 2\n", self.getFormatted("float", > "(__UINT16_TYPE__)0x4000")) > +self.assertIn("= error: unsupported byte size (1) for float > format\n", self.getFormatted("float", "'a'")) > > # enumeration > self.assertIn("= 0\n", self.getFormatted("enumeration", "0")) > @@ -59,6 +62,13 @@ def test(self): > > # octal > self.assertIn("= 04553207\n", self.getFormatted("octal", > "1234567")) > +self.assertIn("= 0221505317046536757\n", > self.getFormatted("octal", "(__uint128_t)0x123456789ABDEFull")) > + > +# complex float > +self.assertIn("= error: unsupported byte size (1) for complex > float format\n", self.getFormatted("complex float", "'a'")) > + > +# complex integer > +self.assertIn("= error: unsupported byte size (1) for complex > integer format\n", self.getFormatted("complex integer", "'a'")) > > # hex > self.assertIn("= 0x00abc123\n", self.getFormatted("hex", > "0xABC123")) > @@ -86,6 +96,17 @@ def test(self): > self.assertIn('= " \\U001b\\a\\b\\f\\n\\r\\t\\vaA09"\n', > self.getFormatted("OSType", "cstring")) > self.assertIn('= " \\U001b\\a\\b\\f\\n\\r\\t\\vaA09"\n', > self.getFormatted("unicode8", "cstring")) > > +# FIXME: Passing a 'const char *' will ignore any given format, > +# so we have to repeat the tests with a void* casts to actually > test our formats. > +self.assertIn('= \\x9a\\x0f\\0\\0\\x01\\0\\0\\0\n', > self.getFormatted("character array", "(void *)cstring")) > +self.assertIn('= \\x9a\\x0f\\0\\0\\x01\\0\\0\\0\n', > self.getFormatted("character", "(void *)cstring")) > +self.assertIn('= " \\e\\a\\b\\f\\n\\r\\t\\vaA09"\n', > self.getFormatted("c-string", "(void *)cstring")) > +# FIXME: Ignores the printables characters at the end. > +self.assertIn('= \n', self.getFormatted("printable > character", "(void *)cstring")) > +self.assertIn('= \'\\0\\0\\0\\x01\\0\\0\\x0f\\x9a\'\n', > self.getFormatted("OSType", "(void *)cstring")) > +# FIXME: This should print a string. > +self.assertIn('= 0x00010f9a\n', > self.getFormatted("unicode8", "(void *)cstring")) > + > self.assertIn('= \\0\\0\\0\\0\\0\\0\\0\\0\n', > self.getFormatted("character array", "(__UINT64_TYPE__)0")) > self.assertIn('= \\0\\0\\0\\0\\0\\0\\0\\0\n', > self.getFormatted("character", "(__UINT64_TYPE__)0")) > self.assertIn('=\n', self.getFormatted("c-string", > "(__UINT64_TYPE__)0")) > @@ -137,6 +158,11 @@ def test(self): > # There is not int128_t[] style, so this only tests uint128_t[]. > self.assertIn("= {0x0123456789abcdef}\n", >
[Lldb-commits] [lldb] 10b4354 - Temporarily Revert "[lldb][NFC] Add more test for builtin formats"
Author: Eric Christopher Date: 2020-06-20T14:21:42-07:00 New Revision: 10b43541360efb35a1d33e9cf1e93023ebd69b15 URL: https://github.com/llvm/llvm-project/commit/10b43541360efb35a1d33e9cf1e93023ebd69b15 DIFF: https://github.com/llvm/llvm-project/commit/10b43541360efb35a1d33e9cf1e93023ebd69b15.diff LOG: Temporarily Revert "[lldb][NFC] Add more test for builtin formats" as it's failing on the debian buildbots: http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/12531 This reverts commit 90c1af106a20785ffd01c0d6a41db8bc0160fd11. Added: Modified: lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py Removed: diff --git a/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py b/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py index 1a413a13986a..9fefae6bbf5c 100644 --- a/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py +++ b/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py @@ -42,9 +42,6 @@ def test(self): self.assertIn("= 0\n", self.getFormatted("float", "0")) self.assertIn("= 2\n", self.getFormatted("float", "0x4000")) self.assertIn("= NaN\n", self.getFormatted("float", "-1")) -# Checks the float16 code. -self.assertIn("= 2\n", self.getFormatted("float", "(__UINT16_TYPE__)0x4000")) -self.assertIn("= error: unsupported byte size (1) for float format\n", self.getFormatted("float", "'a'")) # enumeration self.assertIn("= 0\n", self.getFormatted("enumeration", "0")) @@ -62,13 +59,6 @@ def test(self): # octal self.assertIn("= 04553207\n", self.getFormatted("octal", "1234567")) -self.assertIn("= 0221505317046536757\n", self.getFormatted("octal", "(__uint128_t)0x123456789ABDEFull")) - -# complex float -self.assertIn("= error: unsupported byte size (1) for complex float format\n", self.getFormatted("complex float", "'a'")) - -# complex integer -self.assertIn("= error: unsupported byte size (1) for complex integer format\n", self.getFormatted("complex integer", "'a'")) # hex self.assertIn("= 0x00abc123\n", self.getFormatted("hex", "0xABC123")) @@ -96,17 +86,6 @@ def test(self): self.assertIn('= " \\U001b\\a\\b\\f\\n\\r\\t\\vaA09"\n', self.getFormatted("OSType", "cstring")) self.assertIn('= " \\U001b\\a\\b\\f\\n\\r\\t\\vaA09"\n', self.getFormatted("unicode8", "cstring")) -# FIXME: Passing a 'const char *' will ignore any given format, -# so we have to repeat the tests with a void* casts to actually test our formats. -self.assertIn('= \\x9a\\x0f\\0\\0\\x01\\0\\0\\0\n', self.getFormatted("character array", "(void *)cstring")) -self.assertIn('= \\x9a\\x0f\\0\\0\\x01\\0\\0\\0\n', self.getFormatted("character", "(void *)cstring")) -self.assertIn('= " \\e\\a\\b\\f\\n\\r\\t\\vaA09"\n', self.getFormatted("c-string", "(void *)cstring")) -# FIXME: Ignores the printables characters at the end. -self.assertIn('= \n', self.getFormatted("printable character", "(void *)cstring")) -self.assertIn('= \'\\0\\0\\0\\x01\\0\\0\\x0f\\x9a\'\n', self.getFormatted("OSType", "(void *)cstring")) -# FIXME: This should print a string. -self.assertIn('= 0x00010f9a\n', self.getFormatted("unicode8", "(void *)cstring")) - self.assertIn('= \\0\\0\\0\\0\\0\\0\\0\\0\n', self.getFormatted("character array", "(__UINT64_TYPE__)0")) self.assertIn('= \\0\\0\\0\\0\\0\\0\\0\\0\n', self.getFormatted("character", "(__UINT64_TYPE__)0")) self.assertIn('=\n', self.getFormatted("c-string", "(__UINT64_TYPE__)0")) @@ -158,11 +137,6 @@ def test(self): # There is not int128_t[] style, so this only tests uint128_t[]. self.assertIn("= {0x0123456789abcdef}\n", self.getFormatted("uint128_t[]", "__uint128_t i = 0x123456789ABCDEF; i")) -# Different fixed-width float type arrays. -self.assertIn("{2 2}\n", self.getFormatted("float16[]", "0x40004000")) -self.assertIn("{2 2}\n", self.getFormatted("float32[]", "0x40004000ll")) -self.assertIn("{2 0}\n", self.getFormatted("float64[]", "__uint128_t i = 0x4000ll; i")) - # Invalid format string self.expect("expr --format invalid_format_string -- 1", error=True, substrs=["error: Invalid format character or name 'invalid_format_string'. Valid values are:"]) @@ -170,12 +144,10 @@ def test(self): # Extends to host target pointer width. @skipIf(archs=no_match(['x86_64'])) @no_debug_info_test -def test_pointer(self): +def test_instruction(self): # pointer self.assertIn("=
[Lldb-commits] [lldb] 90c1af1 - [lldb][NFC] Add more test for builtin formats
Author: Raphael Isemann Date: 2020-06-20T19:31:40+02:00 New Revision: 90c1af106a20785ffd01c0d6a41db8bc0160fd11 URL: https://github.com/llvm/llvm-project/commit/90c1af106a20785ffd01c0d6a41db8bc0160fd11 DIFF: https://github.com/llvm/llvm-project/commit/90c1af106a20785ffd01c0d6a41db8bc0160fd11.diff LOG: [lldb][NFC] Add more test for builtin formats The previous tests apparently missed a few code branches in DumpDataExtractor code. Also renames the 'test_instruction' which had the same name as another test (and Python therefore ignored the test entirely). Added: Modified: lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py Removed: diff --git a/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py b/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py index 9fefae6bbf5c..1a413a13986a 100644 --- a/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py +++ b/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py @@ -42,6 +42,9 @@ def test(self): self.assertIn("= 0\n", self.getFormatted("float", "0")) self.assertIn("= 2\n", self.getFormatted("float", "0x4000")) self.assertIn("= NaN\n", self.getFormatted("float", "-1")) +# Checks the float16 code. +self.assertIn("= 2\n", self.getFormatted("float", "(__UINT16_TYPE__)0x4000")) +self.assertIn("= error: unsupported byte size (1) for float format\n", self.getFormatted("float", "'a'")) # enumeration self.assertIn("= 0\n", self.getFormatted("enumeration", "0")) @@ -59,6 +62,13 @@ def test(self): # octal self.assertIn("= 04553207\n", self.getFormatted("octal", "1234567")) +self.assertIn("= 0221505317046536757\n", self.getFormatted("octal", "(__uint128_t)0x123456789ABDEFull")) + +# complex float +self.assertIn("= error: unsupported byte size (1) for complex float format\n", self.getFormatted("complex float", "'a'")) + +# complex integer +self.assertIn("= error: unsupported byte size (1) for complex integer format\n", self.getFormatted("complex integer", "'a'")) # hex self.assertIn("= 0x00abc123\n", self.getFormatted("hex", "0xABC123")) @@ -86,6 +96,17 @@ def test(self): self.assertIn('= " \\U001b\\a\\b\\f\\n\\r\\t\\vaA09"\n', self.getFormatted("OSType", "cstring")) self.assertIn('= " \\U001b\\a\\b\\f\\n\\r\\t\\vaA09"\n', self.getFormatted("unicode8", "cstring")) +# FIXME: Passing a 'const char *' will ignore any given format, +# so we have to repeat the tests with a void* casts to actually test our formats. +self.assertIn('= \\x9a\\x0f\\0\\0\\x01\\0\\0\\0\n', self.getFormatted("character array", "(void *)cstring")) +self.assertIn('= \\x9a\\x0f\\0\\0\\x01\\0\\0\\0\n', self.getFormatted("character", "(void *)cstring")) +self.assertIn('= " \\e\\a\\b\\f\\n\\r\\t\\vaA09"\n', self.getFormatted("c-string", "(void *)cstring")) +# FIXME: Ignores the printables characters at the end. +self.assertIn('= \n', self.getFormatted("printable character", "(void *)cstring")) +self.assertIn('= \'\\0\\0\\0\\x01\\0\\0\\x0f\\x9a\'\n', self.getFormatted("OSType", "(void *)cstring")) +# FIXME: This should print a string. +self.assertIn('= 0x00010f9a\n', self.getFormatted("unicode8", "(void *)cstring")) + self.assertIn('= \\0\\0\\0\\0\\0\\0\\0\\0\n', self.getFormatted("character array", "(__UINT64_TYPE__)0")) self.assertIn('= \\0\\0\\0\\0\\0\\0\\0\\0\n', self.getFormatted("character", "(__UINT64_TYPE__)0")) self.assertIn('=\n', self.getFormatted("c-string", "(__UINT64_TYPE__)0")) @@ -137,6 +158,11 @@ def test(self): # There is not int128_t[] style, so this only tests uint128_t[]. self.assertIn("= {0x0123456789abcdef}\n", self.getFormatted("uint128_t[]", "__uint128_t i = 0x123456789ABCDEF; i")) +# Different fixed-width float type arrays. +self.assertIn("{2 2}\n", self.getFormatted("float16[]", "0x40004000")) +self.assertIn("{2 2}\n", self.getFormatted("float32[]", "0x40004000ll")) +self.assertIn("{2 0}\n", self.getFormatted("float64[]", "__uint128_t i = 0x4000ll; i")) + # Invalid format string self.expect("expr --format invalid_format_string -- 1", error=True, substrs=["error: Invalid format character or name 'invalid_format_string'. Valid values are:"]) @@ -144,10 +170,12 @@ def test(self): # Extends to host target pointer width. @skipIf(archs=no_match(['x86_64'])) @no_debug_info_test -def test_instruction(self): +def test_pointer(self): # pointer
[Lldb-commits] [lldb] 7a9a341 - [lldb/Test] Temporarily skip watch simulator in TestSimulatorPlatform.py
Author: Jonas Devlieghere Date: 2020-06-19T22:41:29-07:00 New Revision: 7a9a341953857ade599817eb83625dcd34684a22 URL: https://github.com/llvm/llvm-project/commit/7a9a341953857ade599817eb83625dcd34684a22 DIFF: https://github.com/llvm/llvm-project/commit/7a9a341953857ade599817eb83625dcd34684a22.diff LOG: [lldb/Test] Temporarily skip watch simulator in TestSimulatorPlatform.py The simulator doesn't launch on green-dragon-10. rdar://problem/64552748 Added: Modified: lldb/test/API/macosx/simulator/TestSimulatorPlatform.py Removed: diff --git a/lldb/test/API/macosx/simulator/TestSimulatorPlatform.py b/lldb/test/API/macosx/simulator/TestSimulatorPlatform.py index e9b26a4ee7d3..dce37aa6d706 100644 --- a/lldb/test/API/macosx/simulator/TestSimulatorPlatform.py +++ b/lldb/test/API/macosx/simulator/TestSimulatorPlatform.py @@ -39,6 +39,7 @@ def test_tvos(self): @skipUnlessDarwin @skipIfDarwinEmbedded @apple_simulator_test('watch') +@skipIfDarwin # rdar://problem/64552748 def test_watchos(self): """Test running a 32-bit watchOS simulator binary""" self.run_with(arch='i386', ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] 8027f04 - [lldb/Test] Disable TestBuiltinFormats.py on Windows
Author: Jonas Devlieghere Date: 2020-06-19T22:41:29-07:00 New Revision: 8027f04a6d438b83b75856b03278122f14d6b1d3 URL: https://github.com/llvm/llvm-project/commit/8027f04a6d438b83b75856b03278122f14d6b1d3 DIFF: https://github.com/llvm/llvm-project/commit/8027f04a6d438b83b75856b03278122f14d6b1d3.diff LOG: [lldb/Test] Disable TestBuiltinFormats.py on Windows Disable the test to turn the Windows bot green again until Raphael has time to investigate. Added: Modified: lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py Removed: diff --git a/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py b/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py index b2f2deca0d1c..1fbb3929fa4b 100644 --- a/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py +++ b/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py @@ -22,6 +22,7 @@ def getFormatted(self, format, expr): return result.GetOutput() @no_debug_info_test +@skipIfWindows def test(self): self.build() lldbutil.run_to_source_breakpoint(self, "// break here", lldb.SBFileSpec("main.cpp")) ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] ab88826 - [lldb] Skip TestBuiltinFormats.py on arm for now
Author: Raphael Isemann Date: 2020-06-20T11:22:44+02:00 New Revision: ab888262b32bcdbf9c117e29b90b88c27859bb35 URL: https://github.com/llvm/llvm-project/commit/ab888262b32bcdbf9c117e29b90b88c27859bb35 DIFF: https://github.com/llvm/llvm-project/commit/ab888262b32bcdbf9c117e29b90b88c27859bb35.diff LOG: [lldb] Skip TestBuiltinFormats.py on arm for now Added: Modified: lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py Removed: diff --git a/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py b/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py index 1fbb3929fa4b..9fefae6bbf5c 100644 --- a/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py +++ b/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py @@ -23,6 +23,8 @@ def getFormatted(self, format, expr): @no_debug_info_test @skipIfWindows +# uint128_t not available on arm. +@skipIf(archs=['arm', 'aarch64']) def test(self): self.build() lldbutil.run_to_source_breakpoint(self, "// break here", lldb.SBFileSpec("main.cpp")) ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits