[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
e-kwsm wrote: Commit message is updated/ https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [lldb] [llvm] [openmp] [polly] fix(python): fix comparison to True/False (PR #91858)
https://github.com/e-kwsm updated
https://github.com/llvm/llvm-project/pull/91858
>From 12e8ea6a0e104efbe130dd15d4d9051a7d86d50e Mon Sep 17 00:00:00 2001
From: Eisuke Kawashima
Date: Sun, 12 May 2024 00:06:53 +0900
Subject: [PATCH] fix(python): fix comparison to True/False
from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations):
> Comparisons to singletons like None should always be done with is or is not,
> never the equality operators.
---
clang/tools/scan-build/bin/set-xcode-analyzer | 2 +-
clang/utils/check_cfc/check_cfc.py | 4 ++--
lldb/examples/python/crashlog.py| 2 +-
lldb/examples/python/disasm-stress-test.py | 4 ++--
lldb/examples/summaries/cocoa/CFString.py | 6 +++---
lldb/examples/summaries/pysummary.py| 2 +-
lldb/examples/synthetic/bitfield/example.py | 2 +-
lldb/packages/Python/lldbsuite/test/lldbtest.py | 2 +-
lldb/test/API/commands/command/script/welcome.py| 2 +-
.../commands/expression/call-throws/TestCallThatThrows.py | 6 +++---
.../disassemble/aarch64-adrp-add/TestAArch64AdrpAdd.py | 2 +-
.../gdb_remote_client/TestNoWatchpointSupportInfo.py| 2 +-
lldb/test/API/tools/lldb-server/TestAppleSimulatorOSType.py | 2 +-
lldb/test/API/tools/lldb-server/TestLldbGdbServer.py| 2 +-
llvm/utils/indirect_calls.py| 2 +-
openmp/libompd/gdb-plugin/ompd/ompd.py | 2 +-
openmp/tools/archer/tests/lit.cfg | 2 +-
.../External/isl/imath/tests/gmp-compat-test/genpytest.py | 2 +-
18 files changed, 24 insertions(+), 24 deletions(-)
diff --git a/clang/tools/scan-build/bin/set-xcode-analyzer
b/clang/tools/scan-build/bin/set-xcode-analyzer
index f8c3f775ef7de..8d797bee4ae3b 100755
--- a/clang/tools/scan-build/bin/set-xcode-analyzer
+++ b/clang/tools/scan-build/bin/set-xcode-analyzer
@@ -107,7 +107,7 @@ def main():
foundSpec = True
ModifySpec(x, isBuiltinAnalyzer, path)
- if foundSpec == False:
+ if foundSpec is False:
print "(-) No compiler configuration file was found. Xcode's analyzer
has not been updated."
if __name__ == '__main__':
diff --git a/clang/utils/check_cfc/check_cfc.py
b/clang/utils/check_cfc/check_cfc.py
index 27d732d91030c..d4ddcb5bbb6a3 100755
--- a/clang/utils/check_cfc/check_cfc.py
+++ b/clang/utils/check_cfc/check_cfc.py
@@ -156,7 +156,7 @@ def get_output_file(args):
elif arg.startswith("-o"):
# Specified conjoined with -o
return arg[2:]
-assert grabnext == False
+assert grabnext is False
return None
@@ -182,7 +182,7 @@ def replace_output_file(args, new_name):
if replaceidx is None:
raise Exception
replacement = new_name
-if attached == True:
+if attached is True:
replacement = "-o" + new_name
args[replaceidx] = replacement
return args
diff --git a/lldb/examples/python/crashlog.py b/lldb/examples/python/crashlog.py
index 641b2e64d53b1..62bd73643a46e 100755
--- a/lldb/examples/python/crashlog.py
+++ b/lldb/examples/python/crashlog.py
@@ -166,7 +166,7 @@ def dump_symbolicated(self, crash_log, options):
this_thread_crashed = self.app_specific_backtrace
if not this_thread_crashed:
this_thread_crashed = self.did_crash()
-if options.crashed_only and this_thread_crashed == False:
+if options.crashed_only and this_thread_crashed is False:
return
print("%s" % self)
diff --git a/lldb/examples/python/disasm-stress-test.py
b/lldb/examples/python/disasm-stress-test.py
index 2d3314ee8e8ff..8487b24fdcba7 100755
--- a/lldb/examples/python/disasm-stress-test.py
+++ b/lldb/examples/python/disasm-stress-test.py
@@ -95,13 +95,13 @@ def GetLLDBFrameworkPath():
debugger = lldb.SBDebugger.Create()
-if debugger.IsValid() == False:
+if debugger.IsValid() is False:
print("Couldn't create an SBDebugger")
sys.exit(-1)
target = debugger.CreateTargetWithFileAndArch(None, arg_ns.arch)
-if target.IsValid() == False:
+if target.IsValid() is False:
print("Couldn't create an SBTarget for architecture " + arg_ns.arch)
sys.exit(-1)
diff --git a/lldb/examples/summaries/cocoa/CFString.py
b/lldb/examples/summaries/cocoa/CFString.py
index 13c294ca34122..fdea2c48870cb 100644
--- a/lldb/examples/summaries/cocoa/CFString.py
+++ b/lldb/examples/summaries/cocoa/CFString.py
@@ -253,9 +253,9 @@ def get_child_at_index(self, index):
elif (
self.inline
and self.explicit
-and self.unicode == False
-and self.special == False
-and self.mutable == False
+and self.unicode is False
+and self.special is False
+and self.mutable is False
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
https://github.com/e-kwsm updated https://github.com/llvm/llvm-project/pull/91857 >From 7cec823d9a87b90bf8d9ae5c975f4492076e0abb Mon Sep 17 00:00:00 2001 From: Eisuke Kawashima Date: Sat, 11 May 2024 23:57:11 +0900 Subject: [PATCH] fix(python): fix comparison to None from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations): > Comparisons to singletons like None should always be done with is or is not, > never the equality operators. --- .../clang-tidy/checks/gen-static-analyzer-docs.py| 2 +- clang/docs/DebuggingCoroutines.rst | 8 clang/tools/include-mapping/gen_std.py | 2 +- clang/utils/check_cfc/obj_diff.py| 2 +- clang/utils/module-deps-to-rsp.py| 2 +- compiler-rt/test/asan/lit.cfg.py | 2 +- compiler-rt/test/builtins/Unit/lit.cfg.py| 2 +- compiler-rt/test/ctx_profile/lit.cfg.py | 2 +- compiler-rt/test/lsan/lit.common.cfg.py | 2 +- compiler-rt/test/memprof/lit.cfg.py | 2 +- compiler-rt/test/profile/lit.cfg.py | 2 +- .../android_commands/android_compile.py | 2 +- .../sanitizer_common/ios_commands/iossim_compile.py | 2 +- compiler-rt/test/ubsan/lit.common.cfg.py | 2 +- compiler-rt/test/ubsan_minimal/lit.common.cfg.py | 2 +- .../dexter/dex/command/ParseCommand.py | 2 +- .../DebuggerControllers/ConditionalController.py | 4 ++-- .../DebuggerControllers/ControllerHelpers.py | 2 +- .../debuginfo-tests/dexter/dex/debugger/Debuggers.py | 2 +- .../dexter/dex/debugger/visualstudio/VisualStudio.py | 2 +- .../debuginfo-tests/dexter/dex/tools/test/Tool.py| 2 +- cross-project-tests/lit.cfg.py | 2 +- lldb/docs/use/python.rst | 4 ++-- .../python/armv7_cortex_m_target_defintion.py| 2 +- lldb/packages/Python/lldbsuite/test/dotest.py| 2 +- lldb/packages/Python/lldbsuite/test/lldbtest.py | 6 +++--- lldb/packages/Python/lldbsuite/test/lldbutil.py | 6 +++--- .../lldbsuite/test/tools/intelpt/intelpt_testcase.py | 2 +- .../address_breakpoints/TestBadAddressBreakpoints.py | 2 +- .../step_scripted/TestStepScripted.py| 2 +- .../TestStopOnSharedlibraryEvents.py | 2 +- lldb/test/API/lua_api/TestLuaAPI.py | 2 +- .../thread_suspend/TestInternalThreadSuspension.py | 2 +- lldb/test/API/python_api/event/TestEvents.py | 2 +- .../process/read-mem-cstring/TestReadMemCString.py | 2 +- lldb/test/API/python_api/type/TestTypeList.py| 2 +- .../API/python_api/was_interrupted/interruptible.py | 2 +- lldb/test/Shell/lit.cfg.py | 2 +- llvm/utils/indirect_calls.py | 2 +- llvm/utils/lit/lit/TestRunner.py | 2 +- llvm/utils/lit/lit/util.py | 2 +- llvm/utils/schedcover.py | 2 +- llvm/utils/shuffle_select_fuzz_tester.py | 12 ++-- mlir/test/python/ir/affine_expr.py | 2 +- mlir/test/python/ir/attributes.py| 8 mlir/test/python/ir/builtin_types.py | 8 openmp/libompd/gdb-plugin/ompd/ompd_callbacks.py | 2 +- polly/lib/External/isl/libisl-gdb.py | 4 ++-- polly/lib/External/isl/python/isl.py.top | 4 ++-- polly/utils/pyscop/isl.py| 8 50 files changed, 75 insertions(+), 75 deletions(-) diff --git a/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py b/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py index 6545a3906fa50..53ecb60dec539 100644 --- a/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py +++ b/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py @@ -47,7 +47,7 @@ def get_checkers(checkers_td, checkers_rst): parent_package_ = package["ParentPackage"] hidden = (checker["Hidden"] != 0) or (package["Hidden"] != 0) -while parent_package_ != None: +while parent_package_ is not None: parent_package = table_entries[parent_package_["def"]] checker_package_prefix = ( parent_package["PackageName"] + "." + checker_package_prefix diff --git a/clang/docs/DebuggingCoroutines.rst b/clang/docs/DebuggingCoroutines.rst index 53bdd08fdbc02..7f464c1f4f28c 100644 --- a/clang/docs/DebuggingCoroutines.rst +++ b/clang/docs/DebuggingCoroutines.rst @@ -513,7 +513,7 @@ So we can use the ``continuation`` field to construct the asynchronous stack: self.coro_frame = coro_frame self.resume_func = dereference(self.coro_frame.resume_addr) self.resume_func_block = gdb.block_for_pc(self.resume_func) - if
[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #91868)
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/91868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #91868)
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dave Lee (kastiglione)
Changes
- **[lldb] Support custom LLVM formatting for variables (#81196)**
- **[lldb] Handle non-existent llvm_format**
---
Full diff: https://github.com/llvm/llvm-project/pull/91868.diff
5 Files Affected:
- (modified) lldb/docs/use/variable.rst (+9)
- (modified) lldb/source/Core/FormatEntity.cpp (+63-10)
- (added)
lldb/test/API/functionalities/data-formatter/custom-printf-summary/Makefile
(+2)
- (added)
lldb/test/API/functionalities/data-formatter/custom-printf-summary/TestCustomSummaryLLVMFormat.py
(+20)
- (added)
lldb/test/API/functionalities/data-formatter/custom-printf-summary/main.c (+13)
``diff
diff --git a/lldb/docs/use/variable.rst b/lldb/docs/use/variable.rst
index 8eaed6405315b..e9175b25336ba 100644
--- a/lldb/docs/use/variable.rst
+++ b/lldb/docs/use/variable.rst
@@ -460,6 +460,15 @@ summary strings, regardless of the format they have
applied to their types. To
do that, you can use %format inside an expression path, as in ${var.x->x%u},
which would display the value of x as an unsigned integer.
+Additionally, custom output can be achieved by using an LLVM format string,
+commencing with the ``:`` marker. To illustrate, compare ``${var.byte%x}`` and
+``${var.byte:x-}``. The former uses lldb's builtin hex formatting (``x``),
+which unconditionally inserts a ``0x`` prefix, and also zero pads the value to
+match the size of the type. The latter uses ``llvm::formatv`` formatting
+(``:x-``), and will print only the hex value, with no ``0x`` prefix, and no
+padding. This raw control is useful when composing multiple pieces into a
+larger whole.
+
You can also use some other special format markers, not available for formats
themselves, but which carry a special meaning when used in this context:
diff --git a/lldb/source/Core/FormatEntity.cpp
b/lldb/source/Core/FormatEntity.cpp
index ba62e26252591..af316e1044d2a 100644
--- a/lldb/source/Core/FormatEntity.cpp
+++ b/lldb/source/Core/FormatEntity.cpp
@@ -57,6 +57,7 @@
#include "llvm/ADT/STLExtras.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/Support/Compiler.h"
+#include "llvm/Support/Regex.h"
#include "llvm/TargetParser/Triple.h"
#include
@@ -658,6 +659,38 @@ static char ConvertValueObjectStyleToChar(
return '\0';
}
+static llvm::Regex LLVMFormatPattern{"x[-+]?\\d*|n|d",
llvm::Regex::IgnoreCase};
+
+static bool DumpValueWithLLVMFormat(Stream , llvm::StringRef options,
+ValueObject ) {
+ std::string formatted;
+ std::string llvm_format = ("{0:" + options + "}").str();
+
+ // Options supported by format_provider for integral arithmetic types.
+ // See table in FormatProviders.h.
+
+ auto type_info = valobj.GetTypeInfo();
+ if (type_info & eTypeIsInteger && LLVMFormatPattern.match(options)) {
+if (type_info & eTypeIsSigned) {
+ bool success = false;
+ int64_t integer = valobj.GetValueAsSigned(0, );
+ if (success)
+formatted = llvm::formatv(llvm_format.data(), integer);
+} else {
+ bool success = false;
+ uint64_t integer = valobj.GetValueAsUnsigned(0, );
+ if (success)
+formatted = llvm::formatv(llvm_format.data(), integer);
+}
+ }
+
+ if (formatted.empty())
+return false;
+
+ s.Write(formatted.data(), formatted.size());
+ return true;
+}
+
static bool DumpValue(Stream , const SymbolContext *sc,
const ExecutionContext *exe_ctx,
const FormatEntity::Entry , ValueObject *valobj) {
@@ -728,9 +761,12 @@ static bool DumpValue(Stream , const SymbolContext *sc,
return RunScriptFormatKeyword(s, sc, exe_ctx, valobj,
entry.string.c_str());
}
- llvm::StringRef subpath(entry.string);
+ auto split = llvm::StringRef(entry.string).split(':');
+ auto subpath = split.first;
+ auto llvm_format = split.second;
+
// simplest case ${var}, just print valobj's value
- if (entry.string.empty()) {
+ if (subpath.empty()) {
if (entry.printf_format.empty() && entry.fmt == eFormatDefault &&
entry.number == ValueObject::eValueObjectRepresentationStyleValue)
was_plain_var = true;
@@ -739,7 +775,7 @@ static bool DumpValue(Stream , const SymbolContext *sc,
target = valobj;
} else // this is ${var.something} or multiple .something nested
{
-if (entry.string[0] == '[')
+if (subpath[0] == '[')
was_var_indexed = true;
ScanBracketedRange(subpath, close_bracket_index,
var_name_final_if_array_range, index_lower,
@@ -747,14 +783,11 @@ static bool DumpValue(Stream , const SymbolContext *sc,
Status error;
-const std::string _path = entry.string;
-
-LLDB_LOGF(log, "[Debugger::FormatPrompt] symbol to expand: %s",
- expr_path.c_str());
+LLDB_LOG(log, "[Debugger::FormatPrompt] symbol to expand: {0}", subpath);
target =
valobj
-
[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #91868)
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/91868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] lldb Support custom LLVM formatting for variables (PR #91868)
https://github.com/kastiglione created
https://github.com/llvm/llvm-project/pull/91868
- **[lldb] Support custom LLVM formatting for variables (#81196)**
- **[lldb] Handle non-existent llvm_format**
>From 30a36018b9c96d7ddd969815ef850987d781338e Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Tue, 30 Apr 2024 10:45:10 -0700
Subject: [PATCH 1/2] [lldb] Support custom LLVM formatting for variables
(#81196)
Adds support for applying LLVM formatting to variables.
The reason for this is to support cases such as the following.
Let's say you have two separate bytes that you want to print as a
combined hex value. Consider the following summary string:
```
${var.byte1%x}${var.byte2%x}
```
The output of this will be: `0x120x34`. That is, a `0x` prefix is
unconditionally applied to each byte. This is unlike printf formatting
where you must include the `0x` yourself.
Currently, there's no way to do this with summary strings, instead
you'll need a summary provider in python or c++.
This change introduces formatting support using LLVM's formatter system.
This allows users to achieve the desired custom formatting using:
```
${var.byte1:x-}${var.byte2:x-}
```
Here, each variable is suffixed with `:x-`. This is passed to the LLVM
formatter as `{0:x-}`. For integer values, `x` declares the output as
hex, and `-` declares that no `0x` prefix is to be used. Further, one
could write:
```
${var.byte1:x-2}${var.byte2:x-2}
```
Where the added `2` results in these bytes being written with a minimum
of 2 digits.
An alternative considered was to add a new format specifier that would
print hex values without the `0x` prefix. The reason that approach was
not taken is because in addition to forcing a `0x` prefix, hex values
are also forced to use leading zeros. This approach lets the user have
full control over formatting.
---
lldb/docs/use/variable.rst| 9 +++
lldb/source/Core/FormatEntity.cpp | 70 ---
.../custom-printf-summary/Makefile| 2 +
.../TestCustomSummaryLLVMFormat.py| 20 ++
.../custom-printf-summary/main.c | 13
5 files changed, 104 insertions(+), 10 deletions(-)
create mode 100644
lldb/test/API/functionalities/data-formatter/custom-printf-summary/Makefile
create mode 100644
lldb/test/API/functionalities/data-formatter/custom-printf-summary/TestCustomSummaryLLVMFormat.py
create mode 100644
lldb/test/API/functionalities/data-formatter/custom-printf-summary/main.c
diff --git a/lldb/docs/use/variable.rst b/lldb/docs/use/variable.rst
index 8eaed6405315b..e9175b25336ba 100644
--- a/lldb/docs/use/variable.rst
+++ b/lldb/docs/use/variable.rst
@@ -460,6 +460,15 @@ summary strings, regardless of the format they have
applied to their types. To
do that, you can use %format inside an expression path, as in ${var.x->x%u},
which would display the value of x as an unsigned integer.
+Additionally, custom output can be achieved by using an LLVM format string,
+commencing with the ``:`` marker. To illustrate, compare ``${var.byte%x}`` and
+``${var.byte:x-}``. The former uses lldb's builtin hex formatting (``x``),
+which unconditionally inserts a ``0x`` prefix, and also zero pads the value to
+match the size of the type. The latter uses ``llvm::formatv`` formatting
+(``:x-``), and will print only the hex value, with no ``0x`` prefix, and no
+padding. This raw control is useful when composing multiple pieces into a
+larger whole.
+
You can also use some other special format markers, not available for formats
themselves, but which carry a special meaning when used in this context:
diff --git a/lldb/source/Core/FormatEntity.cpp
b/lldb/source/Core/FormatEntity.cpp
index ba62e26252591..da5b1cfce74ac 100644
--- a/lldb/source/Core/FormatEntity.cpp
+++ b/lldb/source/Core/FormatEntity.cpp
@@ -57,6 +57,7 @@
#include "llvm/ADT/STLExtras.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/Support/Compiler.h"
+#include "llvm/Support/Regex.h"
#include "llvm/TargetParser/Triple.h"
#include
@@ -658,6 +659,38 @@ static char ConvertValueObjectStyleToChar(
return '\0';
}
+static llvm::Regex LLVMFormatPattern{"x[-+]?\\d*|n|d",
llvm::Regex::IgnoreCase};
+
+static bool DumpValueWithLLVMFormat(Stream , llvm::StringRef options,
+ValueObject ) {
+ std::string formatted;
+ std::string llvm_format = ("{0:" + options + "}").str();
+
+ // Options supported by format_provider for integral arithmetic types.
+ // See table in FormatProviders.h.
+
+ auto type_info = valobj.GetTypeInfo();
+ if (type_info & eTypeIsInteger && LLVMFormatPattern.match(options)) {
+if (type_info & eTypeIsSigned) {
+ bool success = false;
+ int64_t integer = valobj.GetValueAsSigned(0, );
+ if (success)
+formatted = llvm::formatv(llvm_format.data(), integer);
+} else {
+ bool success = false;
+ uint64_t integer = valobj.GetValueAsUnsigned(0, );
+ if (success)
+
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] fix(python): fix invalid escape sequences (PR #91856)
e-kwsm wrote:
> Why do we need to make this change?
The valid escape sequences in Python are listed
[here](https://docs.python.org/3/reference/lexical_analysis.html#escape-sequences):
`\t`, `\n`, etc.
Invalid ones fixed here seem to be used for regular expression,
[re](https://docs.python.org/3/library/re.html), e.g. `\.` for literal dot,
`\d` for a digit `[0-9]`.
I use [flake8](https://flake8.pycqa.org/en/latest/) for check.
> Did you use a script to generate this patch?
No. We have choices to fix these:
1. escape backslashes: `"\s"` -> `"\\s"`
2. use raw string: `"\s"` -> `r"\s"`
I thought 2 is simple but actually it does not work for e.g.:
```diff
--- a/clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py
+++ b/clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py
@@ -242,7 +242,7 @@ def main():
filename = None
lines_by_file = {}
for line in sys.stdin:
-match = re.search('^\+\+\+\ "?(.*?/){%s}([^ \t\n"]*)' % args.p, line)
+match = re.search('^\\+\\+\\+\\ "?(.*?/){%s}([^ \t\n"]*)' % args.p,
line)
if match:
filename = match.group(2)
if filename is None:
```
Here `\t\n` is valid whereas `\+` is not.
So I manually fixed them.
https://github.com/llvm/llvm-project/pull/91856
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
ftynse wrote: This should be included in the actual commit, not GitHub comments. https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
e-kwsm wrote: >From [PEP8](https://peps.python.org/pep-0008/#programming-recommendations): > Comparisons to singletons like None should always be done with `is` or `is > not`, never the equality operators. [flake8](https://flake8.pycqa.org/en/latest/) is used here. https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] baffaf0 - [lldb] Add required skipIfLLVMTargetMissing for X86 (NFC)
Author: Dave Lee
Date: 2024-05-11T11:48:31-07:00
New Revision: baffaf000fd4667f33b3756d0d3b645b1d926b44
URL:
https://github.com/llvm/llvm-project/commit/baffaf000fd4667f33b3756d0d3b645b1d926b44
DIFF:
https://github.com/llvm/llvm-project/commit/baffaf000fd4667f33b3756d0d3b645b1d926b44.diff
LOG: [lldb] Add required skipIfLLVMTargetMissing for X86 (NFC)
Added:
Modified:
lldb/test/API/macosx/rosetta/TestRosetta.py
lldb/test/API/macosx/universal64/TestUniversal64.py
Removed:
diff --git a/lldb/test/API/macosx/rosetta/TestRosetta.py
b/lldb/test/API/macosx/rosetta/TestRosetta.py
index ce40de475ef16..a812f558a8fc9 100644
--- a/lldb/test/API/macosx/rosetta/TestRosetta.py
+++ b/lldb/test/API/macosx/rosetta/TestRosetta.py
@@ -40,6 +40,7 @@ class TestRosetta(TestBase):
NO_DEBUG_INFO_TESTCASE = True
@skipUnlessAppleSilicon
+@skipIfLLVMTargetMissing("X86")
@skipIfDarwinEmbedded
def test_rosetta(self):
"""There can be many tests in a test case - describe this test here."""
diff --git a/lldb/test/API/macosx/universal64/TestUniversal64.py
b/lldb/test/API/macosx/universal64/TestUniversal64.py
index 98661443086ef..893ff14d81138 100644
--- a/lldb/test/API/macosx/universal64/TestUniversal64.py
+++ b/lldb/test/API/macosx/universal64/TestUniversal64.py
@@ -17,6 +17,7 @@ def do_test(self):
# actually launch them here.
# The Makefile manually invokes clang.
+@skipIfLLVMTargetMissing("X86")
@skipIfAsan
@skipUnlessDarwin
@skipIfDarwinEmbedded
@@ -26,6 +27,7 @@ def test_universal64_executable(self):
self.do_test()
# The Makefile manually invokes clang.
+@skipIfLLVMTargetMissing("X86")
@skipIfAsan
@skipUnlessDarwin
@skipIfDarwinEmbedded
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] fix(python): fix invalid escape sequences (PR #91856)
tstellar wrote: Two questions: * Did you use a script to generate this patch? * Why do we need to make this change? https://github.com/llvm/llvm-project/pull/91856 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
ftynse wrote: Please provide a proper patch description, i.e., why the change is being made. https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [lldb] [llvm] [openmp] [polly] fix(python): fix comparison to True/False (PR #91858)
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Eisuke Kawashima (e-kwsm)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/91858.diff
18 Files Affected:
- (modified) clang/tools/scan-build/bin/set-xcode-analyzer (+1-1)
- (modified) clang/utils/check_cfc/check_cfc.py (+2-2)
- (modified) lldb/examples/python/crashlog.py (+1-1)
- (modified) lldb/examples/python/disasm-stress-test.py (+2-2)
- (modified) lldb/examples/summaries/cocoa/CFString.py (+3-3)
- (modified) lldb/examples/summaries/pysummary.py (+1-1)
- (modified) lldb/examples/synthetic/bitfield/example.py (+1-1)
- (modified) lldb/packages/Python/lldbsuite/test/lldbtest.py (+1-1)
- (modified) lldb/test/API/commands/command/script/welcome.py (+1-1)
- (modified)
lldb/test/API/commands/expression/call-throws/TestCallThatThrows.py (+3-3)
- (modified)
lldb/test/API/functionalities/disassemble/aarch64-adrp-add/TestAArch64AdrpAdd.py
(+1-1)
- (modified)
lldb/test/API/functionalities/gdb_remote_client/TestNoWatchpointSupportInfo.py
(+1-1)
- (modified) lldb/test/API/tools/lldb-server/TestAppleSimulatorOSType.py (+1-1)
- (modified) lldb/test/API/tools/lldb-server/TestLldbGdbServer.py (+1-1)
- (modified) llvm/utils/indirect_calls.py (+1-1)
- (modified) openmp/libompd/gdb-plugin/ompd/ompd.py (+1-1)
- (modified) openmp/tools/archer/tests/lit.cfg (+1-1)
- (modified) polly/lib/External/isl/imath/tests/gmp-compat-test/genpytest.py
(+1-1)
``diff
diff --git a/clang/tools/scan-build/bin/set-xcode-analyzer
b/clang/tools/scan-build/bin/set-xcode-analyzer
index f8c3f775ef7de..8d797bee4ae3b 100755
--- a/clang/tools/scan-build/bin/set-xcode-analyzer
+++ b/clang/tools/scan-build/bin/set-xcode-analyzer
@@ -107,7 +107,7 @@ def main():
foundSpec = True
ModifySpec(x, isBuiltinAnalyzer, path)
- if foundSpec == False:
+ if foundSpec is False:
print "(-) No compiler configuration file was found. Xcode's analyzer
has not been updated."
if __name__ == '__main__':
diff --git a/clang/utils/check_cfc/check_cfc.py
b/clang/utils/check_cfc/check_cfc.py
index 27d732d91030c..d4ddcb5bbb6a3 100755
--- a/clang/utils/check_cfc/check_cfc.py
+++ b/clang/utils/check_cfc/check_cfc.py
@@ -156,7 +156,7 @@ def get_output_file(args):
elif arg.startswith("-o"):
# Specified conjoined with -o
return arg[2:]
-assert grabnext == False
+assert grabnext is False
return None
@@ -182,7 +182,7 @@ def replace_output_file(args, new_name):
if replaceidx is None:
raise Exception
replacement = new_name
-if attached == True:
+if attached is True:
replacement = "-o" + new_name
args[replaceidx] = replacement
return args
diff --git a/lldb/examples/python/crashlog.py b/lldb/examples/python/crashlog.py
index 641b2e64d53b1..62bd73643a46e 100755
--- a/lldb/examples/python/crashlog.py
+++ b/lldb/examples/python/crashlog.py
@@ -166,7 +166,7 @@ def dump_symbolicated(self, crash_log, options):
this_thread_crashed = self.app_specific_backtrace
if not this_thread_crashed:
this_thread_crashed = self.did_crash()
-if options.crashed_only and this_thread_crashed == False:
+if options.crashed_only and this_thread_crashed is False:
return
print("%s" % self)
diff --git a/lldb/examples/python/disasm-stress-test.py
b/lldb/examples/python/disasm-stress-test.py
index 2d3314ee8e8ff..8487b24fdcba7 100755
--- a/lldb/examples/python/disasm-stress-test.py
+++ b/lldb/examples/python/disasm-stress-test.py
@@ -95,13 +95,13 @@ def GetLLDBFrameworkPath():
debugger = lldb.SBDebugger.Create()
-if debugger.IsValid() == False:
+if debugger.IsValid() is False:
print("Couldn't create an SBDebugger")
sys.exit(-1)
target = debugger.CreateTargetWithFileAndArch(None, arg_ns.arch)
-if target.IsValid() == False:
+if target.IsValid() is False:
print("Couldn't create an SBTarget for architecture " + arg_ns.arch)
sys.exit(-1)
diff --git a/lldb/examples/summaries/cocoa/CFString.py
b/lldb/examples/summaries/cocoa/CFString.py
index 13c294ca34122..fdea2c48870cb 100644
--- a/lldb/examples/summaries/cocoa/CFString.py
+++ b/lldb/examples/summaries/cocoa/CFString.py
@@ -253,9 +253,9 @@ def get_child_at_index(self, index):
elif (
self.inline
and self.explicit
-and self.unicode == False
-and self.special == False
-and self.mutable == False
+and self.unicode is False
+and self.special is False
+and self.mutable is False
):
return self.handle_inline_explicit()
elif self.unicode:
diff --git a/lldb/examples/summaries/pysummary.py
b/lldb/examples/summaries/pysummary.py
index e63a0bff56a13..666b9095f6b38 100644
--- a/lldb/examples/summaries/pysummary.py
+++
[Lldb-commits] [clang] [lldb] [llvm] [openmp] [polly] fix(python): fix comparison to True/False (PR #91858)
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using `@` followed by their GitHub username. If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the [LLVM GitHub User Guide](https://llvm.org/docs/GitHub.html). You can also ask questions in a comment on this PR, on the [LLVM Discord](https://discord.com/invite/xS7Z362) or on the [forums](https://discourse.llvm.org/). https://github.com/llvm/llvm-project/pull/91858 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [lldb] [llvm] [openmp] [polly] fix(python): fix comparison to True/False (PR #91858)
https://github.com/e-kwsm created
https://github.com/llvm/llvm-project/pull/91858
None
>From 1e31186c01024c63fa4c0bd378fec7131ce84d56 Mon Sep 17 00:00:00 2001
From: Eisuke Kawashima
Date: Sun, 12 May 2024 00:06:53 +0900
Subject: [PATCH] fix(python): fix comparison to True/False
---
clang/tools/scan-build/bin/set-xcode-analyzer | 2 +-
clang/utils/check_cfc/check_cfc.py | 4 ++--
lldb/examples/python/crashlog.py| 2 +-
lldb/examples/python/disasm-stress-test.py | 4 ++--
lldb/examples/summaries/cocoa/CFString.py | 6 +++---
lldb/examples/summaries/pysummary.py| 2 +-
lldb/examples/synthetic/bitfield/example.py | 2 +-
lldb/packages/Python/lldbsuite/test/lldbtest.py | 2 +-
lldb/test/API/commands/command/script/welcome.py| 2 +-
.../commands/expression/call-throws/TestCallThatThrows.py | 6 +++---
.../disassemble/aarch64-adrp-add/TestAArch64AdrpAdd.py | 2 +-
.../gdb_remote_client/TestNoWatchpointSupportInfo.py| 2 +-
lldb/test/API/tools/lldb-server/TestAppleSimulatorOSType.py | 2 +-
lldb/test/API/tools/lldb-server/TestLldbGdbServer.py| 2 +-
llvm/utils/indirect_calls.py| 2 +-
openmp/libompd/gdb-plugin/ompd/ompd.py | 2 +-
openmp/tools/archer/tests/lit.cfg | 2 +-
.../External/isl/imath/tests/gmp-compat-test/genpytest.py | 2 +-
18 files changed, 24 insertions(+), 24 deletions(-)
diff --git a/clang/tools/scan-build/bin/set-xcode-analyzer
b/clang/tools/scan-build/bin/set-xcode-analyzer
index f8c3f775ef7de..8d797bee4ae3b 100755
--- a/clang/tools/scan-build/bin/set-xcode-analyzer
+++ b/clang/tools/scan-build/bin/set-xcode-analyzer
@@ -107,7 +107,7 @@ def main():
foundSpec = True
ModifySpec(x, isBuiltinAnalyzer, path)
- if foundSpec == False:
+ if foundSpec is False:
print "(-) No compiler configuration file was found. Xcode's analyzer
has not been updated."
if __name__ == '__main__':
diff --git a/clang/utils/check_cfc/check_cfc.py
b/clang/utils/check_cfc/check_cfc.py
index 27d732d91030c..d4ddcb5bbb6a3 100755
--- a/clang/utils/check_cfc/check_cfc.py
+++ b/clang/utils/check_cfc/check_cfc.py
@@ -156,7 +156,7 @@ def get_output_file(args):
elif arg.startswith("-o"):
# Specified conjoined with -o
return arg[2:]
-assert grabnext == False
+assert grabnext is False
return None
@@ -182,7 +182,7 @@ def replace_output_file(args, new_name):
if replaceidx is None:
raise Exception
replacement = new_name
-if attached == True:
+if attached is True:
replacement = "-o" + new_name
args[replaceidx] = replacement
return args
diff --git a/lldb/examples/python/crashlog.py b/lldb/examples/python/crashlog.py
index 641b2e64d53b1..62bd73643a46e 100755
--- a/lldb/examples/python/crashlog.py
+++ b/lldb/examples/python/crashlog.py
@@ -166,7 +166,7 @@ def dump_symbolicated(self, crash_log, options):
this_thread_crashed = self.app_specific_backtrace
if not this_thread_crashed:
this_thread_crashed = self.did_crash()
-if options.crashed_only and this_thread_crashed == False:
+if options.crashed_only and this_thread_crashed is False:
return
print("%s" % self)
diff --git a/lldb/examples/python/disasm-stress-test.py
b/lldb/examples/python/disasm-stress-test.py
index 2d3314ee8e8ff..8487b24fdcba7 100755
--- a/lldb/examples/python/disasm-stress-test.py
+++ b/lldb/examples/python/disasm-stress-test.py
@@ -95,13 +95,13 @@ def GetLLDBFrameworkPath():
debugger = lldb.SBDebugger.Create()
-if debugger.IsValid() == False:
+if debugger.IsValid() is False:
print("Couldn't create an SBDebugger")
sys.exit(-1)
target = debugger.CreateTargetWithFileAndArch(None, arg_ns.arch)
-if target.IsValid() == False:
+if target.IsValid() is False:
print("Couldn't create an SBTarget for architecture " + arg_ns.arch)
sys.exit(-1)
diff --git a/lldb/examples/summaries/cocoa/CFString.py
b/lldb/examples/summaries/cocoa/CFString.py
index 13c294ca34122..fdea2c48870cb 100644
--- a/lldb/examples/summaries/cocoa/CFString.py
+++ b/lldb/examples/summaries/cocoa/CFString.py
@@ -253,9 +253,9 @@ def get_child_at_index(self, index):
elif (
self.inline
and self.explicit
-and self.unicode == False
-and self.special == False
-and self.mutable == False
+and self.unicode is False
+and self.special is False
+and self.mutable is False
):
return self.handle_inline_explicit()
elif self.unicode:
diff --git a/lldb/examples/summaries/pysummary.py
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
llvmbot wrote: @llvm/pr-subscribers-pgo @llvm/pr-subscribers-compiler-rt-sanitizer Author: Eisuke Kawashima (e-kwsm) Changes --- Patch is 35.05 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/91857.diff 50 Files Affected: - (modified) clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py (+1-1) - (modified) clang/docs/DebuggingCoroutines.rst (+4-4) - (modified) clang/tools/include-mapping/gen_std.py (+1-1) - (modified) clang/utils/check_cfc/obj_diff.py (+1-1) - (modified) clang/utils/module-deps-to-rsp.py (+1-1) - (modified) compiler-rt/test/asan/lit.cfg.py (+1-1) - (modified) compiler-rt/test/builtins/Unit/lit.cfg.py (+1-1) - (modified) compiler-rt/test/ctx_profile/lit.cfg.py (+1-1) - (modified) compiler-rt/test/lsan/lit.common.cfg.py (+1-1) - (modified) compiler-rt/test/memprof/lit.cfg.py (+1-1) - (modified) compiler-rt/test/profile/lit.cfg.py (+1-1) - (modified) compiler-rt/test/sanitizer_common/android_commands/android_compile.py (+1-1) - (modified) compiler-rt/test/sanitizer_common/ios_commands/iossim_compile.py (+1-1) - (modified) compiler-rt/test/ubsan/lit.common.cfg.py (+1-1) - (modified) compiler-rt/test/ubsan_minimal/lit.common.cfg.py (+1-1) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/command/ParseCommand.py (+1-1) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerControllers/ConditionalController.py (+2-2) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerControllers/ControllerHelpers.py (+1-1) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/debugger/Debuggers.py (+1-1) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py (+1-1) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/tools/test/Tool.py (+1-1) - (modified) cross-project-tests/lit.cfg.py (+1-1) - (modified) lldb/docs/use/python.rst (+2-2) - (modified) lldb/examples/python/armv7_cortex_m_target_defintion.py (+1-1) - (modified) lldb/packages/Python/lldbsuite/test/dotest.py (+1-1) - (modified) lldb/packages/Python/lldbsuite/test/lldbtest.py (+3-3) - (modified) lldb/packages/Python/lldbsuite/test/lldbutil.py (+3-3) - (modified) lldb/packages/Python/lldbsuite/test/tools/intelpt/intelpt_testcase.py (+1-1) - (modified) lldb/test/API/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py (+1-1) - (modified) lldb/test/API/functionalities/step_scripted/TestStepScripted.py (+1-1) - (modified) lldb/test/API/functionalities/stop-on-sharedlibrary-load/TestStopOnSharedlibraryEvents.py (+1-1) - (modified) lldb/test/API/lua_api/TestLuaAPI.py (+1-1) - (modified) lldb/test/API/macosx/thread_suspend/TestInternalThreadSuspension.py (+1-1) - (modified) lldb/test/API/python_api/event/TestEvents.py (+1-1) - (modified) lldb/test/API/python_api/process/read-mem-cstring/TestReadMemCString.py (+1-1) - (modified) lldb/test/API/python_api/type/TestTypeList.py (+1-1) - (modified) lldb/test/API/python_api/was_interrupted/interruptible.py (+1-1) - (modified) lldb/test/Shell/lit.cfg.py (+1-1) - (modified) llvm/utils/indirect_calls.py (+1-1) - (modified) llvm/utils/lit/lit/TestRunner.py (+1-1) - (modified) llvm/utils/lit/lit/util.py (+1-1) - (modified) llvm/utils/schedcover.py (+1-1) - (modified) llvm/utils/shuffle_select_fuzz_tester.py (+6-6) - (modified) mlir/test/python/ir/affine_expr.py (+1-1) - (modified) mlir/test/python/ir/attributes.py (+4-4) - (modified) mlir/test/python/ir/builtin_types.py (+4-4) - (modified) openmp/libompd/gdb-plugin/ompd/ompd_callbacks.py (+1-1) - (modified) polly/lib/External/isl/libisl-gdb.py (+2-2) - (modified) polly/lib/External/isl/python/isl.py.top (+2-2) - (modified) polly/utils/pyscop/isl.py (+4-4) ``diff diff --git a/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py b/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py index 6545a3906fa50..53ecb60dec539 100644 --- a/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py +++ b/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py @@ -47,7 +47,7 @@ def get_checkers(checkers_td, checkers_rst): parent_package_ = package["ParentPackage"] hidden = (checker["Hidden"] != 0) or (package["Hidden"] != 0) -while parent_package_ != None: +while parent_package_ is not None: parent_package = table_entries[parent_package_["def"]] checker_package_prefix = ( parent_package["PackageName"] + "." + checker_package_prefix diff --git a/clang/docs/DebuggingCoroutines.rst b/clang/docs/DebuggingCoroutines.rst index 53bdd08fdbc02..7f464c1f4f28c 100644 --- a/clang/docs/DebuggingCoroutines.rst +++ b/clang/docs/DebuggingCoroutines.rst @@ -513,7 +513,7 @@ So we can use the ``continuation`` field to construct the asynchronous stack: self.coro_frame =
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
llvmbot wrote: @llvm/pr-subscribers-clang Author: Eisuke Kawashima (e-kwsm) Changes --- Patch is 35.05 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/91857.diff 50 Files Affected: - (modified) clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py (+1-1) - (modified) clang/docs/DebuggingCoroutines.rst (+4-4) - (modified) clang/tools/include-mapping/gen_std.py (+1-1) - (modified) clang/utils/check_cfc/obj_diff.py (+1-1) - (modified) clang/utils/module-deps-to-rsp.py (+1-1) - (modified) compiler-rt/test/asan/lit.cfg.py (+1-1) - (modified) compiler-rt/test/builtins/Unit/lit.cfg.py (+1-1) - (modified) compiler-rt/test/ctx_profile/lit.cfg.py (+1-1) - (modified) compiler-rt/test/lsan/lit.common.cfg.py (+1-1) - (modified) compiler-rt/test/memprof/lit.cfg.py (+1-1) - (modified) compiler-rt/test/profile/lit.cfg.py (+1-1) - (modified) compiler-rt/test/sanitizer_common/android_commands/android_compile.py (+1-1) - (modified) compiler-rt/test/sanitizer_common/ios_commands/iossim_compile.py (+1-1) - (modified) compiler-rt/test/ubsan/lit.common.cfg.py (+1-1) - (modified) compiler-rt/test/ubsan_minimal/lit.common.cfg.py (+1-1) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/command/ParseCommand.py (+1-1) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerControllers/ConditionalController.py (+2-2) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerControllers/ControllerHelpers.py (+1-1) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/debugger/Debuggers.py (+1-1) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py (+1-1) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/tools/test/Tool.py (+1-1) - (modified) cross-project-tests/lit.cfg.py (+1-1) - (modified) lldb/docs/use/python.rst (+2-2) - (modified) lldb/examples/python/armv7_cortex_m_target_defintion.py (+1-1) - (modified) lldb/packages/Python/lldbsuite/test/dotest.py (+1-1) - (modified) lldb/packages/Python/lldbsuite/test/lldbtest.py (+3-3) - (modified) lldb/packages/Python/lldbsuite/test/lldbutil.py (+3-3) - (modified) lldb/packages/Python/lldbsuite/test/tools/intelpt/intelpt_testcase.py (+1-1) - (modified) lldb/test/API/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py (+1-1) - (modified) lldb/test/API/functionalities/step_scripted/TestStepScripted.py (+1-1) - (modified) lldb/test/API/functionalities/stop-on-sharedlibrary-load/TestStopOnSharedlibraryEvents.py (+1-1) - (modified) lldb/test/API/lua_api/TestLuaAPI.py (+1-1) - (modified) lldb/test/API/macosx/thread_suspend/TestInternalThreadSuspension.py (+1-1) - (modified) lldb/test/API/python_api/event/TestEvents.py (+1-1) - (modified) lldb/test/API/python_api/process/read-mem-cstring/TestReadMemCString.py (+1-1) - (modified) lldb/test/API/python_api/type/TestTypeList.py (+1-1) - (modified) lldb/test/API/python_api/was_interrupted/interruptible.py (+1-1) - (modified) lldb/test/Shell/lit.cfg.py (+1-1) - (modified) llvm/utils/indirect_calls.py (+1-1) - (modified) llvm/utils/lit/lit/TestRunner.py (+1-1) - (modified) llvm/utils/lit/lit/util.py (+1-1) - (modified) llvm/utils/schedcover.py (+1-1) - (modified) llvm/utils/shuffle_select_fuzz_tester.py (+6-6) - (modified) mlir/test/python/ir/affine_expr.py (+1-1) - (modified) mlir/test/python/ir/attributes.py (+4-4) - (modified) mlir/test/python/ir/builtin_types.py (+4-4) - (modified) openmp/libompd/gdb-plugin/ompd/ompd_callbacks.py (+1-1) - (modified) polly/lib/External/isl/libisl-gdb.py (+2-2) - (modified) polly/lib/External/isl/python/isl.py.top (+2-2) - (modified) polly/utils/pyscop/isl.py (+4-4) ``diff diff --git a/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py b/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py index 6545a3906fa50..53ecb60dec539 100644 --- a/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py +++ b/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py @@ -47,7 +47,7 @@ def get_checkers(checkers_td, checkers_rst): parent_package_ = package["ParentPackage"] hidden = (checker["Hidden"] != 0) or (package["Hidden"] != 0) -while parent_package_ != None: +while parent_package_ is not None: parent_package = table_entries[parent_package_["def"]] checker_package_prefix = ( parent_package["PackageName"] + "." + checker_package_prefix diff --git a/clang/docs/DebuggingCoroutines.rst b/clang/docs/DebuggingCoroutines.rst index 53bdd08fdbc02..7f464c1f4f28c 100644 --- a/clang/docs/DebuggingCoroutines.rst +++ b/clang/docs/DebuggingCoroutines.rst @@ -513,7 +513,7 @@ So we can use the ``continuation`` field to construct the asynchronous stack: self.coro_frame = coro_frame self.resume_func =
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using `@` followed by their GitHub username. If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the [LLVM GitHub User Guide](https://llvm.org/docs/GitHub.html). You can also ask questions in a comment on this PR, on the [LLVM Discord](https://discord.com/invite/xS7Z362) or on the [forums](https://discourse.llvm.org/). https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)
https://github.com/e-kwsm created
https://github.com/llvm/llvm-project/pull/91857
None
>From c450df191a6b96591d7c7a7454b6e15cb925520f Mon Sep 17 00:00:00 2001
From: Eisuke Kawashima
Date: Sat, 11 May 2024 23:57:11 +0900
Subject: [PATCH] fix(python): fix comparison to None
---
.../clang-tidy/checks/gen-static-analyzer-docs.py| 2 +-
clang/docs/DebuggingCoroutines.rst | 8
clang/tools/include-mapping/gen_std.py | 2 +-
clang/utils/check_cfc/obj_diff.py| 2 +-
clang/utils/module-deps-to-rsp.py| 2 +-
compiler-rt/test/asan/lit.cfg.py | 2 +-
compiler-rt/test/builtins/Unit/lit.cfg.py| 2 +-
compiler-rt/test/ctx_profile/lit.cfg.py | 2 +-
compiler-rt/test/lsan/lit.common.cfg.py | 2 +-
compiler-rt/test/memprof/lit.cfg.py | 2 +-
compiler-rt/test/profile/lit.cfg.py | 2 +-
.../android_commands/android_compile.py | 2 +-
.../sanitizer_common/ios_commands/iossim_compile.py | 2 +-
compiler-rt/test/ubsan/lit.common.cfg.py | 2 +-
compiler-rt/test/ubsan_minimal/lit.common.cfg.py | 2 +-
.../dexter/dex/command/ParseCommand.py | 2 +-
.../DebuggerControllers/ConditionalController.py | 4 ++--
.../DebuggerControllers/ControllerHelpers.py | 2 +-
.../debuginfo-tests/dexter/dex/debugger/Debuggers.py | 2 +-
.../dexter/dex/debugger/visualstudio/VisualStudio.py | 2 +-
.../debuginfo-tests/dexter/dex/tools/test/Tool.py| 2 +-
cross-project-tests/lit.cfg.py | 2 +-
lldb/docs/use/python.rst | 4 ++--
.../python/armv7_cortex_m_target_defintion.py| 2 +-
lldb/packages/Python/lldbsuite/test/dotest.py| 2 +-
lldb/packages/Python/lldbsuite/test/lldbtest.py | 6 +++---
lldb/packages/Python/lldbsuite/test/lldbutil.py | 6 +++---
.../lldbsuite/test/tools/intelpt/intelpt_testcase.py | 2 +-
.../address_breakpoints/TestBadAddressBreakpoints.py | 2 +-
.../step_scripted/TestStepScripted.py| 2 +-
.../TestStopOnSharedlibraryEvents.py | 2 +-
lldb/test/API/lua_api/TestLuaAPI.py | 2 +-
.../thread_suspend/TestInternalThreadSuspension.py | 2 +-
lldb/test/API/python_api/event/TestEvents.py | 2 +-
.../process/read-mem-cstring/TestReadMemCString.py | 2 +-
lldb/test/API/python_api/type/TestTypeList.py| 2 +-
.../API/python_api/was_interrupted/interruptible.py | 2 +-
lldb/test/Shell/lit.cfg.py | 2 +-
llvm/utils/indirect_calls.py | 2 +-
llvm/utils/lit/lit/TestRunner.py | 2 +-
llvm/utils/lit/lit/util.py | 2 +-
llvm/utils/schedcover.py | 2 +-
llvm/utils/shuffle_select_fuzz_tester.py | 12 ++--
mlir/test/python/ir/affine_expr.py | 2 +-
mlir/test/python/ir/attributes.py| 8
mlir/test/python/ir/builtin_types.py | 8
openmp/libompd/gdb-plugin/ompd/ompd_callbacks.py | 2 +-
polly/lib/External/isl/libisl-gdb.py | 4 ++--
polly/lib/External/isl/python/isl.py.top | 4 ++--
polly/utils/pyscop/isl.py| 8
50 files changed, 75 insertions(+), 75 deletions(-)
diff --git
a/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py
b/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py
index 6545a3906fa50..53ecb60dec539 100644
--- a/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py
+++ b/clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py
@@ -47,7 +47,7 @@ def get_checkers(checkers_td, checkers_rst):
parent_package_ = package["ParentPackage"]
hidden = (checker["Hidden"] != 0) or (package["Hidden"] != 0)
-while parent_package_ != None:
+while parent_package_ is not None:
parent_package = table_entries[parent_package_["def"]]
checker_package_prefix = (
parent_package["PackageName"] + "." + checker_package_prefix
diff --git a/clang/docs/DebuggingCoroutines.rst
b/clang/docs/DebuggingCoroutines.rst
index 53bdd08fdbc02..7f464c1f4f28c 100644
--- a/clang/docs/DebuggingCoroutines.rst
+++ b/clang/docs/DebuggingCoroutines.rst
@@ -513,7 +513,7 @@ So we can use the ``continuation`` field to construct the
asynchronous stack:
self.coro_frame = coro_frame
self.resume_func = dereference(self.coro_frame.resume_addr)
self.resume_func_block = gdb.block_for_pc(self.resume_func)
- if self.resume_func_block == None:
+ if self.resume_func_block is None:
raise Exception('Not stackless coroutine.')
self.line_info = gdb.find_pc_line(self.resume_func)
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] fix(python): fix invalid escape sequences (PR #91856)
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Eisuke Kawashima (e-kwsm) Changes --- Patch is 120.87 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/91856.diff 100 Files Affected: - (modified) .github/workflows/version-check.py (+1-1) - (modified) clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py (+2-2) - (modified) clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py (+1-1) - (modified) clang/docs/tools/dump_ast_matchers.py (+5-5) - (modified) clang/test/Analysis/check-analyzer-fixit.py (+1-1) - (modified) compiler-rt/lib/asan/scripts/asan_symbolize.py (+2-2) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/command/ParseCommand.py (+2-2) - (modified) cross-project-tests/lit.cfg.py (+3-3) - (modified) libcxx/test/libcxx/transitive_includes.gen.py (+1-1) - (modified) libcxx/utils/generate_escaped_output_table.py (+1-1) - (modified) libcxx/utils/generate_width_estimation_table.py (+1-1) - (modified) lld/test/MachO/tools/validate-unwind-info.py (+1-1) - (modified) lld/utils/benchmark.py (+1-1) - (modified) lldb/examples/python/crashlog.py (+4-4) - (modified) lldb/examples/python/delta.py (+1-1) - (modified) lldb/examples/python/gdbremote.py (+2-2) - (modified) lldb/examples/python/jump.py (+3-3) - (modified) lldb/examples/python/performance.py (+1-1) - (modified) lldb/examples/python/symbolication.py (+3-3) - (modified) lldb/packages/Python/lldbsuite/test/lldbpexpect.py (+1-1) - (modified) lldb/packages/Python/lldbsuite/test/test_runner/process_control.py (+1-1) - (modified) lldb/test/API/commands/command/backticks/TestBackticksInAlias.py (+2-2) - (modified) lldb/test/API/commands/expression/memory-allocation/TestMemoryAllocSettings.py (+1-1) - (modified) lldb/test/API/commands/expression/test/TestExprs.py (+1-1) - (modified) lldb/test/API/commands/gui/expand-threads-tree/TestGuiExpandThreadsTree.py (+1-1) - (modified) lldb/test/API/commands/help/TestHelp.py (+3-3) - (modified) lldb/test/API/commands/process/launch-with-shellexpand/TestLaunchWithShellExpand.py (+1-1) - (modified) lldb/test/API/commands/register/register/TestRegistersUnavailable.py (+2-2) - (modified) lldb/test/API/commands/settings/TestSettings.py (+6-6) - (modified) lldb/test/API/commands/target/basic/TestTargetCommand.py (+1-1) - (modified) lldb/test/API/commands/target/dump-separate-debug-info/dwo/TestDumpDwo.py (+8-8) - (modified) lldb/test/API/commands/target/dump-separate-debug-info/oso/TestDumpOso.py (+8-8) - (modified) lldb/test/API/commands/trace/TestTraceDumpInfo.py (+1-1) - (modified) lldb/test/API/commands/trace/TestTraceEvents.py (+2-2) - (modified) lldb/test/API/commands/trace/TestTraceStartStop.py (+6-6) - (modified) lldb/test/API/commands/trace/TestTraceTSC.py (+5-5) - (modified) lldb/test/API/driver/quit_speed/TestQuitWithProcess.py (+1-1) - (modified) lldb/test/API/functionalities/breakpoint/breakpoint_by_line_and_column/TestBreakpointByLineAndColumn.py (+1-1) - (modified) lldb/test/API/functionalities/breakpoint/breakpoint_locations/TestBreakpointLocations.py (+1-1) - (modified) lldb/test/API/functionalities/data-formatter/data-formatter-advanced/TestDataFormatterAdv.py (+3-3) - (modified) lldb/test/API/functionalities/data-formatter/data-formatter-cpp/TestDataFormatterCpp.py (+3-3) - (modified) lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSContainer.py (+8-8) - (modified) lldb/test/API/functionalities/data-formatter/data-formatter-skip-summary/TestDataFormatterSkipSummary.py (+1-1) - (modified) lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/unordered/TestDataFormatterGenericUnordered.py (+11-11) - (modified) lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/atomic/TestLibCxxAtomic.py (+1-1) - (modified) lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/initializerlist/TestInitializerList.py (+1-1) - (modified) lldb/test/API/functionalities/data-formatter/type_summary_list_arg/TestTypeSummaryListArg.py (+2-2) - (modified) lldb/test/API/functionalities/memory-region/TestMemoryRegion.py (+1-1) - (modified) lldb/test/API/functionalities/target_var/TestTargetVar.py (+1-1) - (modified) lldb/test/API/iohandler/completion/TestIOHandlerCompletion.py (+1-1) - (modified) lldb/test/API/lang/c/function_types/TestFunctionTypes.py (+1-1) - (modified) lldb/test/API/lang/c/register_variables/TestRegisterVariables.py (+1-1) - (modified) lldb/test/API/lang/c/set_values/TestSetValues.py (+2-2) - (modified) lldb/test/API/lang/c/strings/TestCStrings.py (+1-1) - (modified) lldb/test/API/lang/c/tls_globals/TestTlsGlobals.py (+4-4) - (modified) lldb/test/API/lang/cpp/char1632_t/TestChar1632T.py (+4-4) - (modified) lldb/test/API/lang/cpp/class_static/TestStaticVariables.py (+2-2) - (modified) lldb/test/API/lang/cpp/class_types/TestClassTypes.py
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] fix(python): fix invalid escape sequences (PR #91856)
llvmbot wrote: @llvm/pr-subscribers-libcxx @llvm/pr-subscribers-clang Author: Eisuke Kawashima (e-kwsm) Changes --- Patch is 120.87 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/91856.diff 100 Files Affected: - (modified) .github/workflows/version-check.py (+1-1) - (modified) clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py (+2-2) - (modified) clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py (+1-1) - (modified) clang/docs/tools/dump_ast_matchers.py (+5-5) - (modified) clang/test/Analysis/check-analyzer-fixit.py (+1-1) - (modified) compiler-rt/lib/asan/scripts/asan_symbolize.py (+2-2) - (modified) cross-project-tests/debuginfo-tests/dexter/dex/command/ParseCommand.py (+2-2) - (modified) cross-project-tests/lit.cfg.py (+3-3) - (modified) libcxx/test/libcxx/transitive_includes.gen.py (+1-1) - (modified) libcxx/utils/generate_escaped_output_table.py (+1-1) - (modified) libcxx/utils/generate_width_estimation_table.py (+1-1) - (modified) lld/test/MachO/tools/validate-unwind-info.py (+1-1) - (modified) lld/utils/benchmark.py (+1-1) - (modified) lldb/examples/python/crashlog.py (+4-4) - (modified) lldb/examples/python/delta.py (+1-1) - (modified) lldb/examples/python/gdbremote.py (+2-2) - (modified) lldb/examples/python/jump.py (+3-3) - (modified) lldb/examples/python/performance.py (+1-1) - (modified) lldb/examples/python/symbolication.py (+3-3) - (modified) lldb/packages/Python/lldbsuite/test/lldbpexpect.py (+1-1) - (modified) lldb/packages/Python/lldbsuite/test/test_runner/process_control.py (+1-1) - (modified) lldb/test/API/commands/command/backticks/TestBackticksInAlias.py (+2-2) - (modified) lldb/test/API/commands/expression/memory-allocation/TestMemoryAllocSettings.py (+1-1) - (modified) lldb/test/API/commands/expression/test/TestExprs.py (+1-1) - (modified) lldb/test/API/commands/gui/expand-threads-tree/TestGuiExpandThreadsTree.py (+1-1) - (modified) lldb/test/API/commands/help/TestHelp.py (+3-3) - (modified) lldb/test/API/commands/process/launch-with-shellexpand/TestLaunchWithShellExpand.py (+1-1) - (modified) lldb/test/API/commands/register/register/TestRegistersUnavailable.py (+2-2) - (modified) lldb/test/API/commands/settings/TestSettings.py (+6-6) - (modified) lldb/test/API/commands/target/basic/TestTargetCommand.py (+1-1) - (modified) lldb/test/API/commands/target/dump-separate-debug-info/dwo/TestDumpDwo.py (+8-8) - (modified) lldb/test/API/commands/target/dump-separate-debug-info/oso/TestDumpOso.py (+8-8) - (modified) lldb/test/API/commands/trace/TestTraceDumpInfo.py (+1-1) - (modified) lldb/test/API/commands/trace/TestTraceEvents.py (+2-2) - (modified) lldb/test/API/commands/trace/TestTraceStartStop.py (+6-6) - (modified) lldb/test/API/commands/trace/TestTraceTSC.py (+5-5) - (modified) lldb/test/API/driver/quit_speed/TestQuitWithProcess.py (+1-1) - (modified) lldb/test/API/functionalities/breakpoint/breakpoint_by_line_and_column/TestBreakpointByLineAndColumn.py (+1-1) - (modified) lldb/test/API/functionalities/breakpoint/breakpoint_locations/TestBreakpointLocations.py (+1-1) - (modified) lldb/test/API/functionalities/data-formatter/data-formatter-advanced/TestDataFormatterAdv.py (+3-3) - (modified) lldb/test/API/functionalities/data-formatter/data-formatter-cpp/TestDataFormatterCpp.py (+3-3) - (modified) lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSContainer.py (+8-8) - (modified) lldb/test/API/functionalities/data-formatter/data-formatter-skip-summary/TestDataFormatterSkipSummary.py (+1-1) - (modified) lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/unordered/TestDataFormatterGenericUnordered.py (+11-11) - (modified) lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/atomic/TestLibCxxAtomic.py (+1-1) - (modified) lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/initializerlist/TestInitializerList.py (+1-1) - (modified) lldb/test/API/functionalities/data-formatter/type_summary_list_arg/TestTypeSummaryListArg.py (+2-2) - (modified) lldb/test/API/functionalities/memory-region/TestMemoryRegion.py (+1-1) - (modified) lldb/test/API/functionalities/target_var/TestTargetVar.py (+1-1) - (modified) lldb/test/API/iohandler/completion/TestIOHandlerCompletion.py (+1-1) - (modified) lldb/test/API/lang/c/function_types/TestFunctionTypes.py (+1-1) - (modified) lldb/test/API/lang/c/register_variables/TestRegisterVariables.py (+1-1) - (modified) lldb/test/API/lang/c/set_values/TestSetValues.py (+2-2) - (modified) lldb/test/API/lang/c/strings/TestCStrings.py (+1-1) - (modified) lldb/test/API/lang/c/tls_globals/TestTlsGlobals.py (+4-4) - (modified) lldb/test/API/lang/cpp/char1632_t/TestChar1632T.py (+4-4) - (modified) lldb/test/API/lang/cpp/class_static/TestStaticVariables.py (+2-2) - (modified)
[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] fix(python): fix invalid escape sequences (PR #91856)
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using `@` followed by their GitHub username. If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the [LLVM GitHub User Guide](https://llvm.org/docs/GitHub.html). You can also ask questions in a comment on this PR, on the [LLVM Discord](https://discord.com/invite/xS7Z362) or on the [forums](https://discourse.llvm.org/). https://github.com/llvm/llvm-project/pull/91856 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] [LLDB] Add FreeBSD kernel coredump matching check. (PR #80785)
aokblast wrote: I extend this feature to all kernel module in [here](https://reviews.freebsd.org/D45161/new/). Then I will write the corresponding code for LLDB later. Since kernel is also in linker_files structure. So I convinced that it can fix the problem. https://github.com/llvm/llvm-project/pull/80785 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
