[Lldb-commits] [PATCH] D104882: makes extension contribute breakpoints using new package.json schema:https://code.visualstudio.com/updates/v1_42#_implement-a-debug-adapter-inside-an-extension

2021-06-25 Thread Chris Bond via Phabricator via lldb-commits 
chrisbond added a comment.

Thanks. Since I don't yet have commit access, could you go ahead and commit 
this change for me?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104882/new/

https://reviews.llvm.org/D104882

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D104882: makes extension contribute breakpoints using new package.json schema:https://code.visualstudio.com/updates/v1_42#_implement-a-debug-adapter-inside-an-extension

2021-06-25 Thread Chris Bond via Phabricator via lldb-commits 
chrisbond updated this revision to Diff 354435.
chrisbond added a comment.

restore deprecated enableBreakpointsFor section to package.json to support 
older vscode releases. newer releases ignore this section.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104882/new/

https://reviews.llvm.org/D104882

Files:
  lldb/tools/lldb-vscode/package.json


Index: lldb/tools/lldb-vscode/package.json
===
--- lldb/tools/lldb-vscode/package.json
+++ lldb/tools/lldb-vscode/package.json
@@ -49,6 +49,53 @@
 "scopeName": "source.disassembly",
 "path": "./syntaxes/disassembly.json"
 }
+],
+"breakpoints": [
+  {
+"language": "ada"
+  },
+  {
+"language": "arm"
+  },
+  {
+"language": "asm"
+  },
+  {
+"language": "c"
+  },
+  {
+"language": "cpp"
+  },
+  {
+"language": "crystal"
+  },
+  {
+"language": "d"
+  },
+  {
+"language": "fortan"
+  },
+  {
+"language": "fortran-modern"
+  },
+  {
+"language": "nim"
+  },
+  {
+"language": "objective-c"
+  },
+  {
+"language": "objectpascal"
+  },
+  {
+"language": "pascal"
+  },
+  {
+"language": "rust"
+  },
+  {
+"language": "swift"
+  }
 ],
"debuggers": [
{


Index: lldb/tools/lldb-vscode/package.json
===
--- lldb/tools/lldb-vscode/package.json
+++ lldb/tools/lldb-vscode/package.json
@@ -49,6 +49,53 @@
 "scopeName": "source.disassembly",
 "path": "./syntaxes/disassembly.json"
 }
+],
+"breakpoints": [
+  {
+"language": "ada"
+  },
+  {
+"language": "arm"
+  },
+  {
+"language": "asm"
+  },
+  {
+"language": "c"
+  },
+  {
+"language": "cpp"
+  },
+  {
+"language": "crystal"
+  },
+  {
+"language": "d"
+  },
+  {
+"language": "fortan"
+  },
+  {
+"language": "fortran-modern"
+  },
+  {
+"language": "nim"
+  },
+  {
+"language": "objective-c"
+  },
+  {
+"language": "objectpascal"
+  },
+  {
+"language": "pascal"
+  },
+  {
+"language": "rust"
+  },
+  {
+"language": "swift"
+  }
 ],
 		"debuggers": [
 			{
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D104882: makes extension contribute breakpoints using new package.json schema:https://code.visualstudio.com/updates/v1_42#_implement-a-debug-adapter-inside-an-extension

2021-06-24 Thread Chris Bond via Phabricator via lldb-commits 
chrisbond updated this revision to Diff 354392.
chrisbond added a comment.
Herald added a subscriber: JDevlieghere.

minimize diff content


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104882/new/

https://reviews.llvm.org/D104882

Files:
  lldb/tools/lldb-vscode/package.json


Index: lldb/tools/lldb-vscode/package.json
===
--- lldb/tools/lldb-vscode/package.json
+++ lldb/tools/lldb-vscode/package.json
@@ -50,29 +50,57 @@
 "path": "./syntaxes/disassembly.json"
 }
 ],
+   "breakpoints": [
+   {
+   "language": "ada"
+   },
+   {
+   "language": "arm"
+   },
+   {
+   "language": "asm"
+   },
+   {
+   "language": "c"
+   },
+   {
+   "language": "cpp"
+   },
+   {
+   "language": "crystal"
+   },
+   {
+   "language": "d"
+   },
+   {
+   "language": "fortan"
+   },
+   {
+   "language": "fortran-modern"
+   },
+   {
+   "language": "nim"
+   },
+   {
+   "language": "objective-c"
+   },
+   {
+   "language": "objectpascal"
+   },
+   {
+   "language": "pascal"
+   },
+   {
+   "language": "rust"
+   },
+   {
+   "language": "swift"
+   }
+   ],
"debuggers": [
{
"type": "lldb-vscode",
"label": "Native LLDB Debugger",
-   "enableBreakpointsFor": {
-   "languageIds": [
-   "ada",
-   "arm",
-   "asm",
-   "c",
-   "cpp",
-   "crystal",
-   "d",
-   "fortan",
-   "fortran-modern",
-   "nim",
-   "objective-c",
-   "objectpascal",
-   "pascal",
-   "rust",
-   "swift"
-   ]
-   },
"program": "./bin/lldb-vscode",
"windows": {
"program": "./bin/lldb-vscode.exe"


Index: lldb/tools/lldb-vscode/package.json
===
--- lldb/tools/lldb-vscode/package.json
+++ lldb/tools/lldb-vscode/package.json
@@ -50,29 +50,57 @@
 "path": "./syntaxes/disassembly.json"
 }
 ],
+"breakpoints": [
+	{
+		"language": "ada"
+	},
+	{
+		"language": "arm"
+	},
+	{
+		"language": "asm"
+	},
+	{
+		"language": "c"
+	},
+	{
+		"language": "cpp"
+	},
+	{
+		"language": "crystal"
+	},
+	{
+		"language": "d"
+	},
+

[Lldb-commits] [PATCH] D104882: makes extension contribute breakpoints using new package.json schema:https://code.visualstudio.com/updates/v1_42#_implement-a-debug-adapter-inside-an-extension

2021-06-24 Thread Chris Bond via Phabricator via lldb-commits 
chrisbond created this revision.
chrisbond requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D104882

Files:
  lldb/tools/lldb-vscode/package.json

Index: lldb/tools/lldb-vscode/package.json
===
--- lldb/tools/lldb-vscode/package.json
+++ lldb/tools/lldb-vscode/package.json
@@ -1,296 +1,327 @@
 {
-	"name": "lldb-vscode",
-	"displayName": "LLDB native Debug stub",
-	"version": "0.1.0",
-	"publisher": "llvm",
-	"repository": "llvm.org",
-	"description": "Debug adapter for LLDB which uses a C++ tool to interface directly with LLDB.",
-	"author": {
-		"name": "Greg Clayton",
-		"email": "clayb...@gmail.com"
-	},
-	"license": "LLVM",
-	"keywords": [
-		"multi-root ready"
-	],
-	"engines": {
-		"vscode": "^1.18.0",
-		"node": "^7.9.0"
-	},
-	"categories": [
-		"Debuggers"
-	],
-	"private": true,
-	"devDependencies": {
-		"@types/node": "7.0.43",
-		"@types/mocha": "2.2.45",
-		"typescript": "2.6.2",
-		"mocha": "4.0.1",
-		"vscode": "1.1.10",
-		"vscode-debugadapter-testsupport": "1.25.0",
-		"tslint": "5.8.0",
-		"vsce": "^1.36.3"
-	},
-	"contributes": {
-		"languages": [
-			{
-"id": "lldb.disassembly",
-"aliases": [
-"Disassembly"
+  "name": "lldb-vscode",
+  "displayName": "LLDB native Debug stub",
+  "version": "0.1.0",
+  "publisher": "llvm",
+  "repository": "llvm.org",
+  "description": "Debug adapter for LLDB which uses a C++ tool to interface directly with LLDB.",
+  "author": {
+"name": "Greg Clayton",
+"email": "clayb...@gmail.com"
+  },
+  "license": "LLVM",
+  "keywords": [
+"multi-root ready"
+  ],
+  "engines": {
+"vscode": "^1.18.0",
+"node": "^7.9.0"
+  },
+  "categories": [
+"Debuggers"
+  ],
+  "private": true,
+  "devDependencies": {
+"@types/node": "7.0.43",
+"@types/mocha": "2.2.45",
+"typescript": "2.6.2",
+"mocha": "4.0.1",
+"vscode": "1.1.10",
+"vscode-debugadapter-testsupport": "1.25.0",
+"tslint": "5.8.0",
+"vsce": "^1.36.3"
+  },
+  "contributes": {
+"languages": [
+  {
+"id": "lldb.disassembly",
+"aliases": [
+  "Disassembly"
+],
+"extensions": [
+  ".disasm"
+]
+  }
+],
+"grammars": [
+  {
+"language": "lldb.disassembly",
+"scopeName": "source.disassembly",
+"path": "./syntaxes/disassembly.json"
+  }
+],
+"breakpoints": [
+  {
+"language": "markdown"
+  },
+  {
+"language": "ada"
+  },
+  {
+"language": "arm"
+  },
+  {
+"language": "asm"
+  },
+  {
+"language": "c"
+  },
+  {
+"language": "cpp"
+  },
+  {
+"language": "crystal"
+  },
+  {
+"language": "d"
+  },
+  {
+"language": "fortan"
+  },
+  {
+"language": "fortran-modern"
+  },
+  {
+"language": "nim"
+  },
+  {
+"language": "objective-c"
+  },
+  {
+"language": "objectpascal"
+  },
+  {
+"language": "pascal"
+  },
+  {
+"language": "rust"
+  },
+  {
+"language": "swift"
+  }
+],
+"debuggers": [
+  {
+"type": "lldb-vscode",
+"label": "Native LLDB Debugger",
+"program": "./bin/lldb-vscode",
+"windows": {
+  "program": "./bin/lldb-vscode.exe"
+},
+"configurationAttributes": {
+  "launch": {
+"required": [
+  "program"
+],
+"properties": {
+  "program": {
+"type": "string",
+"description": "Path to the program to debug."
+  },
+  "args": {
+"type": [
+  "array",
+  "string"
+],
+"description": "Program arguments.",
+"default": []
+  },
+  "cwd": {
+"type": "string",
+"description": "Program working directory.",
+"default": "${workspaceRoot}"
+  },
+  "env": {
+"type": "array",
+"description": "Additional environment variables to set when launching the program. This is an array of strings that contains the variable name followed by an optional '=' character and the environment variable's value. Example:  [\"FOO=BAR\", \"BAZ\"]",
+"default": []
+  },
+  "stopOnEntry": {
+"type": "boolean",
+"description": "Automatically stop after launch.",
+"default": false
+  },
+  "disableASLR": {
+"type": "boolean",
+"description": "Enable or