[Lldb-commits] [lldb] Fix lock guads in PipePosix.cpp (PR #90572)
https://github.com/dklimkin closed https://github.com/llvm/llvm-project/pull/90572 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] Fix lock guads in PipePosix.cpp (PR #90572)
https://github.com/dklimkin created
https://github.com/llvm/llvm-project/pull/90572
Guard object destroyed immediately after creation without naming.
>From 7be6091ee5a4509bfec231adfdab3bc135112070 Mon Sep 17 00:00:00 2001
From: Danial Klimkin
Date: Tue, 30 Apr 2024 10:05:02 +0200
Subject: [PATCH] Fix lock guads in PipePosix.cpp
Guard object destroyed immediately after creation without naming.
---
lldb/source/Host/posix/PipePosix.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lldb/source/Host/posix/PipePosix.cpp
b/lldb/source/Host/posix/PipePosix.cpp
index afd3fe39059ac1..f35c348990df62 100644
--- a/lldb/source/Host/posix/PipePosix.cpp
+++ b/lldb/source/Host/posix/PipePosix.cpp
@@ -108,7 +108,7 @@ Status PipePosix::CreateNew(bool child_processes_inherit) {
}
Status PipePosix::CreateNew(llvm::StringRef name, bool child_process_inherit) {
- std::scoped_lock (m_read_mutex, m_write_mutex);
+ std::scoped_lock guard(m_read_mutex, m_write_mutex);
if (CanReadUnlocked() || CanWriteUnlocked())
return Status("Pipe is already opened");
@@ -146,7 +146,7 @@ Status PipePosix::CreateWithUniqueName(llvm::StringRef
prefix,
Status PipePosix::OpenAsReader(llvm::StringRef name,
bool child_process_inherit) {
- std::scoped_lock (m_read_mutex, m_write_mutex);
+ std::scoped_lock guard(m_read_mutex, m_write_mutex);
if (CanReadUnlocked() || CanWriteUnlocked())
return Status("Pipe is already opened");
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] Update test past bdbad0d07bb600301cb324e87a6be37ca4af591a (PR #84889)
https://github.com/dklimkin closed https://github.com/llvm/llvm-project/pull/84889 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] Update test past bdbad0d07bb600301cb324e87a6be37ca4af591a (PR #84889)
https://github.com/dklimkin created
https://github.com/llvm/llvm-project/pull/84889
None
>From 04886b73fc9ca7b4a6adc52f5306cb6addc85e5c Mon Sep 17 00:00:00 2001
From: Danial Klimkin
Date: Tue, 12 Mar 2024 11:02:32 +0100
Subject: [PATCH] Update test past bdbad0d07bb600301cb324e87a6be37ca4af591a
---
.../data-formatter/builtin-formats/TestBuiltinFormats.py| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py
b/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py
index 8c3bdabeaac1ba..4d6f44db0195b4 100644
---
a/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py
+++
b/lldb/test/API/functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py
@@ -308,5 +308,5 @@ def test_pointer(self):
@no_debug_info_test
def test_instruction(self):
self.assertIn(
-" addq 0xa(%rdi), %r8\n", self.getFormatted("instruction",
"0x0a47034c")
+"= addq 0xa(%rdi), %r8\n", self.getFormatted("instruction",
"0x0a47034c")
)
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
