[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip
gmittert updated this revision to Diff 224148. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68614/new/ https://reviews.llvm.org/D68614 Files: test/CMakeLists.txt Index: test/CMakeLists.txt === --- test/CMakeLists.txt +++ test/CMakeLists.txt @@ -58,9 +58,14 @@ llvm-mc llvm-objcopy llvm-readobj - llvm-strip ) +# Since llvm-strip is a symlink created by add_custom_target, it +# doesn't expose an export target when building standalone. +if(NOT LLDB_BUILT_STANDALONE) + add_lldb_test_dependency(llvm-strip) +endif() + if(TARGET lld) add_lldb_test_dependency(lld) else() Index: test/CMakeLists.txt === --- test/CMakeLists.txt +++ test/CMakeLists.txt @@ -58,9 +58,14 @@ llvm-mc llvm-objcopy llvm-readobj - llvm-strip ) +# Since llvm-strip is a symlink created by add_custom_target, it +# doesn't expose an export target when building standalone. +if(NOT LLDB_BUILT_STANDALONE) + add_lldb_test_dependency(llvm-strip) +endif() + if(TARGET lld) add_lldb_test_dependency(lld) else() ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip
gmittert updated this revision to Diff 224147. gmittert added a comment. Updated/Rebased for the rename of lit->test Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68614/new/ https://reviews.llvm.org/D68614 Files: test/CMakeLists.txt Index: test/CMakeLists.txt === --- test/CMakeLists.txt +++ test/CMakeLists.txt @@ -58,9 +58,14 @@ llvm-mc llvm-objcopy llvm-readobj - llvm-strip ) +# Since llvm-strip is a symlink created by add_custom_target, it +# doesn't expose an export target when building standalone. +if(NOT LLDB_BUILT_STANDALONE) + add_lldb_test_dependency(llvm-stirp) +endif() + if(TARGET lld) add_lldb_test_dependency(lld) else() Index: test/CMakeLists.txt === --- test/CMakeLists.txt +++ test/CMakeLists.txt @@ -58,9 +58,14 @@ llvm-mc llvm-objcopy llvm-readobj - llvm-strip ) +# Since llvm-strip is a symlink created by add_custom_target, it +# doesn't expose an export target when building standalone. +if(NOT LLDB_BUILT_STANDALONE) + add_lldb_test_dependency(llvm-stirp) +endif() + if(TARGET lld) add_lldb_test_dependency(lld) else() ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip
gmittert added a comment. Thanks! Can someone commit this for me? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68614/new/ https://reviews.llvm.org/D68614 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip
gmittert updated this revision to Diff 223903. gmittert added a comment. Alright, rebased and added a comment to it Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68614/new/ https://reviews.llvm.org/D68614 Files: lit/CMakeLists.txt Index: lit/CMakeLists.txt === --- lit/CMakeLists.txt +++ lit/CMakeLists.txt @@ -56,9 +56,14 @@ llvm-mc llvm-objcopy llvm-readobj - llvm-strip ) +# Since llvm-strip is a symlink created by add_custom_target, it +# doesn't expose an export target when building standalone. +if(NOT LLDB_BUILT_STANDALONE) + list(APPPEND LLDB_TEST_DEPS llvm-strip) +endif() + if(TARGET lld) add_lldb_test_dependency(lld) endif() Index: lit/CMakeLists.txt === --- lit/CMakeLists.txt +++ lit/CMakeLists.txt @@ -56,9 +56,14 @@ llvm-mc llvm-objcopy llvm-readobj - llvm-strip ) +# Since llvm-strip is a symlink created by add_custom_target, it +# doesn't expose an export target when building standalone. +if(NOT LLDB_BUILT_STANDALONE) + list(APPPEND LLDB_TEST_DEPS llvm-strip) +endif() + if(TARGET lld) add_lldb_test_dependency(lld) endif() ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip
gmittert created this revision. gmittert added reviewers: compnerd, kwk. Herald added subscribers: lldb-commits, JDevlieghere, mgorny. Herald added a project: LLDB. When building standalone, since llvm-strip is a symlink, it is created using add_custom_command/add_custom_target which cannot be exported, and thus cannot be depended on by lldb. Repository: rLLDB LLDB https://reviews.llvm.org/D68614 Files: lit/CMakeLists.txt Index: lit/CMakeLists.txt === --- lit/CMakeLists.txt +++ lit/CMakeLists.txt @@ -60,8 +60,10 @@ llvm-mc llvm-objcopy llvm-readobj - llvm-strip ) +if(NOT LLDB_BUILT_STANDALONE) + list(APPEND LLDB_TEST_DEPS llvm-strip) +endif() if(TARGET lld) list(APPEND LLDB_TEST_DEPS lld) Index: lit/CMakeLists.txt === --- lit/CMakeLists.txt +++ lit/CMakeLists.txt @@ -60,8 +60,10 @@ llvm-mc llvm-objcopy llvm-readobj - llvm-strip ) +if(NOT LLDB_BUILT_STANDALONE) + list(APPEND LLDB_TEST_DEPS llvm-strip) +endif() if(TARGET lld) list(APPEND LLDB_TEST_DEPS lld) ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D66445: Explicitly Cast Constants to DWORD
jmittert added a comment. I believe it's using the one in ntstatus.h 10.0.16299.0\shared\ntstatus.h #define STATUS_BREAKPOINT((NTSTATUS)0x8003L)// winnt And `NTSTATUS` is defined as a `LONG` in powerbase.h 10.0.16299.0\um\powerbase.h #define NTSTATUS LONG which would make it a signed (negative) number. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66445/new/ https://reviews.llvm.org/D66445 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D66448: Include "windows" Instead of "Windows"
gmittert created this revision. gmittert added reviewers: xiaobai, JDevlieghere, labath, asmith. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The actual include directory is `lldb/Host/windows` not `lldb/Host/Windows` which breaks on case sensitive file systems Repository: rLLDB LLDB https://reviews.llvm.org/D66448 Files: source/Plugins/Process/Windows/Common/NativeRegisterContextWindows.cpp source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_WoW64.cpp source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_i386.cpp source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_x86_64.cpp source/Plugins/Process/Windows/Common/NativeThreadWindows.cpp Index: source/Plugins/Process/Windows/Common/NativeThreadWindows.cpp === --- source/Plugins/Process/Windows/Common/NativeThreadWindows.cpp +++ source/Plugins/Process/Windows/Common/NativeThreadWindows.cpp @@ -10,7 +10,7 @@ #include "NativeProcessWindows.h" #include "lldb/Host/HostThread.h" -#include "lldb/Host/Windows/HostThreadWindows.h" +#include "lldb/Host/windows/HostThreadWindows.h" #include "lldb/Host/windows/windows.h" #include "lldb/Target/Process.h" #include "lldb/Utility/Log.h" Index: source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_x86_64.cpp === --- source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_x86_64.cpp +++ source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_x86_64.cpp @@ -16,7 +16,7 @@ #include "ProcessWindowsLog.h" #include "lldb/Host/HostInfo.h" #include "lldb/Host/HostThread.h" -#include "lldb/Host/Windows/HostThreadWindows.h" +#include "lldb/Host/windows/HostThreadWindows.h" #include "lldb/Host/windows/windows.h" #include "lldb/Utility/Log.h" Index: source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_i386.cpp === --- source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_i386.cpp +++ source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_i386.cpp @@ -15,7 +15,7 @@ #include "ProcessWindowsLog.h" #include "lldb/Host/HostInfo.h" #include "lldb/Host/HostThread.h" -#include "lldb/Host/Windows/HostThreadWindows.h" +#include "lldb/Host/windows/HostThreadWindows.h" #include "lldb/Host/windows/windows.h" #include "lldb/Utility/Log.h" Index: source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_WoW64.cpp === --- source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_WoW64.cpp +++ source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_WoW64.cpp @@ -15,7 +15,7 @@ #include "ProcessWindowsLog.h" #include "lldb/Host/HostInfo.h" #include "lldb/Host/HostThread.h" -#include "lldb/Host/Windows/HostThreadWindows.h" +#include "lldb/Host/windows/HostThreadWindows.h" #include "lldb/Host/windows/windows.h" #include "lldb/Utility/Log.h" Index: source/Plugins/Process/Windows/Common/NativeRegisterContextWindows.cpp === --- source/Plugins/Process/Windows/Common/NativeRegisterContextWindows.cpp +++ source/Plugins/Process/Windows/Common/NativeRegisterContextWindows.cpp @@ -7,7 +7,7 @@ //===--===// #include "lldb/Host/HostThread.h" -#include "lldb/Host/Windows/HostThreadWindows.h" +#include "lldb/Host/windows/HostThreadWindows.h" #include "lldb/Host/windows/windows.h" #include "lldb/Utility/Log.h" Index: source/Plugins/Process/Windows/Common/NativeThreadWindows.cpp === --- source/Plugins/Process/Windows/Common/NativeThreadWindows.cpp +++ source/Plugins/Process/Windows/Common/NativeThreadWindows.cpp @@ -10,7 +10,7 @@ #include "NativeProcessWindows.h" #include "lldb/Host/HostThread.h" -#include "lldb/Host/Windows/HostThreadWindows.h" +#include "lldb/Host/windows/HostThreadWindows.h" #include "lldb/Host/windows/windows.h" #include "lldb/Target/Process.h" #include "lldb/Utility/Log.h" Index: source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_x86_64.cpp === --- source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_x86_64.cpp +++ source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_x86_64.cpp @@ -16,7 +16,7 @@ #include "ProcessWindowsLog.h" #include "lldb/Host/HostInfo.h" #include "lldb/Host/HostThread.h" -#include "lldb/Host/Windows/HostThreadWindows.h" +#include "lldb/Host/windows/HostThreadWindows.h" #include "lldb/Host/windows/windows.h" #include "lldb/Utility/Log.h" Index: source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_i386.cpp
